Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 249140 [META][CSS Shapes] Implement CSS Shapes Level 1
Starred by 9 users Reported by bear.tra...@gmail.com, Jun 12 2013 Back to list
Status: Fixed
Owner:
Closed: Aug 2014
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Status: ----
Launch-Test: ----
Launch-UI: ----


Sign in to add a comment
Change description:
Implement the CSS Shapes Specification, which adds support for customizing the areas inside and around which content flows.

Changes to API surface:
* Addition of CSS properties (shape-outside, shape-inside, shape-margin, shape-padding, shape-image-threshold)
* Addition of CSS Shape Values

WebKit bug:
https://bugs.webkit.org/show_bug.cgi?id=57311

Links:
Public standards discussion:
http://dev.w3.org/csswg/css-shapes

Support in other browsers: current (expected)
Internet Explorer: None
Firefox: None
Safari: Partial support in nightlies
Opera: None
 
Comment 1 by betra...@adobe.com, Jun 13 2013
Labels: OWP-Type-NewAPI OWP-Standards-OfficialSpec OWP-Format-Prefix OWP-Launch-Bug-Needed
This bug reflects the split between CSS Exclusions and CSS Shapes. See http://crbug.com/234749
Comment 2 by bjone...@adobe.com, Jul 26 2013
Blockedon: chromium:260357
Cc: bjone...@adobe.com
Comment 3 by bjone...@adobe.com, Sep 6 2013
Blockedon: chromium:286448
Comment 4 by betra...@adobe.com, Nov 21 2013
Blockedon: chromium:322165
Comment 5 by zol...@adobe.com, Feb 18 2014
Summary: [META][CSS Shapes] Implement CSS Shapes (was: [CSS Shapes] Implement CSS Shapes)
Comment 6 by betra...@adobe.com, Feb 26 2014
Summary: [META][CSS Shapes] Implement CSS Shapes Level 1 (was: [META][CSS Shapes] Implement CSS Shapes)
Modifying bug title to reflect the Shapes split into Level 1 and Level 2.
Blockedon: chromium:339584
Adding a CSS shapes related crasher as blocking this meta bug.
Comment 8 by hmul...@adobe.com, Feb 28 2014
If the "crasher" you're referring to is http://code.google.com/p/chromium/issues/detail?id=339584, then it's been fixed: https://code.google.com/p/chromium/issues/detail?id=339584#c12.  

Investigation of 339584 did turn up an unrelated problem, with SVG images whose root element size is relative: https://code.google.com/p/chromium/issues/detail?id=344579. 

Project Member Comment 9 by bugdroid1@chromium.org, Feb 28 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168155

------------------------------------------------------------------------
r168155 | bjonesbe@adobe.com | 2014-02-28T19:03:58.475759Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/shapes/ShapeOutsideInfo.h?r1=168155&r2=168154&pathrev=168155
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000-expected.html?r1=168155&r2=168154&pathrev=168155
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000.html?r1=168155&r2=168154&pathrev=168155
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001-expected.html?r1=168155&r2=168154&pathrev=168155
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001.html?r1=168155&r2=168154&pathrev=168155
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002-expected.html?r1=168155&r2=168154&pathrev=168155
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002.html?r1=168155&r2=168154&pathrev=168155
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/shapes/ShapeOutsideInfo.cpp?r1=168155&r2=168154&pathrev=168155
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/FloatingObjects.cpp?r1=168155&r2=168154&pathrev=168155
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/line/LineWidth.cpp?r1=168155&r2=168154&pathrev=168155

Stacked floats with shape-outside should allow inline content to interact with the non-outermost float

Make inline content interact with stacked floats with shape-outside per
the spec. This means that content can interact with floats on the line
that are not the outermost float.

This refactors ComputeFloatOffsetAdapter into a superclass and two
subclasses: one adaptor for determining the offset for float layout, and
one for determining the offset for inline layout.

The logic in LineWidth::shrinkAvailableWidthForNewFloatIfNeeded has been
updated to handle stacked floats with shape-outside properly and has
been considerably simplified in the process. It was previously doing a
whole bunch of unnecessary work.

This is a port from WebKit of http://trac.webkit.org/changeset/162217

BUG= 249140 

Review URL: https://codereview.chromium.org/149513005
------------------------------------------------------------------------
Blocking: chromium:349093
Blocking: -chromium:349093
Blockedon: chromium:349093
Comment 13 by betra...@adobe.com, Mar 11 2014
Blockedon: chromium:351441
Blockedon: chromium:351775
Comment 15 by rwlb...@gmail.com, Apr 2 2014
Owner: rob.b...@samsung.com
Assign to me.
The issue in crbug.com/339584 should not be a blocker for SVG shapes, it's a cleanup bug related to work we did with repaint-after-layout. We're specifically allowing the calls to happen now, we just want to clean up the way things are working in the future.
Blockedon: -chromium:339584
@dsinclair great, I've removed it from the list of blocking bugs.

@rwbuis: do you think we should close this bug since CSS Shapes is going to ship, or should we wait until Chrome 37 is officially out the door?
Comment 19 by mathi...@opera.com, Aug 27 2014
Status: Fixed
Chrome 37 shipped with this feature enabled by default.
Sign in to add a comment