New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2013
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----



Sign in to add a comment
link

Issue 249132: Remove support for multipart/x-mixed-replace main resources

Reported by abarth@chromium.org, Jun 12 2013 Project Member

Issue description

(See http://www.chromium.org/blink#launch-process for an overview)

Change description:
I intend to remove support for multipart/x-mixed-replace for main resources.  We will continue to support multipart images and animated images.

This feature is extremely rarely used by web sites and is the source of a lot of complexity and security bugs in the loader.  UseCounter stats from the stable channel indicate that the feature is used for less than 0.00001% of page loads.

Changes to API surface:
Main resources that use the multipart/x-mixed-replace will now trigger downloads rather than being displayed in a tab.

Links:
Public standards discussion: N/A

Support in other browsers:
Internet Explorer: Unknown
Firefox: Unknown
Safari: Unknown
Opera: Unknown
 

Comment 1 by bugdroid1@chromium.org, Jun 13 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=152363

------------------------------------------------------------------------
r152363 | abarth@chromium.org | 2013-06-13T17:49:56.628581Z

Changed paths:
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/multipart-html-expected.txt?r1=152363&r2=152362&pathrev=152363
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameLoader.h?r1=152363&r2=152362&pathrev=152363
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/policy-ignore-crash.php?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/resources/multipart-wait-before-boundary.php?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/invalid-image-data-standalone.html?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/multipart-wait-before-boundary.html?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/multipart-html.php?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/load-last-non-html-frame-expected.txt?r1=152363&r2=152362&pathrev=152363
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentLoader.cpp?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/multipart-replace-non-html-content.php?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/resources/multipart-nodashes.php?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/win-boundary-crash.html-disabled?r1=152363&r2=152362&pathrev=152363
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentLoader.h?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/load-last-non-html-frame.php?r1=152363&r2=152362&pathrev=152363
   M http://src.chromium.org/viewvc/blink/trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/win-boundary-crash-expected.txt?r1=152363&r2=152362&pathrev=152363
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ResourceLoader.cpp?r1=152363&r2=152362&pathrev=152363
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/multipart/policy-ignore-crash-expected.txt?r1=152363&r2=152362&pathrev=152363
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameLoader.cpp?r1=152363&r2=152362&pathrev=152363

Remove support for multipart/x-mixed-replace

This feature adds a lot of complexity to the loader and is used by less than
0.00001% of page loads.

R=darin
BUG= 249132 
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16848005
------------------------------------------------------------------------

Comment 2 by abarth@chromium.org, Jun 13 2013

Status: Fixed

Comment 3 by bolive...@gmail.com, Aug 28 2013

Hello,

We are using this feature, and we would like to know what are the alternatives to this method.

Comment 4 by Deleted ...@, Oct 7 2013

Hello, 
This is unfortuneate news.  Chrome was our go-to browser for features like this that just seemed to work where others like IE didn't support at all or at least very well.  We had relied on multipart support for accessing our CUPS web interface version that is part of RHEL 6.  For now we are forced to move on to using Firefox as yet another browser.  Future versions of CUPS no longer rely on multipart, probably because of browser compatibility.  Seems like the trend is to move away from it.

Comment 5 by bugdroid1@chromium.org, Feb 22 2014

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=167631

------------------------------------------------------------------------
r167631 | philipj@opera.com | 2014-02-22T06:47:27.093851Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.cpp?r1=167631&r2=167630&pathrev=167631
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.h?r1=167631&r2=167630&pathrev=167631

Remove unused UseCounter features

These are the bugs/reviews in which the enum values became unused:

MultipartMainResource:
https://code.google.com/p/chromium/issues/detail?id=249132

InputTypeDateTime:
https://code.google.com/p/chromium/issues/detail?id=239210

HTMLShadowElementOlderShadowRoot:
https://code.google.com/p/chromium/issues/detail?id=339025

ShadowDOMPrefixedPseudo:
https://code.google.com/p/chromium/issues/detail?id=321953

CSSDisplayRunIn:
https://codereview.chromium.org/53373003

CSSDisplayCompact:
https://codereview.chromium.org/52713012

DocumentTypeEntities:
https://code.google.com/p/chromium/issues/detail?id=342302

DocumentTypeNotations:
https://code.google.com/p/chromium/issues/detail?id=342286

ScrollTopBodyNotQuirksMode, ScrollLeftBodyNotQuirksMode:
https://code.google.com/p/chromium/issues/detail?id=314700

BUG=none

Review URL: https://codereview.chromium.org/173023004
------------------------------------------------------------------------

Sign in to add a comment