New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 73 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug


Sign in to add a comment

[meta] Use Skia on Windows

Project Member Reported by e...@chromium.org, Jun 12 2013

Issue description

Meta bug for moving the windows font code to Skia instead of using GDI directly. This will in turn allow us to switch to the DirectWrite backend.
 

Comment 1 by e...@chromium.org, Jun 12 2013

Blockedon: chromium:249100
 Bug 249100 : Add flag to use Skia for measuring text on windows

Comment 2 by e...@chromium.org, Jun 12 2013

Cc: wiltzius@chromium.org

Comment 3 by e...@chromium.org, Jun 17 2013

Blockedon: chromium:250833
 Bug 250833 : Remove windows specific platformCreateScaledFontData

Comment 4 by e...@chromium.org, Jun 17 2013

Blockedon: chromium:250859
 Bug 250859 : Move windows specific isFixedPitch to FontPlatformData

Comment 5 by e...@chromium.org, Jun 18 2013

Blockedon: chromium:251338
 Bug 251338 : Use skia GlyphPage implementation on windows

Comment 6 by e...@chromium.org, Jun 18 2013

Blockedon: chromium:251355
 Bug 251355 : Remove dependencies on FontPlatformDataChromiumWin::hfont()

Comment 7 by e...@chromium.org, Jun 21 2013

Blockedon: chromium:252705
 Bug 252705 : Use TEXTMETRICS for font metrics for Skia/GDI

Comment 8 by girard@chromium.org, Jun 26 2013

Blocking: chromium:160457
Blocking: chromium:25541

Comment 10 by e...@chromium.org, Jun 27 2013

Blockedon: chromium:255045
 Bug 255045 : Use FontMetrics::fMaxCharWidth for maxCharWidth on Windows

Comment 11 by e...@chromium.org, Jun 28 2013

Blockedon: chromium:255500
 Bug 255500 : Use Skia implementation of openTypeTable on Windows

Comment 12 by e...@chromium.org, Jul 3 2013

Blockedon: chromium:257107
 Bug 257107 : Share common font fallback logic across platforms
Owner: e...@chromium.org
Status: Started

Comment 14 by msw@chromium.org, Jul 12 2013

Related browser UI (not web-content) efforts:  Issue 125348 ,  Issue 124492 , and  Issue 131660 .

Comment 15 by js...@chromium.org, Jul 23 2013

Cc: js...@chromium.org
Blockedon: chromium:265268 chromium:265269
This is also blocked on https://code.google.com/p/skia/issues/detail?id=977 (Add family name support for SKTypeface). This is needed for other reasons as well, but here it would be used for Blink to check whether the SkTypeface it gets back from Skia is either an exact match or 'close enough'. 
Blockedon: skia:977
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 19 2013

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 5 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=157244

------------------------------------------------------------------------
r157244 | eae@chromium.org | 2013-09-04T21:04:56.179139Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp?r1=157244&r2=157243&pathrev=157244
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/FontCacheSkia.cpp?r1=157244&r2=157243&pathrev=157244
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/FontCache.cpp?r1=157244&r2=157243&pathrev=157244
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/FontCache.h?r1=157244&r2=157243&pathrev=157244

Switch non-gdi windows font path to use new SkFontMgr

Switch the Skia font rendering codepath (which is not on by default)
to use the new SkFontMgr class for typeface construction.

BUG= 249099 
R=reed@google.com

Review URL: https://chromiumcodereview.appspot.com/23480016
------------------------------------------------------------------------
Blockedon: chromium:293438
Blockedon: chromium:293568
Blockedon: chromium:294232
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 18 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=157985

------------------------------------------------------------------------
r157985 | eae@chromium.org | 2013-09-18T23:10:14.268862Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp?r1=157985&r2=157984&pathrev=157985

Fix typefacesMatchesFamily to treat family string as UTF8

Fix bug in FontCacheSkiaWin::typefacesMatchesFamily where the family
name returned by skia was converted to cstring without setting the
encoding to UTF8.

This was caught by fast/text/backslash-to-yen-sign-euc.html and is
only applicable if the GDI code path is disabled.

BUG= 249099 
R=bungeman@google.com

Review URL: https://chromiumcodereview.appspot.com/23549036
------------------------------------------------------------------------
Project Member

Comment 25 by bugdroid1@chromium.org, Sep 19 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=158042

------------------------------------------------------------------------
r158042 | eae@chromium.org | 2013-09-19T18:28:33.054897Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp?r1=158042&r2=158041&pathrev=158042

Add AtomicString, SkString version of equalIgnoringCase

Add a version of equalIgnoringCase that takes an AtomicString and a
SkString and use it for font family matches. This takes care of the
encoding logic and ensures that the easiest way to compare the two
is the right way.

R=eseidel@chromium.org,leviw@chromium.org
BUG= 249099 

Review URL: https://chromiumcodereview.appspot.com/23835013
------------------------------------------------------------------------
Project Member

Comment 26 by bugdroid1@chromium.org, Sep 27 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=158352

------------------------------------------------------------------------
r158352 | eae@chromium.org | 2013-09-26T05:58:32.600102Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp?r1=158352&r2=158351&pathrev=158352
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/FontChromiumWin.cpp?r1=158352&r2=158351&pathrev=158352
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/UniscribeHelper.h?r1=158352&r2=158351&pathrev=158352
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.h?r1=158352&r2=158351&pathrev=158352
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/SkiaFontWin.cpp?r1=158352&r2=158351&pathrev=158352
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/UniscribeHelper.cpp?r1=158352&r2=158351&pathrev=158352
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/SkiaFontWin.h?r1=158352&r2=158351&pathrev=158352

Merge FontPlatformData::setupPaint and setupPaintForFont on Win

We currently have two different setupPaint methods for the font
graphics code on windows, one used for drawing (setupPaintForFont)
and one used for metrics for the non-gdi code path (setupPaint).

This is silly and error prone, merge the two into
FontPlatformData::setupPaint.

BUG= 249099 

Review URL: https://chromiumcodereview.appspot.com/24422003
------------------------------------------------------------------------
Project Member

Comment 27 by bugdroid1@chromium.org, Sep 27 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=158380

------------------------------------------------------------------------
r158380 | eae@chromium.org | 2013-09-26T16:37:43.471047Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp?r1=158380&r2=158379&pathrev=158380
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.h?r1=158380&r2=158379&pathrev=158380

Implement support for fake bold/italics for non-GDI windows font path

Add plumbing for fake bold/italics to the windows non-GDI font path
and pass the values along to skia.

BUG= 249099 
R=bungeman@chromium.org, schenney@chromium.org

Review URL: https://codereview.chromium.org/24609002
------------------------------------------------------------------------
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 28 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=158489

------------------------------------------------------------------------
r158489 | eae@chromium.org | 2013-09-28T04:38:48.000508Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/SkiaFontWin.cpp?r1=158489&r2=158488&pathrev=158489

Update SkiaFontWin::paintSkiaText to override typeface for HFONT

Update the SkiaFontWin::paintSkiaText method to enable the setTypeface
call regardless of the GDI_FONTS_ON_WINDOWS flag as the HFONT path is
still used by Uniscribe when GDI is disabled.

R=leviw@chromium.org
BUG= 249099 

Review URL: https://chromiumcodereview.appspot.com/25094004
------------------------------------------------------------------------
Project Member

Comment 29 by bugdroid1@chromium.org, Sep 28 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=158495

------------------------------------------------------------------------
r158495 | eae@chromium.org | 2013-09-28T16:08:13.935339Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp?r1=158495&r2=158494&pathrev=158495
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp?r1=158495&r2=158494&pathrev=158495
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.h?r1=158495&r2=158494&pathrev=158495
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/FontPlatformDataSkia.cpp?r1=158495&r2=158494&pathrev=158495

Have all skia platforms share FontPlatformData::hash() implementation

Update Windows to use a SkTypeface based hash value for FontPlatformData
when the non-GDI path is used. Move the existing implementation from
FontPlatformDataHarfBuzz to FontPlatformDataSkia to allow and to ensure
that all skia platforms share the same implementation.

Also, rename m_size to m_textSiz for FontPlatformDataChromiumWin to be
consistent with the other platforms.

R=bungeman@chromium.org
BUG= 249099 

Review URL: https://chromiumcodereview.appspot.com/24874002
------------------------------------------------------------------------
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 1 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=158584

------------------------------------------------------------------------
r158584 | eae@chromium.org | 2013-10-01T03:13:00.624570Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/block/lineboxcontain/glyphs-expected.txt?r1=158584&r2=158583&pathrev=158584
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt?r1=158584&r2=158583&pathrev=158584
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/block/lineboxcontain/glyphs-expected.png?r1=158584&r2=158583&pathrev=158584
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/repaint/stacked-diacritics-expected.png?r1=158584&r2=158583&pathrev=158584
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/text/emphasis-expected.png?r1=158584&r2=158583&pathrev=158584
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/block/lineboxcontain/block-glyphs-expected.txt?r1=158584&r2=158583&pathrev=158584
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/block/lineboxcontain/block-glyphs-replaced-expected.png?r1=158584&r2=158583&pathrev=158584
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/text/decorations-with-text-combine-expected.png?r1=158584&r2=158583&pathrev=158584
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/block/lineboxcontain/block-glyphs-expected.png?r1=158584&r2=158583&pathrev=158584
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/SimpleFontDataSkia.cpp?r1=158584&r2=158583&pathrev=158584

Change SimpleFontData::platformBoundsForGlyph to use getTextPath

On skia platforms we currnetly implement platformBoundsForGlyph by
using the measureText API. This returns a conservative bounding box
intended for paint but it is close enough to the actual metrics in
most cases. For vertical text however it tends to overly inflated.

Change it to use the getTextPath API instead which returns more
precise metrics instead for text metrics.

BUG= 249099 

Review URL: https://codereview.chromium.org/25045010
------------------------------------------------------------------------

Comment 31 by e...@chromium.org, Oct 2 2013

Blockedon: chromium:302846
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 3 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=158845

------------------------------------------------------------------------
r158845 | eae@chromium.org | 2013-10-03T23:41:15.572599Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/features.gypi?r1=158845&r2=158844&pathrev=158845
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=158845&r2=158844&pathrev=158845

Switch Windows to use Skia for text metrics

Switch the Windows port to use Skia instead of GDI directly for text
metrics, font selection and paint setup.

BUG= 249099 
R=reed@google.com

Review URL: https://codereview.chromium.org/25773002
------------------------------------------------------------------------
Project Member

Comment 33 by bugdroid1@chromium.org, Oct 4 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=158867

------------------------------------------------------------------------
r158867 | ojan@chromium.org | 2013-10-04T02:12:38.654240Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/writing-mode/border-vertical-lr-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/use-referencing-nonexisting-symbol-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/css2.1/t100801-c544-valgn-02-d-agi-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/css/font-face-locally-installed-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/text/text-viewbox-rescale-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/text/font-size-below-point-five-2-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/css2.1/t100801-c544-valgn-03-d-agi-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/forms/placeholder-position-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/text/midword-break-before-surrogate-pair-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/js-late-clipPath-creation-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/text/international/vertical-text-glyph-test-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/repaint/japanese-rl-selection-repaint-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/writing-mode/japanese-rl-selection-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/writing-mode/japanese-lr-text-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/hixie/viewbox/003-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/zoom/page/zoom-foreignObject-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/media/video-zoom-controls-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png?r1=158867&r2=158866&pathrev=158867
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt?r1=158867&r2=158866&pathrev=158867
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/text/international/spaces-combined-in-vertical-text-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/text/text-fonts-02-t-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/writing-mode/japanese-rl-text-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/text/decorations-with-text-combine-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/repaint/japanese-rl-selection-clear-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/forms/caret-rtl-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/css/font-face-synthetic-bold-italic-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/writing-mode/japanese-lr-selection-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/text/international/text-combine-image-test-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/text/justify-ideograph-vertical-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/text/decorations-with-text-combine-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/repaint/stacked-diacritics-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/transforms/animated-path-inside-transformed-html-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/use-referencing-nonexisting-symbol-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/css/font-face-locally-installed-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/transforms?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/text/emphasis-vertical-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/css/font-face-weight-matching-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/text/midword-break-before-surrogate-pair-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/text/international/vertical-text-glyph-test-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/text/international/text-combine-image-test-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/css2.1/t100801-c544-valgn-04-d-agi-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/dynamic/text-combine-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/writing-mode/japanese-lr-text-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/inline/justify-emphasis-inline-box-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/transforms/text-with-pattern-with-svg-transform-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/text/non-bmp-positioning-lists-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/hixie/viewbox/002-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/transforms/text-with-mask-with-svg-transform-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png?r1=158867&r2=158866&pathrev=158867
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/css/font-face-weight-matching-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/css2.1/t100801-c544-valgn-04-d-agi-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/js-late-gradient-creation-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/compositing/shadows/shadow-drawing-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/text/text-fonts-02-t-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/text/justify-ideograph-vertical-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/forms/caret-rtl-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/css/font-weight-1-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/direct-image-compositing-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/shadows/shadow-drawing-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png?r1=158867&r2=158866&pathrev=158867
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/text/non-bmp-positioning-lists-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/hixie/viewbox/003-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/repaint/japanese-rl-selection-clear-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png?r1=158867&r2=158866&pathrev=158867
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/css/font-face-locally-installed-expected.txt?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/text/international/text-spliced-font-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/writing-mode/border-vertical-lr-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/css2.1/t100801-c544-valgn-02-d-agi-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/virtual/softwarecompositing/shadows/shadow-drawing-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/fast/repaint/japanese-rl-selection-repaint-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/text/font-size-below-point-five-2-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/reflections/nested-reflection-transition-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/css/font-face-synthetic-bold-italic-expected.txt?r1=158867&r2=158866&pathrev=158867
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/css/font-weight-1-expected.txt?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/text/text-text-07-t-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/text/international/vertical-text-glyph-test-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/shadows/shadow-drawing-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/repaint/japanese-rl-selection-repaint-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/js-late-pattern-creation-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/writing-mode/japanese-rl-selection-expected.png?r1=158867&r2=158866&pathrev=158867
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png?r1=158867&r2=158866&pathrev=158867
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/wicd/test-scalable-background-image2-expected.png?r1=158

Comment 35 by raina...@gmail.com, Nov 21 2013

Just wanted to add a use-case where there is still an issue as of m33-dev. I'm running Windows 8.1, 200% DPI (MBP Retina 15 so 2880x1800 I think) and have the HIDPI flag on which corrected nearly all issues (after Windows Font sizes were updated anyway) but SELECT elements render very "fuzzy" text. All other menus, page text and tabs look good though.
It looks like Build 239354 just got pushed with the DirectWrite flag.

https://code.google.com/p/chromium/issues/detail?id=25541#c59

Is that just the switch, because it looks like enabling it doesn't do anything?
directwrite.png
59.6 KB View Download

Comment 37 by e...@chromium.org, Dec 8 2013

dabbaking: we're still missing a couple of pieces but it should start working before long.
Project Member

Comment 38 by bugdroid1@chromium.org, Dec 10 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=163507

------------------------------------------------------------------------
r163507 | eae@chromium.org | 2013-12-10T07:10:35.616629Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/skia/SkiaFontWin.cpp?r1=163507&r2=163506&pathrev=163507
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/FontPlatformDataWin.h?r1=163507&r2=163506&pathrev=163507
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/FontPlatformDataWin.cpp?r1=163507&r2=163506&pathrev=163507

Don't check lfQuality in LOGFONT as it has no effect on rendering

Remove the LOGFONT lfQuality check in computePaintTextFlags and instead
base the textFlags entierly on the system ClearType settings (and
whether a font is a web font). Skia will then use this information to
pick the appropriate type of font smoothing to apply (if any).

BUG= 249099 
R=bungeman@chromium.org

Review URL: https://codereview.chromium.org/99333013
------------------------------------------------------------------------

Comment 39 by e...@chromium.org, Dec 11 2013

Status: Fixed
We are now using the Skia APIs everywhere instead of calling GDI directly. For now Skia still calls out to GDI by default though.

Comment 40 by e...@chromium.org, Dec 16 2013

Un reply to comment #36;

dabbaking, please retest using the latest canary build (33.0.1738.0 or later) with the following flags: "--no-sandbox --enable-direct-write".

I retested it. Looks like it's implemented, but I noticed this issue with the font size on the new tab page. Not sure which sub-issue this would be related to?

Notice with the --no-sandbox flag the font appears smaller, same computed style on both. Since it's a straight up int for a size, I don't think it's subpixel rendering. It looks to me like it's rendering Arial Narrow instead of Arial with DirectWrite. I tried with just --no-sandbox and no DirectWrite and it doesn't render smaller, so it's definitely an issue with the DirectWrite support.
font width.png
76.1 KB View Download
First of all: holy shit, finally.

Second: the tab crashes on that tab: http://ie.microsoft.com/testdrive/Graphics/opentype/opentype-fontbureau/index.html
I can confirm @41 on 33.0.1750.3 (Official Build 241270) dev-m
Along the results of @42, this tab crashes with direct write enabled: 

http://www.washingtonpost.com/blogs/the-switch/wp/2013/12/18/research-shows-how-macbook-webcams-can-spy-on-their-users-without-warning/?wprss=rss_technology

I don't know if it's related, so sorry if it's a redundant comment.
Can confirm @44 on 34.0.1751.0 canary.

Comment 46 by e...@chromium.org, Dec 25 2013

Labels: Restrict-AddIssueComment-EditIssue
Please report issues with DirectWrite support on  bug 25541  or file a new bug report and cc me directly. Thanks!

Project Member

Comment 47 by bugdroid1@chromium.org, Feb 12 2014

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=167045

------------------------------------------------------------------------
r167045 | eae@chromium.org | 2014-02-12T21:50:24.654580Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/skia/SkiaFontWin.cpp?r1=167045&r2=167044&pathrev=167045
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/FontPlatformDataWin.h?r1=167045&r2=167044&pathrev=167045
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/FontPlatformDataWin.cpp?r1=167045&r2=167044&pathrev=167045

Re-land "Don't check lfQuality in LOGFONT as it has no effect on rendering""

Re-land change r163507, reverted as r166868 but include a cache for the
text flags, as before the original change, to avoid the performance
penalty that forced us to revert the original change in the first
place.

Remove the LOGFONT lfQuality check in computePaintTextFlags and instead
base the textFlags entierly on the system ClearType settings (and
whether a font is a web font). Skia will then use this information to
pick the appropriate type of font smoothing to apply (if any).

BUG= 249099 
R=bungeman@chromium.org, leviw@chromium.org

Review URL: https://codereview.chromium.org/139203009
------------------------------------------------------------------------
Project Member

Comment 48 by bugdroid1@chromium.org, Feb 25 2014

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=167812

------------------------------------------------------------------------
r167812 | eae@chromium.org | 2014-02-25T19:10:15.628828Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/blink_platform.gyp?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/skia/FontCacheSkia.cpp?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/FontCache.cpp?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/FontCache.h?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/blink_platform.gypi?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/skia/FontPlatformDataSkia.cpp?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/FontCustomPlatformData.h?r1=167812&r2=167811&pathrev=167812
   D http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/FontCacheWin.cpp?r1=167812&r2=167811&pathrev=167812
   D http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/FontCustomPlatformDataWin.cpp?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/AlternateFontFamily.h?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/FontPlatformDataWin.cpp?r1=167812&r2=167811&pathrev=167812
   D http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/GlyphPageTreeNodeWin.cpp?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/FontPlatformDataWin.h?r1=167812&r2=167811&pathrev=167812
   D http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/SimpleFontDataWin.cpp?r1=167812&r2=167811&pathrev=167812
   M http://src.chromium.org/viewvc/blink/trunk/Source/build/features.gypi?r1=167812&r2=167811&pathrev=167812

Remove GDI font rendering code for windows

Remove the old windows font rendering code that calls GDI directly as
we now go through skia instead. As of M33 the skia code is used for all
channels and considered stable.

BUG= 249099 
R=dglazkov@google.com, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/179723005
------------------------------------------------------------------------
Project Member

Comment 49 by bugdroid1@chromium.org, Feb 25 2014

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=167823

------------------------------------------------------------------------
r167823 | eae@chromium.org | 2014-02-25T21:05:36.614661Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/fonts/win/FontPlatformDataWin.cpp?r1=167823&r2=167822&pathrev=167823

Remove redundant ifdef in FontPlatformDataWin.cpp

Remove #if OS(WIN) ifdef in FontPlatformDataWin.cpp as that file is
only ever compiled on windows.

TBR=eseidel@chromium.org
BUG= 249099 

Review URL: https://codereview.chromium.org/180123003
------------------------------------------------------------------------

Sign in to add a comment