Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 248918 Implement navigator.maxTouchPoints
Starred by 10 users Project Member Reported by rbyers@chromium.org, Jun 12, 2013 Back to list
Status: Verified
Owner: bokan@chromium.org
Closed: Mar 2014
Cc: aelias@chromium.org
Components:
OS: Android, Windows, Chrome
Pri: 2
Type: Feature


Sign in to add a comment
Pointer events defines an API for returning the maximum number of touch points: https://dvcs.w3.org/hg/pointerevents/raw-file/tip/pointerEvents.html#widl-Navigator-maxTouchPoints.  This is independent from the rest of PE and of value on it's own (eg. for a site to decide if it should show zoom controls or rely on pinch zoom).

We should consider exposing this independently, ahead of the rest of PE.
 
Comment 1 by rbyers@chromium.org, Jun 12, 2013
Blocking: chromium:162757
Comment 2 by girard@chromium.org, Jun 13, 2013
For Windows, GetSystemMetrics(SM_MAXIMUMTOUCHES) will give you the underlying value.
Comment 3 by rbyers@chromium.org, Sep 9, 2013
Owner: rbyers@chromium.org
Status: Started
Note that this has a LGTM for blink intent-to-implement & ship: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/maxTouchPoints/blink-dev/ayzxdztUlOQ/rd-z_Jo3ocIJ

sblom at microsoft has put up an initial CL here: https://codereview.chromium.org/20598008/

Assigning to myself for now since sblom does not yet have an account on the chromium bug tracker.
Comment 4 by sb...@microsoft.com, Oct 9, 2013
CL for the Chromium side: https://codereview.chromium.org/26764002/
Project Member Comment 5 by bugdroid1@chromium.org, Oct 22, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=160153

------------------------------------------------------------------------
r160153 | sblom@microsoft.com | 2013-10-22T08:43:36.455775Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt?r1=160153&r2=160152&pathrev=160153
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/navigator-maxTouchPoints.html?r1=160153&r2=160152&pathrev=160153
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/events/NavigatorEvents.cpp?r1=160153&r2=160152&pathrev=160153
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebSettingsImpl.cpp?r1=160153&r2=160152&pathrev=160153
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebSettings.h?r1=160153&r2=160152&pathrev=160153
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/events/NavigatorEvents.h?r1=160153&r2=160152&pathrev=160153
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/events/NavigatorEvents.idl?r1=160153&r2=160152&pathrev=160153
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebSettingsImpl.h?r1=160153&r2=160152&pathrev=160153
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/navigator-maxTouchPoints-expected.txt?r1=160153&r2=160152&pathrev=160153
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/RuntimeEnabledFeatures.in?r1=160153&r2=160152&pathrev=160153
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=160153&r2=160152&pathrev=160153
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Settings.in?r1=160153&r2=160152&pathrev=160153

Add navigator.maxTouchPoints

Intent to implement-and-ship: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/maxTouchPoints/blink-dev/ayzxdztUlOQ/rd-z_Jo3ocIJ

navigator.maxTouchPoints is defined in the W3C Pointer Events
standard draft:
http://www.w3.org/TR/pointerevents/#widl-Navigator-maxTouchPoints

BUG= 248918 

Review URL: https://codereview.chromium.org/27750002
------------------------------------------------------------------------
Comment 6 by rbyers@chromium.org, Oct 24, 2013
Labels: -Cr-UI-Input-Touch-Screen Cr-Internals-Input-Touch-Screen
Comment 7 by rbyers@chromium.org, Oct 25, 2013
Labels: Cr-Blink-Input
Project Member Comment 8 by bugdroid1@chromium.org, Oct 26, 2013
------------------------------------------------------------------------
r231203 | sblom@microsoft.com | 2013-10-26T12:53:41.031117Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/touch/touch_device_win.cc?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/touch/touch_device.cc?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/touch/touch_device_android.cc?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/touch/touch_device.h?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/touch/touch_device_aurax11.cc?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/common/webpreferences.cc?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/web_preferences.cc?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/common/webpreferences.h?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/AUTHORS?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/common_param_traits_macros.h?r1=231203&r2=231202&pathrev=231203
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/touch/touch_device_ozone.cc?r1=231203&r2=231202&pathrev=231203

Chromium side of maxTouchPoints implementation.

Intent to implement-and-ship: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/maxTouchPoints/blink-dev/ayzxdztUlOQ/rd-z_Jo3ocIJ

navigator.maxTouchPoints is defined in the W3C Pointer Events
standard draft:
http://www.w3.org/TR/pointerevents/#widl-Navigator-maxTouchPoints

Depends on blink revision 160153:
https://src.chromium.org/viewvc/blink?view=revision&revision=160153

BUG= 248918 

Review URL: https://codereview.chromium.org/26764002
------------------------------------------------------------------------
Comment 9 by rbyers@chromium.org, Oct 29, 2013
Blockedon: chromium:312926
Labels: M-35
Owner: bokan@chromium.org
David, when you get a chance can you please land the Android implementation here?  Once we have working implementations on all platforms we can take this out from behind the flag.  See discussion here: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/ayzxdztUlOQ/iXmy5oxuU2MJ
Comment 12 by bokan@chromium.org, Mar 10, 2014
Status: Fixed
Added Android implementation, Issue 308649 tracks enabling the feature by default.
Status: Verified
Comment 14 by rbyers@chromium.org, Aug 14, 2014
Blocking: chromium:403876
Comment 15 by rbyers@chromium.org, Mar 30, 2015
Blocking: chromium:471824
Sign in to add a comment