New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 24881 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Oct 2009
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

You should be able to use (slightly) bigger icons in browser actions (and maybe page actions)

Project Member Reported by aa@chromium.org, Oct 15 2009

Issue description

Glen and Cole claim the max size is 19, and that page and browser actions are 
the same. When I measured it on the mocks, it looked more like 21 and that 
page actions were smaller.
 

Comment 1 by bugdro...@gmail.com, Oct 19 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29365 

------------------------------------------------------------------------
r29365 | aa@chromium.org | 2009-10-16 18:03:26 -0700 (Fri, 16 Oct 2009) | 20 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/image_loading_tracker.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/image_loading_tracker.h?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.h?r1=29365&r2=29364
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/icon_size_test
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/icon_size_test/icon.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/icon_size_test/manifest.json

Allow slightly larger browser and page action icons.

This allows 19px icons to be able to be used for both
browser and page icons.

I think it looks nicer with the page actions slightly smaller, and that is what we also usually do in Chrome,
but some Chrome location bar icons use 18px for soft edges,
so I guess this will just have to be something we advise
developers on.

We can actually fit up to 21 (whoa nelly) pixels on Windows,
but apparently the space is slightly smaller on mac.

Also minor layout fix. We were sizing the browser action
buttons 1px too short.

BUG= 24881 
TEST=Load chrome/test/data/extensions/samples/icon_size_test. Icons should be 17px for the page action and 19px for the browser action and centered nicely in the space.

Review URL: http://codereview.chromium.org/286001
------------------------------------------------------------------------

Comment 2 by aa@chromium.org, Oct 19 2009

Status: Fixed
Labels: Feature-Extensions
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-4 -Feature-Extensions M-4 Cr-Platform-Extensions
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment