New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 24776 link

Starred by 17 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Menu reads "Google Chrome Helper"

Reported by srikanthk@chromium.org, Oct 14 2009

Issue description

Platform:
  Hostname: Macintosh-0023dfded9ed.local
  Mac OS X Version 10.5.8 (Build 9L31a)
  Processor: 4 Intel 2.66 GHz
  RAM: 2048 MB

Chrome:
  Chrome version: 4.0.222.5  <<<Release/Debug>>>
  QuickTime Player: 7.6.4
  QuickTime PlayerX: <unknown>
  Flash Player: 10.0.32

What steps will reproduce the problem?

Install chrome build 4.0.222.5 
check the menu.


What is the expected output? 

Chrome 
OR
Google Chrome 

What do you see instead?
Google Chrome Helper 

 
Picture 4.png
23.8 KB View Download

Comment 1 by krisr@chromium.org, Oct 14 2009

Labels: ReleaseBlock-Beta
Mark - I'm guessing a bundling change issue?

Comment 3 by mark@chromium.org, Oct 14 2009

Status: Assigned
will look

Comment 4 by mark@chromium.org, Oct 14 2009

Seems like the wrong strings made it into the InfoPlist.strings files.  I can see this in my 
local build too.  It's the sort of thing that I'd expect from not running grit at the right 
time, or running it at the wrong time.  I'm clobbering to see if I can reproduce.

Comment 5 by mark@chromium.org, Oct 14 2009

I see this in a clean build too.
does it show in a clean chromium build?  if not, it sounds like the chromium_strings 
and google_chrome_strings are out of sync.

Comment 7 by mark@chromium.org, Oct 14 2009

Labels: -Pri-2 -ReleaseBlock-Beta Pri-1 ReleaseBlock-Dev
Aha.

I think r28696 broke this.  It added a message to chromium_strings.grd but not 
google_chrome-strings.grd.

r28696 was codereview 271052 and 194108.

I'm moving this to ReleaseBlock-Dev.  I'm not comfortable doing a release where the 
strings file is out of sync with reality.  Jon, I think we'll really want a respin with the 
fix for this (which I'll put out in a sec).

Comment 8 by mark@chromium.org, Oct 14 2009

Status: Started
http://codereview.chromium.org/277004
Jon -

To be clear, this broke strings for *all* platforms, not just Mac.

I believe our *StringF calls bounce through a vector so we won't actually pull trash of 
the stack because of this.

Comment 10 by mark@chromium.org, Oct 14 2009

Status: Fixed
r28980 and like TVL said, I recommend a respin on all platforms to avoid problems with 
the strings being out of sync.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28980 

------------------------------------------------------------------------
r28980 | mark@chromium.org | 2009-10-14 10:48:28 -0700 (Wed, 14 Oct 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chromium_strings.grd?r1=28980&r2=28979
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=28980&r2=28979

Move IDS_NOTIFICATION_PERMISSIONS to generated_resources.grd.  This string
never belonged in chromium_strings.grd because it's not branding-dependent.
Placing it in chromium_strings.grd but not google_chrome_strings.grd caused
the two strings files to become out of sync, which is actually really really
bad.

BUG= 24776 
TEST=Application name shown in Mac menu bar should be Chrome, not
     Google Chrome Helper or anything else
Review URL: http://codereview.chromium.org/277004
------------------------------------------------------------------------

 Issue 24835  has been merged into this issue.

Comment 13 by krisr@chromium.org, Oct 15 2009

 Issue 24914  has been merged into this issue.

Comment 14 by Deleted ...@, Oct 15 2009

I am also having this issue, just helping for input.

Comment 15 by paul@chromium.org, Oct 15 2009

 Issue 24932  has been merged into this issue.
 Issue 24990  has been merged into this issue.
 Issue 25112  has been merged into this issue.

Comment 18 by mark@chromium.org, Oct 18 2009

 Issue 25143  has been merged into this issue.
 Issue 25194  has been merged into this issue.

Comment 20 by krisr@chromium.org, Oct 19 2009

 Issue 25197  has been merged into this issue.

Comment 21 by krisr@chromium.org, Oct 19 2009

Status: Verified
4.0.223.4

Comment 22 by mark@chromium.org, Oct 20 2009

 Issue 25268  has been merged into this issue.
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Sign in to add a comment