New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 247418 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 247415
issue 247417

Blocking:
issue 239046



Sign in to add a comment

Remove full text indexing

Project Member Reported by brettw@chromium.org, Jun 6 2013

Issue description

Remove the full text indexing feature from Chrome history.

The giant index files are causing storage problems, the overhead for indexing and searching is very high, the feature is rarely used, and it just doesn't work well. For me it often fails to find obvious recent matches.

We suspect that the overhead of this feature doesn't justify the current benefit and we should just remove it.

In M29 we'll probably disable the autocomplete results of the full text search (the contents provider) and see how that goes. This is  issue 247415 .

We need to provide an alternative implementation for searching from the history page which is tracked by  issue 247417 . This will likely be an improvement over the current situation where sometimes search doesn't find an obvious title match you're looking at on the history page.

 
Blocking: chromium:239046
Owner: rmcilroy@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 2013

------------------------------------------------------------------------
r212459 | rmcilroy@chromium.org | 2013-07-18T22:46:07.721017Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/url_history_provider_test.db.txt?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_service.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database_unittest.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_service.h?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend_unittest.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database.h?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_types.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_database.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend.h?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_types.h?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.h?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests_unit.gypi?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/perf/generate_profile.cc?r1=212459&r2=212458&pathrev=212459
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database_manager_unittest.cc?r1=212459&r2=212458&pathrev=212459
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database_manager.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/perf/generate_profile.h?r1=212459&r2=212458&pathrev=212459
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database_manager.h?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/history_quick_provider_unittest.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend_unittest.cc?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.cc?r1=212459&r2=212458&pathrev=212459
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database.cc?r1=212459&r2=212458&pathrev=212459
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database.h?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.h?r1=212459&r2=212458&pathrev=212459
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=212459&r2=212458&pathrev=212459

Remove TextDatabase from the history service.

The full text indexing feature is no longer used by anything.
 - Remove the TextDatabase, TextDatabaseManager and related files.
 - Remove is_indexed field from VisitRow objects.
 - Modify ExpireHistoryBackend and HistoryBackend to no longer call TextDatabase
 - Have HistoryBackend delete the "History Index *" files from the users profile
 - Remove ChromeViewHostMsg_PageContents IPC message since the browser process
   no longer requires to have the page contents of recently loaded pages.

BUG= 247418 
TESTS=unit tests, manual testing and run through trybots.

Review URL: https://chromiumcodereview.appspot.com/16951015
------------------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18 2013

------------------------------------------------------------------------
r212473 | asargent@chromium.org | 2013-07-18T23:25:55.595355Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database.h?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.h?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/url_history_provider_test.db.txt?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database_unittest.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_service.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend_unittest.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_service.h?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database.h?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_database.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_types.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend.h?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_types.h?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.h?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests_unit.gypi?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=212473&r2=212472&pathrev=212473
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database_manager_unittest.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/perf/generate_profile.cc?r1=212473&r2=212472&pathrev=212473
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database_manager.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/perf/generate_profile.h?r1=212473&r2=212472&pathrev=212473
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database_manager.h?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/history_quick_provider_unittest.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend_unittest.cc?r1=212473&r2=212472&pathrev=212473
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database.cc?r1=212473&r2=212472&pathrev=212473
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.cc?r1=212473&r2=212472&pathrev=212473

Revert 212459 "Remove TextDatabase from the history service."

This appears to have broken several history unit tests on Mac 10.6



AddNewRows
CacheSaveRestore
CursorPositionRetrieval
DeleteRows
ExpireRow
HugeResultSet
NonUniqueTermCharacterSets
ProperStringMatching
ReadVisitsFromHistory
RebuildFromHistoryIfCacheOld
Retrieval
TitleChange
TitleSearch
TypedCharacterCaching
URLPrefixMatching
WhitelistedURLs

Example output:
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%282%29/builds/40521/steps/unit_tests/logs/AddNewRows



> Remove TextDatabase from the history service.
> 
> The full text indexing feature is no longer used by anything.
>  - Remove the TextDatabase, TextDatabaseManager and related files.
>  - Remove is_indexed field from VisitRow objects.
>  - Modify ExpireHistoryBackend and HistoryBackend to no longer call TextDatabase
>  - Have HistoryBackend delete the "History Index *" files from the users profile
>  - Remove ChromeViewHostMsg_PageContents IPC message since the browser process
>    no longer requires to have the page contents of recently loaded pages.
> 
> BUG= 247418 
> TESTS=unit tests, manual testing and run through trybots.
> 
> Review URL: https://chromiumcodereview.appspot.com/16951015

TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/19637009
------------------------------------------------------------------------
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 24 2013

------------------------------------------------------------------------
r213442 | rmcilroy@chromium.org | 2013-07-24T16:13:18.697865Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database_manager_unittest.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/perf/generate_profile.cc?r1=213442&r2=213441&pathrev=213442
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database_manager.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/perf/generate_profile.h?r1=213442&r2=213441&pathrev=213442
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database_manager.h?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/history_quick_provider_unittest.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend_unittest.cc?r1=213442&r2=213441&pathrev=213442
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.cc?r1=213442&r2=213441&pathrev=213442
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/text_database.h?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.h?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/url_history_provider_test.db.txt?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database_unittest.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_service.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend_unittest.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_service.h?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database.h?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_database.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_types.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/expire_history_backend.h?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_types.h?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_tab_helper.h?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests_unit.gypi?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=213442&r2=213441&pathrev=213442
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc?r1=213442&r2=213441&pathrev=213442

Remove TextDatabase from the history service.

The full text indexing feature is no longer used by anything.
 - Remove the TextDatabase, TextDatabaseManager and related files.
 - Remove is_indexed field from VisitRow objects.
 - Modify ExpireHistoryBackend and HistoryBackend to no longer call TextDatabase
 - Have HistoryBackend delete the "History Index *" files from the users profile
 - Remove ChromeViewHostMsg_PageContents IPC message since the browser process
   no longer requires to have the page contents of recently loaded pages.

BUG= 247418 
TESTS=unit tests, manual testing and run through trybots.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212459

Review URL: https://chromiumcodereview.appspot.com/16951015
------------------------------------------------------------------------
Status: Fixed

Sign in to add a comment