| Add system spellchecker support for Linux | ||||||||||||||
| Reported by jhaygoo...@gmail.com, Oct 10 2009 | Back to list | |||||||||||||
The major current Linux distributions (Ubuntu[1], Fedora[2], openSUSE[3]) all have the concept of a "system" spellchecker, via hunspell and normally implemented by using the enchant library I attached a patch which adds support for enchant (though it could use some minor reworking) (1) It adds enchant to the linux buildsystem and depends on it from browser when OS == Linux (2) It adds a TearDown() method to SpellCheckerPlatform and calls it from ~SpellChecker. Mac and Windows have it stubbed out (3) It implements spellchecker_linux.cc in terms of enchant (4) it disables -fno-exceptions since enchant++.h requires exceptions to be enabled -- an alternative is to include a modified copy of the c++ interface in chromium and disable use of exceptions there (its just a wrapper around the C enchant.h anyway) References: [1] https://wiki.ubuntu.com/ConsolidateSpellingLibs [2] http://fedoraproject.org/wiki/Releases/FeatureDictionary [3] https://features.opensuse.org/305688 (among other fate requests)
Comment 1
by
est...@chromium.org,
Oct 12 2009
,
Oct 12 2009
Thanks for the patch! It looks like it failed to upload. We should do this, especially if we have a patch for it. I think we should just use the C interface to enchant since we want -fno-exceptions.
,
Oct 12 2009
I'll reupload tonight when I get home.. including a port to the C interface of enchant.
,
Oct 13 2009
Moving this out of mstone-4 and into mstone-5 after talking to the Linux team.
,
Oct 22 2009
Ping. Retry on the failed upload of the patch?
,
Oct 22 2009
,
Dec 18 2009
Area-UI-Features label replaces Area-BrowserUI label
,
Jan 8 2010
,
Jan 9 2010
Still no patch...
,
Feb 17 2010
,
Apr 6 2010
,
Jul 13 2010
,
Jan 26 2011
We're trying to deprecate HelpWanted, so I'm bulk-removing it from some bugs.
,
Jul 20 2011
https://bugzilla.mozilla.org/show_bug.cgi?id=422399 is the equivalent Mozilla bug. When I looked into this before, we had made a significant modification to hunspell to reduce memory consumption that upstream wasn't interested in.
,
Jun 11 2012
,
Jun 11 2012
(Un-ccing myself from bugs.)
,
Jul 31 2012
,
Mar 10 2013
,
Jun 28 2016
This issue has been available for more than 365 days, and should be re-evaluated. Hotlist-Recharge-Cold label is added for tracking. Please re-triage this issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||||||
| ► Sign in to add a comment | ||||||||||||||
