New issue
Advanced search Search tips
Starred by 16 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2014
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 8606



Sign in to add a comment
link

Issue 244605: Fix bookmarks DND tests on Win64 builds

Reported by jsc...@chromium.org, May 28 2013 Project Member

Issue description

The following tests are currently failing on Win64 builds:

BookmarkBarViewTest5.DND
BookmarkBarViewTest7.DNDToDifferentMenu
BookmarkBarViewTest8.DNDBackToOriginatingMenu
 

Comment 1 by jsc...@chromium.org, May 28 2013

Blocking: chromium:8606

Comment 2 by jsc...@chromium.org, May 28 2013

Summary: Fix bookmarks DND tests on Win64 builds (was: Fix DND tests on Win64 builds)

Comment 3 by jsc...@chromium.org, May 28 2013

Should mention that these all pass locally, but they're failing on the bots for some unknown reason.

Comment 4 by bugdroid1@chromium.org, May 29 2013

Project Member
------------------------------------------------------------------------
r202741 | jschuh@chromium.org | 2013-05-29T01:58:08.325315Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc?r1=202741&r2=202740&pathrev=202741

Disable DND tests failing on Win64 build

BUG= 244605 
R=sky@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15827010
------------------------------------------------------------------------

Comment 5 by wfh@chromium.org, Feb 12 2014

Labels: Cr-Tests-Disabled Proj-Win64

Comment 6 by bugdroid1@chromium.org, Apr 15 2014

Project Member
------------------------------------------------------------------
r263817 | jschuh@chromium.org | 2014-04-15T12:50:16.781678Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc?r1=263817&r2=263816&pathrev=263817

Re-enable DND tests failing on Win64 build

Appears to have been an MSVS 2010 codegen issue.

BUG= 244605 
R=sky@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/237873002
-----------------------------------------------------------------

Comment 7 by jsc...@chromium.org, Apr 15 2014

Owner: jsc...@chromium.org
Status: Fixed

Comment 8 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment