Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 243345 [OWP Launch] DOM Promises
Starred by 39 users Project Member Reported by tyoshino@chromium.org, May 23 2013 Back to list
Status: Fixed
Owner:
Closed: Oct 2013
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Status: ----
Launch-Test: ----
Launch-UI: ----

Blocked on:
issue 295420

Blocking:
issue 53213
issue 163795



Sign in to add a comment
Change description:
Adding DOM Futures API which provide JavaScript a convenient way to get access to the result of an operation that may have already occurred or may happen in the future.

Spec: http://dom.spec.whatwg.org/#futures

Changes to API surface:
- new constructors Future and FutureResolver

Public standards discussion: public-webapps@w3.org

Support in other browsers: current (expected)
Internet Explorer: No (unknown)
Firefox:  No (unknown)
Safari: No (unknown)
Opera: No (unknown)

 
Comment 1 by tyoshino@google.com, May 23 2013
Prototype CL (WIP)
https://codereview.chromium.org/15786003/
Blocking: chromium:163795
Blocking: chromium:245025
Web MIDI will introduce MIDIAccessPromise tentatively.
from https://codereview.chromium.org/15995010/

FYI, slightlyoff1 comment #12:

We clobbered .done() based on feedback at the last TC39 meeting where we
renamed them to Promise. Here's the updated IDL:

    https://github.com/slightlyoff/Futures/blob/master/Promise.idl
Cc: tyoshino@chromium.org
Owner: yhirano@chromium.org
Now yhirano is working on this feature.

https://codereview.chromium.org/17035004/
https://codereview.chromium.org/16838012/
Project Member Comment 6 by bugdroid1@chromium.org, Jun 24 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=152943

------------------------------------------------------------------------
r152943 | yhirano@chromium.org | 2013-06-24T10:40:08.654756Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp?r1=152943&r2=152942&pathrev=152943
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/PromiseResolver.idl?r1=152943&r2=152942&pathrev=152943
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-constructors-listing-expected.txt?r1=152943&r2=152942&pathrev=152943
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/bindings.gypi?r1=152943&r2=152942&pathrev=152943
   A http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.h?r1=152943&r2=152942&pathrev=152943
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-init-expected.txt?r1=152943&r2=152942&pathrev=152943
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/RuntimeEnabledFeatures.in?r1=152943&r2=152942&pathrev=152943
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=152943&r2=152942&pathrev=152943
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-init.html?r1=152943&r2=152942&pathrev=152943
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Promise.h?r1=152943&r2=152942&pathrev=152943
   A http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.cpp?r1=152943&r2=152942&pathrev=152943
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Promise.idl?r1=152943&r2=152942&pathrev=152943
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/PromiseResolver.h?r1=152943&r2=152942&pathrev=152943

Introduce Promises.

We would like to introduce DOM/Promises[1].
Unlike ordinary DOM objects, the internal state is held as a JavaScript object to avoid leaks.
To achieve this, WebCore::Promise class is empty (it is added to make the IDL processor happy) and all methods are marked as CUSTOM.
Perhaps we will make the IDL processor support this style in a future CL.

As a first step, This CL contains Promise constructor only.
The remaining part will be implemented in another CL.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9q5kP0eMQc8 
BUG= 243345 
R=abarth@chromium.org
TESTS=fast/js/Promise-init.html

Review URL: https://chromiumcodereview.appspot.com/17505004
------------------------------------------------------------------------
Project Member Comment 7 by bugdroid1@chromium.org, Jun 28 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=153199

------------------------------------------------------------------------
r153199 | yhirano@chromium.org | 2013-06-28T04:23:32.472356Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.cpp?r1=153199&r2=153198&pathrev=153199
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp?r1=153199&r2=153198&pathrev=153199
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/PromiseResolver.idl?r1=153199&r2=153198&pathrev=153199
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.h?r1=153199&r2=153198&pathrev=153199

Implement PromiseResolver.prototype.{fulfill, reject}

We are implementing DOM/Promises. 
The first CL is https://src.chromium.org/viewvc/blink?revision=152943&view=revision . 
This CL implements PromiseResolver.prototype.fulfill and PromiseResolver.prototype.reject.
Again, all methods are marked as Custom and there are many boilerplate. we will fix them in a future CL. 
There are no tests. We will add tests in a future.

BUG= 243345 
R=abarth

Review URL: https://chromiumcodereview.appspot.com/17993004
------------------------------------------------------------------------
Project Member Comment 8 by bugdroid1@chromium.org, Jun 28 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=153215

------------------------------------------------------------------------
r153215 | yhirano@chromium.org | 2013-06-28T07:21:37.581403Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp?r1=153215&r2=153214&pathrev=153215
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/PromiseResolver.idl?r1=153215&r2=153214&pathrev=153215
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.h?r1=153215&r2=153214&pathrev=153215
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.cpp?r1=153215&r2=153214&pathrev=153215

Implement PromiseResolver.prototype.resolve.

We are implementing DOM/Promises. 
This CL implements PromiseResolver.prototype.resolve. 
Again, all methods are marked as Custom and there are many boilerplate. we will fix them in a future CL. 
There are no tests. We will add tests in a future. 

R=abarth, haraken
BUG= 243345 

Review URL: https://chromiumcodereview.appspot.com/18119008
------------------------------------------------------------------------
Project Member Comment 9 by bugdroid1@chromium.org, Jul 4 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=153560

------------------------------------------------------------------------
r153560 | yhirano@chromium.org | 2013-07-04T07:02:37.099574Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-simple.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-resolve-with-then-exception-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-catch-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-fulfill.html?r1=153560&r2=153559&pathrev=153560
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Promise.idl?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-then-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-resolve-with-then-reject-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-exception-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-then-without-callbacks.html?r1=153560&r2=153559&pathrev=153560
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-init-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-resolve-with-then-exception.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-catch.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-reject-expected.txt?r1=153560&r2=153559&pathrev=153560
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.h?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-resolve-with-then-fulfill-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-resolve-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-chain-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-exception.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-resolve-with-then-reject.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-simple-fulfill-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-then.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-already-fulfilled-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-simple-fulfill-inside-callback-expected.txt?r1=153560&r2=153559&pathrev=153560
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-init.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-simple-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-fulfill-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-reject.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-resolve.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-resolve-with-then-fulfill.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-chain.html?r1=153560&r2=153559&pathrev=153560
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.cpp?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-simple-fulfill.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-already-fulfilled.html?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-then-without-callbacks-expected.txt?r1=153560&r2=153559&pathrev=153560
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-simple-fulfill-inside-callback.html?r1=153560&r2=153559&pathrev=153560

Implement Promise.prototype.then and Promise.prototype.catch

We are implementing DOM/Promises.
This CL implements Promise.prototype.then and Promise.prototype.catch.
All methods are marked as Custom and there are many boilerplate. we will fix them in a future CL.

R=abarth, haraken
BUG= 243345 

Review URL: https://chromiumcodereview.appspot.com/18113004
------------------------------------------------------------------------
Project Member Comment 10 by bugdroid1@chromium.org, Jul 4 2013
------------------------------------------------------------------------
r210154 | yhirano@chromium.org | 2013-07-04T08:40:04.042100Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/webkit_support.cc?r1=210154&r2=210153&pathrev=210154

Enable runtime flags in webkit_unit_tests.

Enable {stable, experimental, test only} runtime enabled features in webkit_unit_tests.

BUG= 243345 
R=tkent

Review URL: https://chromiumcodereview.appspot.com/18325026
------------------------------------------------------------------------
Project Member Comment 11 by bugdroid1@chromium.org, Jul 8 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=153703

------------------------------------------------------------------------
r153703 | yhirano@chromium.org | 2013-07-08T20:34:46.059775Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-some-expected.txt?r1=153703&r2=153702&pathrev=153703
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.cpp?r1=153703&r2=153702&pathrev=153703
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Promise.idl?r1=153703&r2=153702&pathrev=153703
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-any-expected.txt?r1=153703&r2=153702&pathrev=153703
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-some.html?r1=153703&r2=153702&pathrev=153703
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-every-expected.txt?r1=153703&r2=153702&pathrev=153703
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.h?r1=153703&r2=153702&pathrev=153703
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-any.html?r1=153703&r2=153702&pathrev=153703
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-every.html?r1=153703&r2=153702&pathrev=153703

Implement Promise.any, Promise.every and Promise.some.

We are implementing DOM/promises.
We implement Promise.any, Promise.every and Promise.some in this CL.

BUG= 243345 
R=abarth

Review URL: https://chromiumcodereview.appspot.com/18291005
------------------------------------------------------------------------
Blocking: chromium:53213
Project Member Comment 13 by bugdroid1@chromium.org, Jul 9 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=153745

------------------------------------------------------------------------
r153745 | yhirano@chromium.org | 2013-07-09T05:29:06.600490Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/WebKit/chromium/WebKitUnitTests.gyp?r1=153745&r2=153744&pathrev=153745
   A http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/ScriptPromiseResolver.cpp?r1=153745&r2=153744&pathrev=153745
   A http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/ScriptPromiseResolverTest.cpp?r1=153745&r2=153744&pathrev=153745
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/bindings.gypi?r1=153745&r2=153744&pathrev=153745
   A http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/ScriptPromiseResolver.h?r1=153745&r2=153744&pathrev=153745

Introduce ScriptPromiseResolver.

We are implementing DOM/promises[1].
This CL introduces ScriptPromiseResolver which enables C++ code to generate
a Promise and a PromiseResolver and to fullfill / reject the PromiseResolver.

[1]: http://dom.spec.whatwg.org/#promises 

R=abarth
BUG= 243345 

Review URL: https://chromiumcodereview.appspot.com/18469002
------------------------------------------------------------------------
Project Member Comment 14 by bugdroid1@chromium.org, Jul 9 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=153747

------------------------------------------------------------------------
r153747 | yhirano@chromium.org | 2013-07-09T05:38:51.270369Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-reject-expected.txt?r1=153747&r2=153746&pathrev=153747
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-fulfill-expected.txt?r1=153747&r2=153746&pathrev=153747
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-resolve-expected.txt?r1=153747&r2=153746&pathrev=153747
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-reject.html?r1=153747&r2=153746&pathrev=153747
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-fulfill.html?r1=153747&r2=153746&pathrev=153747
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-static-resolve.html?r1=153747&r2=153746&pathrev=153747
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.cpp?r1=153747&r2=153746&pathrev=153747
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Promise.idl?r1=153747&r2=153746&pathrev=153747

Implement Promise.fulfill, Promise.resolve and Promise.reject.

We are implementing DOM/promises[1].
We implement Promise.fulfill, Promise.resolve and Promise.reject in this CL.

[1] http://dom.spec.whatwg.org/#promises

BUG= 243345 
R=abarth

Review URL: https://chromiumcodereview.appspot.com/18648011
------------------------------------------------------------------------
Project Member Comment 15 by bugdroid1@chromium.org, Jul 9 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=153798

------------------------------------------------------------------------
r153798 | yhirano@chromium.org | 2013-07-09T18:54:07.629574Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-already-resolved-expected.txt?r1=153798&r2=153797&pathrev=153798
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-already-rejected-expected.txt?r1=153798&r2=153797&pathrev=153798
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/RuntimeEnabledFeatures.in?r1=153798&r2=153797&pathrev=153798
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-resolve-chain.html?r1=153798&r2=153797&pathrev=153798
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-already-resolved.html?r1=153798&r2=153797&pathrev=153798
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-already-rejected.html?r1=153798&r2=153797&pathrev=153798
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.cpp?r1=153798&r2=153797&pathrev=153798
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-already-fulfilled.html?r1=153798&r2=153797&pathrev=153798
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/Promise-resolve-chain-expected.txt?r1=153798&r2=153797&pathrev=153798
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.h?r1=153798&r2=153797&pathrev=153798

Refactoring on DOM/Promises

We are implementing DOM/promises[1].
This CL adds some layout tests and does some refactoring.
We change the status of "Promise" runtime enabled flag from test to experimental.

[1]: http://dom.spec.whatwg.org/#promises

R=abarth
BUG= 243345 

Review URL: https://chromiumcodereview.appspot.com/18878002
------------------------------------------------------------------------
Updated http://www.chromestatus.com/features
- Owner -> yhirano
- Status -> experimental
Project Member Comment 17 by bugdroid1@chromium.org, Jul 10 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=153847

------------------------------------------------------------------------
r153847 | yhirano@chromium.org | 2013-07-10T04:49:36.037248Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/V8Binding.h?r1=153847&r2=153846&pathrev=153847
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8PromiseCustom.cpp?r1=153847&r2=153846&pathrev=153847

Move createClosure from V8PromiseCustom.cpp to V8Binding.h

Make the file local function public in WebCore namespace.
This is a refactoring CL.

BUG= 243345 
R=abarth

Review URL: https://chromiumcodereview.appspot.com/18452009
------------------------------------------------------------------------
Project Member Comment 18 by bugdroid1@chromium.org, Jul 10 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=153857

------------------------------------------------------------------------
r153857 | yhirano@chromium.org | 2013-07-10T06:02:55.467225Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Promise.idl?r1=153857&r2=153856&pathrev=153857

Fix types in Promise IDL.

This CL does not change any behavior because all methods are marked as [Custom].

BUG= 243345 
R=abarth

Review URL: https://chromiumcodereview.appspot.com/18979002
------------------------------------------------------------------------
Blocking: -chromium:245025
Any updates here? I'm assuming this isn't still targeted to 30?
Labels: -M-30 M-31
Are we confident that this will hit M31?
Update: yhirano@ told me that there is a working implementation behind the flag. There might be some bugs still.

komoroske@: my understanding is that these OWP launch bugs are to be marked fixed by the time the feature ships. If by hit you meant "implemented" then M31 looks good, if it was "ship" I think that overall the signals are positive so M31 seems doable.

yhirano@: raise any concerns you may have regarding both finishing/fixing the implementation and shipping it in M31. Thanks.
Summary: [OWP Launch] DOM Promises (was: [OWP Launch] DOM Futures)
Renamed on the spec: DOM Futures -> DOM Promises
Blockedon: chromium:295420
Comment 27 by meh@chromium.org, Sep 30 2013
Labels: -M-31 M-32
Moving to M-32.  Please revert if this is landing in M-31.
According to http://annevankesteren.nl/2013/08/promises DOM Promises (as defined by https://github.com/slightlyoff/Promises) is being replaced by https://github.com/domenic/promises-unwrapping. Does Chrome plan on implementing the latter?
They already started working on it, see blocked on  issue 295420 .
Comment 30 Deleted
We are now implementing this.
Here's tracking issue[1] and the CL[2]. (this issue is registerd as `Blocked on`)

[1]: https://code.google.com/p/chromium/issues/detail?id=295420
[2]: https://codereview.chromium.org/24980002/
Understood. Thanks for the head's up.
Any intent to ship it?
Project Member Comment 35 by bugdroid1@chromium.org, Oct 29 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=160850

------------------------------------------------------------------------
r160850 | yhirano@chromium.org | 2013-10-29T18:55:02.256852Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/imagebitmap/ImageBitmapFactories.cpp?r1=160850&r2=160849&pathrev=160850
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/FontFaceSet.idl?r1=160850&r2=160849&pathrev=160850
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-constructors-listing-dedicated-worker-expected.txt?r1=160850&r2=160849&pathrev=160850
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-constructors-listing-shared-worker-expected.txt?r1=160850&r2=160849&pathrev=160850
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Promise.idl?r1=160850&r2=160849&pathrev=160850
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt?r1=160850&r2=160849&pathrev=160850
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/ScriptPromiseResolver.cpp?r1=160850&r2=160849&pathrev=160850
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=160850&r2=160849&pathrev=160850

Ship DOM/Promises

Remove "Promise" runtime enabled flag.
Intent-to-Ship thread:
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0Fs5P6Xgg9g

BUG= 243345 
R=abarth

Review URL: https://codereview.chromium.org/42883002
------------------------------------------------------------------------
It is enabled by default now on trunk.

Status: Fixed
Sign in to add a comment