New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 242216 link

Starred by 15 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on: View detail
issue 860402
issue 862064



Sign in to add a comment

[meta] Remove superfluous includes

Project Member Reported by pdr@chromium.org, May 20 2013

Issue description

We have many unnecessary includes in our codebase and removing these can both cleanup our code and improve compile times.

The first two iterations of this have been:
https://codereview.chromium.org/15427003/
https://codereview.chromium.org/15447002/
 
Just to clarify: the intent is to remove *unused* headers, and not necessarily headers which are (indirectly) included multiple times - is this correct?

Comment 2 by pdr@chromium.org, May 20 2013

Cc: alph@chromium.org steveblock@chromium.org eseidel@chromium.org
@fmalita, the goal would be to pare down our includes as much as possible. On one of the bugs, Alph pointed out "Most modern compilers support include guard optimization, so they won't even read a header file with a guard past its very first include occurrence" so I'm not sure if we should continue with this.

we need data.
Cc: fmalita@chromium.org
@pdr

Right, the goal of reducing our includes as much as possible is arguable. But I don't think anyone would object to removing includes which are truly unused - maybe that's a better starting point?

Comment 4 by jam...@chromium.org, May 20 2013

I think we should stick to something like https://code.google.com/p/chromium/wiki/IncludeWhatYouUse (in spirit anyway, not sure if it's ready yet for deploying on blink) - i.e. do have #includes for everything that is used in a given source file, but no more.

Comment 5 by pdr@chromium.org, May 20 2013

@jamesr, iwyu is definitely the way to go if it works. I failed to get it to work, but I can give it another shot.

Comment 6 by pdr@chromium.org, May 21 2013

Cc: thakis@chromium.org
Here are the results of the patch from 15447002 plus some more removals from core/rendering for debug content_shell on linux (2 runs each):
With patch: 4m46.909s, 4m48.520s
Without patch: 4m50.560s, 4m52.970s

That's 4s total. Unless we can eek out bigger wins, I don't think that is worth the brittleness that this would add to our codebase.

Pinging Niko for his expert opinion on this.

Comment 7 by thakis@chromium.org, May 21 2013

My expert opinion is that my name is spelled with 'c' :-)

comment #2 is right that removing redundant includes doesn't help (as in: If a file has `#include "a.h" #include "b.h"` and a.h already includes b.h, then removing the second include line won't buy compile time). What does help is removing includes that aren't used and aren't included through some other header either. What helps too is to predeclare classes instead of including their whole definition when possible.

(This helps most if it's done in a header file that's included in thousands of translation units. If a header that's included in only two places is made smaller, it doesn't help with full build times all that much of course.)

I think it's generally considered best practice to follow an include-what-you-use approach: Every header should predeclare and include the files it needs, no matter if they've been included transitively already. For example https://codereview.chromium.org/15427003/diff/2001/Source/core/rendering/svg/RenderSVGEllipse.h?column_width=80 is wrong since that header uses SVGStyledTransformableElement, so it should have an include for it. (Maybe it could have a forward-declaration instead though, then the include can be removed.)

https://code.google.com/p/include-what-you-use/wiki/WhatIsAUse is an ok overview, and the other pages on that wiki are a good read as well. Sadly, the iwyu tool itself isn't ready for prime time (I tried running it on blink 2 weeks ago.) Maybe it can be made to work, but it would require some effort.

Comment 8 by timloh@google.com, May 21 2013

I'm working off a metric that roughly corresponds to "source files read to compile blink":

~/Coding/Chromium/src/out/Release/obj/third_party/WebKit/Source$ find -name "*.o.d"|xargs cat|sed '/:/d'|wc -l

For example, before and after my patch (15447002) we get the numbers 529424 and 515835, so I would only expect a couple of percent difference in compile time. Previous playing around with iwyu (python postprocessing and whatnot) suggests we might be able to get this number down by a couple hundred thousand -- this would be by working on the includes in the .h files.

I have no intention on removing includes which are redundant (due to transitivity). An earlier experiment with about 4000 removals had no compile time difference on a linux machine (as I expected).

Comment 9 by thakis@chromium.org, May 21 2013

timloh: That sounds good. Answering esprehn's question on https://codereview.chromium.org/15447002/ is probably your next step?
Cc: esprehn@chromium.org
esprehn: My patch on https://codereview.chromium.org/15447002/ is generated from iwyu's suggestions on what to remove. Since iwyu suggests you explicitly include/forward declare everything you explicitly use, I assume that it's suggestions for removals are includes which are unused. For that patch, I ignored the changes on the files which didn't compile after using iwyu's suggestions (about 1/3rd of the files).

Comment 11 by esprehn@google.com, May 21 2013

This sounds great then, lets do it! IWYU is the future, it'll make things so much less brittle.
Project Member

Comment 12 by bugdroid1@chromium.org, May 21 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=150748

------------------------------------------------------------------------
r150748 | timloh@chromium.org | 2013-05-21T06:42:42.427724Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/ComposedShadowTreeWalker.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ChildListMutationScope.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSLineBoxContainValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Notation.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Range.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/TransformBuilder.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSParserValues.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/DeprecatedStyleBuilder.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/ElementRuleCollector.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/KeyboardEvent.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSDefaultStyleSheets.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSSegmentedFontFace.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ViewportArguments.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/SelectorQuery.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/WebKitCSSKeyframesRule.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSBasicShapes.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/TreeScopeAdopter.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSImageGeneratorValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Attr.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleRule.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/SelectorChecker.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/UIEvent.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleInvalidationAnalysis.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSBorderImageSliceValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Event.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Touch.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMImplementation.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/VisitedLinkState.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ContainerNode.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventDispatcher.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventTarget.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFontSelector.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSMediaRule.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/ScopedStyleResolver.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/WebKitCSSMatrix.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DecodedDataDocumentParser.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSCursorImageValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryEvaluator.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/default/chromium/PlatformMessagePortChannelChromium.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ActiveDOMObject.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/MutationObserverRegistration.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/MutationObserverInterestGroup.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/SVGCSSStyleSelector.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ScriptableDocumentParser.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ClassNodeList.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSSupportsRule.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/StyleElement.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSGradientValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSParser.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryListListener.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/ElementShadow.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventListenerMap.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventDispatchMediator.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/FontFeatureValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSComputedStyleDeclaration.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Element.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSCanvasValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StylePropertySet.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/WebKitCSSShaderValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleSheetList.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/SVGCSSParser.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Clipboard.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DocumentFragment.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/UserActionElementSet.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DocumentStyleSheetCollection.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/WheelEvent.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSProperty.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFontFace.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSCalculationValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/CustomElementRegistry.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ProcessingInstruction.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ContextDestructionObserver.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleSheetContents.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/FocusEvent.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryMatcher.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSImportRule.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DocumentEventQueue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventContext.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPageRule.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValuePool.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ClientRectList.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NamedNodeMap.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSCrossfadeValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFontFaceSource.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/TreeScope.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NodeFilter.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleRuleImport.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSImageValue.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleSheet.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ScriptElement.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NameNodeList.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaList.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/PageRuleCollector.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Text.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSRuleList.cpp?r1=150748&r2=150747&pathrev=150748
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/ContentSelectorQuery.cpp?r1=150748&r2=150747&pathrev=150748

Remove some unused includes from core/css and core/dom

Splitting up codereview.chromium.org/15447002 into smaller patches.

BUG=242216

Review URL: https://chromiumcodereview.appspot.com/15387004
------------------------------------------------------------------------
Project Member

Comment 13 by bugdroid1@chromium.org, May 22 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=150886

------------------------------------------------------------------------
r150886 | timloh@chromium.org | 2013-05-22T12:06:18.055646Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGTextQuery.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderLazyBlock.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderBoxModelObject.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/RenderSVGViewportContainer.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/exclusions/ExclusionShapeInfo.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderIFrame.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderMediaControlsChromium.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderSearchField.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderLayer.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/LayoutState.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderThemeChromiumSkia.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/SVGRenderStyle.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/SVGRenderStyleDefs.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderMultiColumnBlock.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderScrollbar.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderListBox.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/FilterEffectRenderer.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGTextMetrics.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderImageResource.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/BidiRun.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/StyleFilterData.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGRenderingContext.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/RenderSVGRoot.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGTextChunkBuilder.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderMediaControls.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderProgress.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderObject.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/StyleMarqueeData.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGRootInlineBox.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderButton.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderTableSection.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/InlineFlowBox.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderEmbeddedObject.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderImage.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderWidget.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/HitTestResult.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderLayerModelObject.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/CounterNode.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/InlineTextBox.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/EllipsisBox.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderTextControlSingleLine.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/ImageQualityController.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderHTMLCanvas.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderMenuList.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFullScreen.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/ContentData.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVideo.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderRubyRun.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFrameSet.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGRenderTreeAsText.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/RenderSVGResourceMasker.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderView.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/StyleRareNonInheritedData.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderMeter.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderRubyBase.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGResourcesCache.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/RenderSVGTextPath.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderCombineText.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderSlider.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/RenderSVGResourceGradient.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderGrid.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/exclusions/ExclusionShape.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderBox.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFrame.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderBlock.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderListItem.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGRenderSupport.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGInlineFlowBox.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderBlockLineLayout.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/RenderStyle.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/FlowThreadController.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderBR.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/RenderSVGResourcePattern.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderTextControlMultiLine.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/RenderSVGResourceMarker.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGInlineTextBox.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderThemeChromiumDefault.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderMediaControlElements.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/RenderSVGShape.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderReplaced.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderRuby.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderRegion.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderText.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderTextControl.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFileUploadControl.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/InlineBox.cpp?r1=150886&r2=150885&pathrev=150886
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderInputSpeech.cpp?r1=150886&r2=150885&pathrev=150886

Remove unused includes from core/rendering .cpp files

Splitting up codereview.chromium.org/15447002 into smaller patches.

BUG=242216

Review URL: https://chromiumcodereview.appspot.com/15579008
------------------------------------------------------------------------
Project Member

Comment 14 by bugdroid1@chromium.org, May 23 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=150957

------------------------------------------------------------------------
r150957 | timloh@chromium.org | 2013-05-23T04:33:39.537276Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLCollection.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLKeygenElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFrameElementBase.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDetailsElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/SearchInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLContextGroup.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLElementStack.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/MediaFragmentURIParser.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLObject.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLProgressElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLProgram.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasGradient.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MediaControlElementTypes.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLRenderbuffer.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLVideoElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLObjectElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFontElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCueGeneric.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableSectionElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLDocumentParser.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/FormAssociatedElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrack.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/MediaDocument.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOptGroupElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLViewSourceDocument.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLFramebuffer.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ImageDocument.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MeterShadowElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDivElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLTreeBuilder.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOListElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFrameElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/TextDocumentParser.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSummaryElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/PluginDocument.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMarqueeElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImageLoader.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ValidationMessage.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLStyleElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/DateTimeFieldElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLHeadElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLBRElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLShader.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/TelephoneInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOptionElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLHRElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/TextFieldInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTextAreaElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSelectElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLRenderingContext.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLAppletElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPreElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLDebugRendererInfo.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormControlsCollection.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MediaControls.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/InbandTextTrack.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/WebVTTParser.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLTexture.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/XSSAuditorDelegate.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/DateInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOutputElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/InputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ClassList.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/FileInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLIFrameElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormControlElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLIElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDocument.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDataListElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFrameOwnerElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLParagraphElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/CSSPreloadScanner.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/CompactHTMLToken.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackList.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMeterElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLabelElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/RangeInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ime/InputMethodContext.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/RadioInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLNameCollection.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/SliderThumbElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableColElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/URLInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMetaElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/BaseButtonInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLViewSourceParser.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/WebVTTElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLinkElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLBodyElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/BaseDateAndTimeInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/HTMLContentElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLUListElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/LoadableTextTrack.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLFormattingElementList.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MediaControlElements.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/DOMURL.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableCaptionElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFrameSetElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLBuffer.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLAreaElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/MonthInputType.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTextFormControlElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLButtonElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLCanvasElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTemplateElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMapElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LabelableElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTablePartElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableRowElement.cpp?r1=150957&r2=150956&pathrev=150957
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLScriptRunner.cpp?r1=150957&r2=150956&pathrev=150957

Remove unused includes from core/html .cpp files

Splitting up codereview.chromium.org/15447002 into smaller patches.

BUG=242216

Review URL: https://chromiumcodereview.appspot.com/15422005
------------------------------------------------------------------------
Project Member

Comment 15 by bugdroid1@chromium.org, May 28 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=151236

------------------------------------------------------------------------
r151236 | timloh@chromium.org | 2013-05-28T10:04:40.275480Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/sql/chromium/SQLiteFileSystemChromium.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/Path.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/GraphicsContext3D.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/DeferredImageDecoder.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/Gradient.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/LazyDecodingPixelRef.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/SkiaUtils.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/audio/HRTFKernel.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/Font.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/DragData.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/filters/custom/CustomFilterCompiledProgram.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/transforms/TranslateTransformOperation.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/chromium/SSLKeyGeneratorChromium.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/image-encoders/skia/WEBPImageEncoder.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/SimpleFontDataSkia.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/ScrollAnimatorNone.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/text/TextEncodingDetectorICU.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/audio/HRTFElevation.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/harfbuzz/FontHarfBuzz.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/AnimationTranslationUtil.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/ImageDecodingStore.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/ImageSkia.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/Image.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/ThreadGlobalData.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/GraphicsLayerChromium.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/audio/Reverb.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/chromium/ClipboardChromium.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/chromium/support/WebHTTPLoadInfo.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/NativeImageSkia.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/ScrollbarThemeComposite.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/skia/FontCacheSkia.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/network/ResourceHandle.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/GraphicsLayer.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/network/FormDataBuilder.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/MIMETypeFromURL.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/network/BlobRegistryProxy.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/ImageSource.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/audio/chromium/AudioBusChromium.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/chromium/ChromiumDataObjectItem.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/filters/FEBlend.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/GeneratorGeneratedImage.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/chromium/MIMETypeRegistryChromium.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/SimpleFontData.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/filters/FilterEffect.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/ScrollableArea.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/chromium/FramelessScrollView.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/BitmapImage.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/filters/SkiaImageFilterBuilder.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/gpu/DrawingBuffer.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/Timer.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/FontFallbackList.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/Scrollbar.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/CrossThreadCopier.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/text/LocaleICU.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/network/FormData.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/ScrollView.cpp?r1=151236&r2=151235&pathrev=151236
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/platform/graphics/filters/custom/CustomFilterProgram.cpp?r1=151236&r2=151235&pathrev=151236

Remove unused includes from core/platform .cpp files

Splitting up codereview.chromium.org/15447002 into smaller patches.

BUG=242216

Review URL: https://chromiumcodereview.appspot.com/15811002
------------------------------------------------------------------------
Project Member

Comment 16 by bugdroid1@chromium.org, May 31 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=151530

------------------------------------------------------------------------
r151530 | timloh@chromium.org | 2013-05-31T08:05:05.645620Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEMergeNodeElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEComponentTransferElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFETurbulenceElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGGlyphElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTextElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGDocumentExtensions.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTransformable.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGVKernElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTests.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/ScriptCallFrame.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptCanvasModule.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorMemoryAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEImageElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorCanvasAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTransform.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/ScriptCallStack.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGURIReference.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFontFaceUriElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorIndexedDBAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGRadialGradientElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEMorphologyElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGViewElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGStyledLocatableElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTransformDistance.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/PageRuntimeAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFECompositeElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEFloodElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathUtilities.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimationElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGGlyphRefElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGMarkerElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFELightElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorInputAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGLangSpace.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPolyElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/ConsoleMessage.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTSpanElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorOverlay.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGStopElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScript.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorWorkerAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGSVGElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGCircleElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPaint.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTextPathElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/ScriptProfile.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGClipPathElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFontElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTextPositioningElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGLength.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDOMDebuggerAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGHKernElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorFileSystemAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFETileElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/TimelineRecordFactory.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGCursorElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimateElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEColorMatrixElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorLayerTreeAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDatabaseResource.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEDisplacementMapElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/WorkerInspectorController.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorFrontendHost.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorClient.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGImageElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/animation/SVGSMILElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGStyledTransformableElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEDropShadowElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFilterElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorController.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDatabaseAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDOMStorageAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGLineElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathByteStreamBuilder.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGMaskElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEConvolveMatrixElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGEllipseElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGImageLoader.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEBlendElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGColor.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEGaussianBlurElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimateTransformElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorApplicationCacheAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorResourceAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorCSSAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/animation/SMILTimeContainer.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFESpecularLightingElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGForeignObjectElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAltGlyphElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptHost.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEDiffuseLightingElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGLinearGradientElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorTimelineAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/PageConsoleAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPathElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGUseElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGRectElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorStyleSheet.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/ContentSearchUtils.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGStyleElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGFEOffsetElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDOMAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/DOMEditor.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGElementInstance.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGExternalResourcesRequired.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGScriptElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGAnimateMotionElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/DOMPatchSupport.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGPatternElement.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/PageDebuggerAgent.cpp?r1=151530&r2=151529&pathrev=151530
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGTextContentElement.cpp?r1=151530&r2=151529&pathrev=151530

Remove unused includes from core/inspector and core/svg .cpp files

Splitting up codereview.chromium.org/15447002 into smaller patches.

BUG=242216

Review URL: https://chromiumcodereview.appspot.com/15942008
------------------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 4 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=151749

------------------------------------------------------------------------
r151749 | timloh@chromium.org | 2013-06-04T14:20:43.916339Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Performance.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/AnimationController.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/SuspendableTimer.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PageSerializer.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PageGroupLoadDeferrer.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FormSubmission.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fileapi/Blob.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/EditingStyle.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentThreadableLoader.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/CSSPropertyAnimation.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/ContextMenuController.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/workers/AbstractWorker.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/MouseEventWithHitTestResults.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertTextCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/FocusController.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/chromium/EditorChromium.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/workers/DedicatedWorkerContext.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/DOMSecurityPolicy.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertLineBreakCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/SpeechInput.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PageGroup.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathPredicate.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Navigator.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/EditorCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PointerLockController.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XMLHttpRequestUpload.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/DeviceController.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/TextIterator.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/workers/WorkerScriptLoader.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathValue.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/history/HistoryItem.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XSLStyleSheetLibxslt.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/DocumentTimeline.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/LinkLoader.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/ApplyBlockElementCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/MixedContentChecker.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XMLErrors.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fileapi/BlobBuilder.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/RenderedPosition.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/workers/SharedWorkerContext.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/appcache/DOMApplicationCache.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/ReplaceSelectionCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedScript.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fileapi/FileReaderSync.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedTextTrack.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PageConsole.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/workers/WorkerEventQueue.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PrintContext.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Console.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/EventSource.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertNodeBeforeCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathResult.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedImage.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XSLTProcessor.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/CompositeEditCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/EventHandler.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/htmlediting.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/TypingCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XSLTProcessorLibxslt.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/DragController.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedResourceRequest.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/CreateLinkCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/VisibleUnits.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathExpression.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/VisiblePosition.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/IndentOutdentCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/AutoscrollController.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/storage/Storage.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/plugins/DOMMimeType.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AXObjectCache.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/InternalSettings.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/plugins/DOMPlugin.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ImageLoader.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/FrameSelection.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/DOMWindow.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/FormatBlockCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/SpellingCorrectionCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/SpellChecker.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/ApplyStyleCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/SpatialNavigation.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/TextInsertionBaseCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentLoadTiming.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/TouchAdjustment.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PerformanceResourceTiming.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertParagraphSeparatorCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/CompositeAnimation.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/AppendNodeCommand.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XMLTreeViewer.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedCSSStyleSheet.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/testing/MockPagePopupDriver.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/SurroundingText.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/parser/XMLDocumentParser.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/plugins/DOMMimeTypeArray.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XMLHttpRequest.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XPathVariableReference.cpp?r1=151749&r2=151748&pathrev=151749
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/archive/MHTMLArchive.cpp?r1=151749&r2=151748&pathrev=151749

Remove unused includes from various .cpp files in core/

Splitting up codereview.chromium.org/15447002 into smaller patches.

BUG=242216

Review URL: https://chromiumcodereview.appspot.com/16282004
------------------------------------------------------------------------
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 21 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=152858

------------------------------------------------------------------------
r152858 | timloh@chromium.org | 2013-06-21T05:36:07.538510Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleSheet.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NamedFlow.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DeviceOrientationController.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMImplementation.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSUnicodeRangeValue.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/ContentSelectorQuery.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleRuleImport.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/CustomElementDefinition.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSRegionRule.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ElementRareData.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSImageGeneratorValue.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSReflectValue.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFontFace.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NamedFlow.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/ShadowRoot.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSParser.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/SelectorChecker.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleInvalidationAnalysis.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryListListener.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AccessibilityRenderObject.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Event.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValueList.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSCrossfadeValue.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventTarget.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/MutationRecord.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/ContentDistributor.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleRule.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RuleFeature.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSGroupingRule.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSBorderImage.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/InsertionPoint.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/FontSize.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/CharacterData.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventTarget.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSRuleList.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AccessibilityTableColumn.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AccessibilityObject.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RuleFeature.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/ScopedStyleResolver.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/ViewportStyleResolver.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolverState.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/SVGCSSStyleSelector.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/MutationRecord.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFunctionValue.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/WheelEvent.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSSelector.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/KeyboardEvent.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Attr.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/StyledElement.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/PseudoElement.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/CustomElementRegistry.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Node.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ContainerNodeAlgorithms.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/ViewportStyleResolver.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSAspectRatioValue.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ScriptRunner.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ViewportArguments.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSProperty.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/ElementRuleCollector.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/UserActionElementSet.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSSegmentedFontFace.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventRetargeter.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/MutationObserver.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSParser.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventListenerMap.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPageRule.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ContainerNode.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NamedNodesCollection.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/MessagePort.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DocumentEventQueue.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StylePropertySet.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NodeRenderingContext.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Element.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NodeRareData.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AXObjectCache.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/FilterOperationResolver.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFilterValue.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/InspectorCSSOMWrappers.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/DocumentRuleSets.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFontFaceLoadEvent.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/GestureEvent.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSRuleList.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/MessagePortChannel.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AccessibilityTableHeaderContainer.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NodeRenderingContext.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DOMImplementation.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSMatrix.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventDispatcher.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolverState.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/SpaceSplitString.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSTransformValue.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSLineBoxContainValue.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/DeprecatedStyleBuilder.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/InspectorCSSOMWrappers.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StylePropertySerializer.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/EventDispatcher.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/PageRuleCollector.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/TreeScope.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/MediaQueryExp.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/VisitedLinkState.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSAspectRatioValue.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSCursorImageValue.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/ElementRuleCollector.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Range.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RuleSet.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSSupportsRule.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSProperty.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DeviceOrientationController.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSOMUtils.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DocumentEventQueue.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPropertySourceData.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ScriptedAnimationController.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AccessibilityObject.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSMediaRule.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NodeRareData.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/shadow/ElementShadow.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/ScopedStyleResolver.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RuleSet.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AccessibilityNodeObject.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFontSelector.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ChildListMutationScope.h?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/DocumentFullscreen.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSSelector.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSReflectValue.cpp?r1=152858&r2=152857&pathrev=152858
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Position.cpp?r1=152858&r2=152857&pathrev=152858

Remove unused includes from core/accessibility, core/css and core/dom

Continue removing unused includes as suggested by include-what-you-use.
I've manually looked through all the changes so all the removals should
be actually unused. As usual, if a .cpp only needs a fwd decl of a type
used in a method signature, I assume that the header would already have
included or declared the type and remove the include from the .cpp.

BUG=242216

Review URL: https://chromiumcodereview.appspot.com/17480002
------------------------------------------------------------------------
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 23 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=152932

------------------------------------------------------------------------
r152932 | timloh@chromium.org | 2013-06-23T07:58:19.067142Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ClassList.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/IndentOutdentCommand.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLSourceTracker.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFieldSetElement.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/EditCommand.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/RadioNodeList.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/LoadableTextTrack.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/HTMLShadowElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/LinkResource.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/FormController.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLPreloadScanner.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLParserScheduler.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLParserIdioms.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLCollection.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLTreeBuilder.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fileapi/Blob.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasPathMethods.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLegendElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/XSSAuditorDelegate.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLTexture.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MediaControlElements.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTrackElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/TextControlInnerElements.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/MediaFragmentURIParser.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLObject.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLUniformLocation.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLEmbedElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCueGeneric.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/history/HistoryItem.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLCompressedTextureATC.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTableElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ValidityState.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLImportsController.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLParserIdioms.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInImageElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/PublicURLManager.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLinkElement.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/XSSAuditor.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLShader.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/Editor.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLBuffer.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLDocumentParser.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/FrameSelection.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLTokenizer.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/StepRange.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLInputElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fileapi/BlobBuilder.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ValidationMessage.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/DOMURL.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/VisibleUnits.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOutputElement.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLElementStack.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ClassList.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOptionElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ImageInputType.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLRenderbuffer.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLVertexArrayObjectOES.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/BackgroundHTMLParser.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackList.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSelectElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLCompressedTextureS3TC.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLCollection.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/CompositeEditCommand.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/DeleteSelectionCommand.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/SpellChecker.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/DateTimeFieldsState.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLDebugShaders.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/VisibleUnits.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLSourceElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/BaseDateAndTimeInputType.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLIFrameElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/TypeAhead.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLVideoElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLConstructionSite.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLTitleElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/SliderThumbElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/history/HistoryItem.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLCompressedTextureS3TC.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/MediaController.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/HTMLInterchange.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLinkElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMarqueeElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/HTMLContentElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/LoadableTextTrack.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFormElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDocument.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLProgram.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLFrameOwnerElement.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLCanvasElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLRenderingContext.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrack.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/EditingStyle.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/DateTimeLocalInputType.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/fileapi/File.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/OESVertexArrayObject.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLTreeBuilderSimulator.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLProgressElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/HTMLContentElement.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/DOMSettableTokenList.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/CSSPreloadScanner.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/NumberInputType.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMeterElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/PickerIndicatorElement.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertListCommand.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/TextFieldInputType.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/BackgroundHTMLParser.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLRenderingContext.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/InsertTextCommand.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/BaseDateAndTimeInputType.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MediaControls.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/InbandTextTrack.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLConstructionSite.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/ColorInputType.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/DateTimeEditElement.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/DateInputType.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLBuffer.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/Editor.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInImageElement.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/InputType.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/WebGLContextObject.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/editing/markup.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.cpp?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLDocumentParser.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/SliderThumbElement.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/parser/HTMLTreeBuilder.h?r1=152932&r2=152931&pathrev=152932
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/DOMFormData.cpp?r1=152932&r2=152931&pathrev=152932

Remove unused includes from core/{editing,fileapi,history,html}

Continue removing unused includes as suggested by include-what-you-use.
I've manually looked through the changes here so all the removals should
be actually unused.

BUG=242216

Review URL: https://chromiumcodereview.appspot.com/17388003
------------------------------------------------------------------------
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 29 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=153301

------------------------------------------------------------------------
r153301 | timloh@chromium.org | 2013-06-29T14:39:09.905917Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/SpeechInputEvent.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/ConsoleMessage.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/scrolling/ScrollingCoordinator.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorLayerTreeAgent.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorOverlay.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorFrontendHost.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedTextTrack.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptBase.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PerformanceUserTiming.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDOMStorageAgent.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/PrerendererClient.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PageSerializer.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/TextResourceDecoder.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Page.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorPageAgent.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ResourceLoader.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Screen.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorCanvasAgent.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/CSSPropertyAnimation.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/KeyframeAnimation.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/EventHandler.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorRuntimeAgent.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/AnimationBase.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorInstrumentation.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Frame.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/SubframeLoader.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/DOMSecurityPolicy.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/scrolling/ScrollingCoordinator.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/MemoryCache.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedTextTrack.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PageGroup.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorFrontendHost.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PageConsole.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Console.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorController.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDOMStorageAgent.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/CookieJar.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorState.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/ConsoleMessage.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptHost.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/archive/MHTMLParser.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentThreadableLoader.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/CSSPropertyAnimation.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorStyleSheet.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/TimelineTraceEventProcessor.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/HeapGraphSerializer.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorInstrumentation.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/archive/ArchiveResourceCollection.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/CompositeAnimation.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorResourceAgent.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorCSSAgent.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/ImplicitAnimation.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/TimelineRecordFactory.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/AnimationBase.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/HistoryController.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentLoader.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorOverlayHost.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScriptHost.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorConsoleAgent.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedResourceLoader.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PageConsole.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentWriter.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Settings.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorTimelineAgent.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/DOMWindow.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/MemoryInstrumentationImpl.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorStyleSheet.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ProgressTracker.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedXSLStyleSheet.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/FrameTree.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedImage.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/NetworkResourcesData.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/PingLoader.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentThreadableLoader.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ResourceLoadNotifier.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ThreadableLoader.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedResource.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorProfilerAgent.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/FrameView.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/TimelineTraceEventProcessor.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedCSSStyleSheet.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/ContentSecurityPolicy.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/WorkerNavigator.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedScript.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedResourceRequest.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedFont.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorResourceAgent.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Navigator.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Settings.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorStyleTextEditor.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/animation/AnimationController.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentLoader.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/HistoryController.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/ScriptCallFrame.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedResourceLoader.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorMemoryAgent.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PerformanceTiming.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InjectedScript.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/FrameLoader.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedResource.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/Prerenderer.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PerformanceUserTiming.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/DOMTimer.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Page.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/WindowFocusAllowedIndicator.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorPageAgent.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/ContentSecurityPolicy.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorRuntimeAgent.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDOMAgent.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/SubframeLoader.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/PerformanceResourceTiming.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedRawResource.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/SpeechInputResultList.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorCounters.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/NavigationScheduler.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/MemoryCache.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDOMDebuggerAgent.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/inspector/InspectorDebuggerAgent.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/appcache/DOMApplicationCache.h?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/TextTrackLoader.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Navigator.cpp?r1=153301&r2=153300&pathrev=153301
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/cache/CachedCSSStyleSheet.h?r1=153301&r2=153300&pathrev=153301

Remove unused includes from core/inspector, core/loader and core/page

Continue removing unused includes as suggested by include-what-you-use.
I've manually looked through the changes here so all the removals should
be actually unused. As usual, if a .cpp only needs a fwd decl of a type
used in a method signature, I assume that the header would already have
included or declared the type and remove the include from the .cpp.

BUG=242216

Review URL: https://chromiumcodereview.appspot.com/17569013
------------------------------------------------------------------------
Labels: cleanup
Owner: timloh@chromium.org
Status: Started
Timothy, are you still working on this?
tfarina: I was actually waiting for you to finish off the wtf include style changes to avoid collisions.
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 17 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=154412

------------------------------------------------------------------------
r154412 | timloh@chromium.org | 2013-07-17T18:48:16.558462Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLLinkElement.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleAdjuster.h?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/NodeRenderingContext.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Element.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/SharedStyleFinder.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFontSelector.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/FontBuilder.h?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/RenderStyle.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/ScopedStyleResolver.h?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.h?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/TransformBuilder.h?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/ViewportStyleResolver.h?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolverState.h?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/FilterOperationResolver.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderObject.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/FontLoader.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleBuilderCustom.cpp?r1=154412&r2=154411&pathrev=154412
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleAdjuster.cpp?r1=154412&r2=154411&pathrev=154412

Minor cleanups to includes and fwd decls in core/css/resolver

Remove some unneeded includes/fwd decls in core/css/resolver, and add
some needed ones that were transitively included. IWYU suggests
adding a heap more includes, but since we probably won't have any
automated IWYU checks any time soon these will probably just end up
as unused includes again.

BUG=242216

Review URL: https://chromiumcodereview.appspot.com/19591002
------------------------------------------------------------------------

Comment 24 by pdr@chromium.org, Jul 25 2013

@tfarina, is your wtf work done in crbug.com/254653?
pdr: no, I'm still working on it.
Cc: tfarina@chromium.org
Issue 82098 has been merged into this issue.
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 24 2014

------------------------------------------------------------------
r285366 | tnagel@chromium.org | 2014-07-24T20:59:31.569914Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/wizard_controller.h?r1=285366&r2=285365&pathrev=285366

IWYU in wizard_controller.h.

BUG=242216

Review URL: https://codereview.chromium.org/414023002
-----------------------------------------------------------------
Project Member

Comment 28 by bugdroid1@chromium.org, Jul 24 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8320e01612984cc1847fabb5d40f26336d03550

commit e8320e01612984cc1847fabb5d40f26336d03550
Author: tnagel@chromium.org <tnagel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jul 24 20:59:31 2014

IWYU in wizard_controller.h.

BUG=242216

Review URL: https://codereview.chromium.org/414023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285366 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 29 by bugdroid1@chromium.org, Jul 24 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07436dcb7ad5bab26ad4e1bec66735b27069e4c2

commit 07436dcb7ad5bab26ad4e1bec66735b27069e4c2
Author: tnagel@chromium.org <tnagel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jul 24 23:21:04 2014

IWYU for TrayEnterprise.

BUG=242216

Review URL: https://codereview.chromium.org/415103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285403 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 30 by bugdroid1@chromium.org, Jul 24 2014

------------------------------------------------------------------
r285403 | tnagel@chromium.org | 2014-07-24T23:21:04.372851Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/chromeos/enterprise/tray_enterprise.cc?r1=285403&r2=285402&pathrev=285403
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/system/chromeos/enterprise/tray_enterprise.h?r1=285403&r2=285402&pathrev=285403

IWYU for TrayEnterprise.

BUG=242216

Review URL: https://codereview.chromium.org/415103002
-----------------------------------------------------------------
Owner: ----
Status: Available
Labels: -cleanup Hotlist-CodeHealth CleanUp

Comment 33 by tkent@chromium.org, Jun 24 2016

Cc: -eseidel@chromium.org
Components: -Blink Blink>Internals
Project Member

Comment 34 by sheriffbot@chromium.org, Jun 26 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 35 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c08b5311ef5ac55aad365563ea4dc77e3132781e

commit c08b5311ef5ac55aad365563ea4dc77e3132781e
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jun 15 04:33:57 2018

blink: Reduce the size of local_frame_view.h

This CL reduces estimated expanded size of local_frame_view.h from 8.0MB
to 3.0MB.
FYI: local_frame_view.h is used in 2,400+ compilation units.

- To avoid including chrome_client.h, GetChromeClient() returns
  PlatformChromeClient.
  It overrides ScrollableArea::GetChromeClient(), which returns
  PlatformChromeClient.
  Introduce ToChromeClient(PlatformChromeClient*)

- To avoid including first_meaningful_paint_detector.h, split
  LayoutObjectCounter out from first_meaningful_paint_detector.h.

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I14ad29eb359ed8e1b0506f91674e85e8704f8b8e
Reviewed-on: https://chromium-review.googlesource.com/1100726
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567547}
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/public/platform/web_thread.h
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/frame/root_frame_viewport.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/input/gesture_manager.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/inspector/dev_tools_host.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/custom/custom_layout_child.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/custom/custom_layout_fragment.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/custom/custom_layout_fragment_request.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/layout_theme.h
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/layout_theme_default.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/layout_theme_default.h
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/layout_theme_mac.h
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/layout_theme_mac.mm
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/layout_video.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/scroll_anchor.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/layout/scroll_anchor_test.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/page/chrome_client.h
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/page/scrolling/top_document_root_scroller_controller.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/paint/first_meaningful_paint_detector.h
[add] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/paint/layout_object_counter.h
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/paint/object_paint_invalidator.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/paint/paint_invalidator.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/modules/document_metadata/copyless_paste_extractor.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/platform/scroll/scrollable_area.cc
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/platform/scroll/scrollable_area.h
[modify] https://crrev.com/c08b5311ef5ac55aad365563ea4dc77e3132781e/third_party/blink/renderer/platform/scroll/scrollable_area_test.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46081f63773819e827d6b837bb79365b6312a383

commit 46081f63773819e827d6b837bb79365b6312a383
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jun 15 08:55:30 2018

blink: Reduce the size of thread_state.h.

Remove web_thread.h #include from thread_state.h.

thread_state.h is used in 6000+ compilation units, and this CL reduces
its estimated expanded size from 1,284KB to 937KB.

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If0971d1b069e4bab55a1c1b51fe31514fa32c7c1
Reviewed-on: https://chromium-review.googlesource.com/1102223
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567581}
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/core/dom/scripted_idle_task_controller.h
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/core/html/track/vtt/vtt_region.cc
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/core/workers/parent_execution_context_task_runners.cc
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/core/workers/worker_backing_thread.h
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/modules/webaudio/async_audio_decoder.cc
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/modules/webaudio/deferred_task_handler.cc
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/platform/bindings/v8_per_isolate_data.cc
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/platform/blob/blob_bytes_provider.cc
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/platform/fonts/mac/font_cache_mac.mm
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.h
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/platform/graphics/compositor_mutator_impl.cc
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context.cc
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/platform/graphics/mailbox_texture_holder.h
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/platform/heap/gc_info.h
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/platform/heap/heap_test.cc
[modify] https://crrev.com/46081f63773819e827d6b837bb79365b6312a383/third_party/blink/renderer/platform/heap/thread_state.h

Cc: tkent@chromium.org
tkent, do you have any scripts to identify headers that are worthwhile to work on? Or how do you decide which .h files to reduce?
Project Member

Comment 38 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc

commit 4ab527b20ef3ed6f81ff4672de0a59487cc25bfc
Author: Steve Kobes <skobes@chromium.org>
Date: Sat Jun 16 03:50:10 2018

Shrink PLSA header by 40%.

This patch reduces preprocessed size of paint_layer_scrollable_area.h
from 6.3 MB to 3.8 MB, avoiding transitive inclusion of chrome_client.h
and float_clip_rect.h with tricks similar to crrev.com/567547.  (Since
crrev.com/567732, more source files include PLSA's header.)

Bug: 242216,823365
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I969088b6f75b80d3279b0beb3cc701eb16e6ed6a
Reviewed-on: https://chromium-review.googlesource.com/1103235
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567868}
[modify] https://crrev.com/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc/third_party/blink/renderer/core/layout/jank_tracker.cc
[modify] https://crrev.com/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc/third_party/blink/renderer/core/paint/clip_rect.cc
[modify] https://crrev.com/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc/third_party/blink/renderer/core/paint/clip_rect.h
[modify] https://crrev.com/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/4ab527b20ef3ed6f81ff4672de0a59487cc25bfc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h

Comment 39 by tkent@chromium.org, Jun 18 2018

Labels: -Type-Bug Type-Task
> do you have any scripts to identify headers that are worthwhile to work on? 

Yes, I have a local tool which I made by extending //tools/include_tracer.py. The sheet [1] contains a result of the tool.
I'm not sure if I should check in the tool because it's too hacky and many people won't use it.


[1] https://docs.google.com/spreadsheets/d/1bzF7R4a4Xs4uqspSNpw_g43neklQnJCOulvVV6uLbJ4/edit#gid=1217371495

Project Member

Comment 40 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4662e1ab59df9d91926eb4082dfc2fa3eb7d3e3

commit c4662e1ab59df9d91926eb4082dfc2fa3eb7d3e3
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Jun 18 11:16:59 2018

Oilpan: Reduce the size of heap_page.h.

heap_page.h is used in 6,000+ compilation units, and this CL reduces its
estimated expanded size from 1.72MB to 1.40MB.

Bug: 242216
Change-Id: I0f53c3f57511378289a841b89c6e01c4a2748d4a
Reviewed-on: https://chromium-review.googlesource.com/1104080
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567972}
[modify] https://crrev.com/c4662e1ab59df9d91926eb4082dfc2fa3eb7d3e3/third_party/blink/renderer/platform/heap/heap_page.cc
[modify] https://crrev.com/c4662e1ab59df9d91926eb4082dfc2fa3eb7d3e3/third_party/blink/renderer/platform/heap/heap_page.h

> I'm not sure if I should check in the tool because it's too hacky

What I usually do in this case is upload the tool to gerrit but not send it out for review, and then refer to it like so:

https://chromium-review.googlesource.com/c/chromium/src/+/1097621
https://chromium-review.googlesource.com/c/chromium/src/+/1097616
Project Member

Comment 43 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d

commit 2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d
Author: Taiju Tsuiki <tzik@chromium.org>
Date: Mon Jun 18 12:23:36 2018

Revert "Oilpan: Reduce the size of heap_page.h."

This reverts commit c4662e1ab59df9d91926eb4082dfc2fa3eb7d3e3.

Reason for revert:
This seems to gain the binary size by 0.3~0.9% on mac and win.

Original change's description:
> Oilpan: Reduce the size of heap_page.h.
> 
> heap_page.h is used in 6,000+ compilation units, and this CL reduces its
> estimated expanded size from 1.72MB to 1.40MB.
> 
> Bug: 242216
> Change-Id: I0f53c3f57511378289a841b89c6e01c4a2748d4a
> Reviewed-on: https://chromium-review.googlesource.com/1104080
> Reviewed-by: Keishi Hattori <keishi@chromium.org>
> Commit-Queue: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567972}

TBR=keishi@chromium.org,tkent@chromium.org

Change-Id: I54c95f8102aadf8459a833db0d27b970d291eb93
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 242216, 853703
Reviewed-on: https://chromium-review.googlesource.com/1104357
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567981}
[modify] https://crrev.com/2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d/third_party/blink/renderer/platform/heap/heap_page.cc
[modify] https://crrev.com/2d53370e3e7fb2ee5c09988efd9a37d7a2b3fd2d/third_party/blink/renderer/platform/heap/heap_page.h

Comment 44 by most...@vewd.com, Jun 18 2018

Cc: most...@vewd.com brat...@opera.com
@tkent: thanks for working on this!  I have been wondering how it might be possible to implement an inverse IWYU tool ("DIWYDU"?) on and off for a while.
Project Member

Comment 45 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6f4017fb796b1a85187e48c2b84bebacc74246a

commit b6f4017fb796b1a85187e48c2b84bebacc74246a
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Jun 19 02:27:31 2018

blink: Reduce the size of execution_context.h

execution_context.h is used in 4,800+ compilation units, and this CL
reduces its estimated expanded size from 3.17MB to 1.95MB.

This CL removes #includes for single_thread_task_runner.h,
security_context.h, and kurl.h from execution_context.h.

Bug: 242216
Change-Id: I2e37b1c58902a58ba3370c26a5a38513ca1e3cbc
Reviewed-on: https://chromium-review.googlesource.com/1102293
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568307}
[modify] https://crrev.com/b6f4017fb796b1a85187e48c2b84bebacc74246a/third_party/blink/renderer/core/execution_context/execution_context.h
[modify] https://crrev.com/b6f4017fb796b1a85187e48c2b84bebacc74246a/third_party/blink/renderer/core/html/forms/html_form_control_element.h
[modify] https://crrev.com/b6f4017fb796b1a85187e48c2b84bebacc74246a/third_party/blink/renderer/core/html/media/media_remoting_interstitial.h
[modify] https://crrev.com/b6f4017fb796b1a85187e48c2b84bebacc74246a/third_party/blink/renderer/core/messaging/message_port.h
[modify] https://crrev.com/b6f4017fb796b1a85187e48c2b84bebacc74246a/third_party/blink/renderer/core/workers/abstract_worker.h
[modify] https://crrev.com/b6f4017fb796b1a85187e48c2b84bebacc74246a/third_party/blink/renderer/modules/mediasession/media_metadata_sanitizer.cc
[modify] https://crrev.com/b6f4017fb796b1a85187e48c2b84bebacc74246a/third_party/blink/renderer/modules/presentation/presentation_request_test.cc

Project Member

Comment 46 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/718da650fc762f9776e6266135ded1edd373cfab

commit 718da650fc762f9776e6266135ded1edd373cfab
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Jun 19 02:37:30 2018

dom: Remove mutation_observer.h dependency from node.h.

node.h is used in 4,700+ compilation units, and this CL reduces its
estimated expanded size from 3.47MB to 2.58MB.

Node depended on enum blink::MutationObserver::MutationType. This CL
makes it to blink::MutationType, and moves it out from
mutation_observer.h.

Also, NodeMutationObserverData in node_rare_data.h depended on
mutation_observer_registration.h. This CL moves member functions of
NodeMutationObserverData from node_rare_data.h to node_rare_data.cc
to remove #include mutation_observer_registration.h.

Bug: 242216
Change-Id: I7a603bda1442dedc45674daab1b5d8f5b369f123
Reviewed-on: https://chromium-review.googlesource.com/1102291
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568311}
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/child_list_mutation_scope.h
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/mutation_observer.cc
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/mutation_observer.h
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/mutation_observer_interest_group.cc
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/mutation_observer_interest_group.h
[add] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/mutation_observer_options.h
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/mutation_observer_registration.cc
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/mutation_observer_registration.h
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/node_iterator_base.cc
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/node_rare_data.cc
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/core/dom/node_rare_data.h
[modify] https://crrev.com/718da650fc762f9776e6266135ded1edd373cfab/third_party/blink/renderer/modules/payments/payment_request.h

Project Member

Comment 47 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd3b366822d36a0a203d51901336366e7ac5b287

commit fd3b366822d36a0a203d51901336366e7ac5b287
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jun 20 02:25:08 2018

Reland: Oilpan: Reduce the size of heap_page.h.

heap_page.h is used in 6,000+ compilation units, and this CL reduces its
estimated expanded size from 1.72MB to 1.40MB.

This CL relands https://chromium-review.googlesource.com/1104080 .
With the original code, GetRandomMagic() was folded into GetMagic(), and
GetMagic() was not folded into IsValid().
With https://chromium-review.googlesource.com/1104080,
ComputeRandomMagic() was not folded into GetMagic(), and GeMagic() and
IsValid() were folded into IsValid() callsites.  So the binary size
increased.
With this CL, GetMagic() isn't folded into IsValid() like the original
code. So this CL won't increase the binary size, and should not have
performance regression.

Bug: 242216
Change-Id: I7b6cf78a454abbbf3a3e41d821ac23e208b6dbdb
Reviewed-on: https://chromium-review.googlesource.com/1105208
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568696}
[modify] https://crrev.com/fd3b366822d36a0a203d51901336366e7ac5b287/third_party/blink/renderer/platform/heap/heap_page.cc
[modify] https://crrev.com/fd3b366822d36a0a203d51901336366e7ac5b287/third_party/blink/renderer/platform/heap/heap_page.h

Project Member

Comment 48 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7491f7b7502a19122bb5c5c4443fb5c055403272

commit 7491f7b7502a19122bb5c5c4443fb5c055403272
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jun 20 05:25:24 2018

Blink loader: Reduce the size of resource_request.h

Remove dependency to encoded_form_data.h and security_origin.h.

resource_request.h is used in 4,400+ compilation units, and this CL
reduces its estimated expanded size by 0.24MB.

Bug: 242216
Change-Id: Ief70b318e39c508b75791db3d708ed7cee40c277
Reviewed-on: https://chromium-review.googlesource.com/1107030
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568734}
[modify] https://crrev.com/7491f7b7502a19122bb5c5c4443fb5c055403272/third_party/blink/renderer/core/inspector/network_resources_data.cc
[modify] https://crrev.com/7491f7b7502a19122bb5c5c4443fb5c055403272/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/7491f7b7502a19122bb5c5c4443fb5c055403272/third_party/blink/renderer/core/loader/history_item.cc
[modify] https://crrev.com/7491f7b7502a19122bb5c5c4443fb5c055403272/third_party/blink/renderer/core/loader/ping_loader_test.cc
[modify] https://crrev.com/7491f7b7502a19122bb5c5c4443fb5c055403272/third_party/blink/renderer/modules/mediarecorder/media_recorder.cc
[modify] https://crrev.com/7491f7b7502a19122bb5c5c4443fb5c055403272/third_party/blink/renderer/modules/mediarecorder/media_recorder.h
[modify] https://crrev.com/7491f7b7502a19122bb5c5c4443fb5c055403272/third_party/blink/renderer/platform/exported/web_url_request.cc
[modify] https://crrev.com/7491f7b7502a19122bb5c5c4443fb5c055403272/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/7491f7b7502a19122bb5c5c4443fb5c055403272/third_party/blink/renderer/platform/loader/fetch/resource_request.cc
[modify] https://crrev.com/7491f7b7502a19122bb5c5c4443fb5c055403272/third_party/blink/renderer/platform/loader/fetch/resource_request.h

Project Member

Comment 49 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31f7bffa1700df519d75a97c6981fcd43695b672

commit 31f7bffa1700df519d75a97c6981fcd43695b672
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jun 20 05:28:20 2018

bindings: Reduce the size of v8_script_runner.h

v8_script_runner.h is used in 2,800+ compilation units, and this CL
reduces its estimated expanded size from 4.06MB to 0.65MB.

Bug: 242216
Change-Id: I87f5b5ada11794eaab07c1375741dce760201605
Reviewed-on: https://chromium-review.googlesource.com/1107034
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568735}
[modify] https://crrev.com/31f7bffa1700df519d75a97c6981fcd43695b672/third_party/blink/renderer/bindings/core/v8/script_controller.cc
[modify] https://crrev.com/31f7bffa1700df519d75a97c6981fcd43695b672/third_party/blink/renderer/bindings/core/v8/script_module.cc
[modify] https://crrev.com/31f7bffa1700df519d75a97c6981fcd43695b672/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/31f7bffa1700df519d75a97c6981fcd43695b672/third_party/blink/renderer/bindings/core/v8/v8_script_runner.h
[modify] https://crrev.com/31f7bffa1700df519d75a97c6981fcd43695b672/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc
[modify] https://crrev.com/31f7bffa1700df519d75a97c6981fcd43695b672/third_party/blink/renderer/modules/presentation/presentation_connection.h

Project Member

Comment 50 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da

commit 3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Jun 25 01:37:09 2018

Blink loader: Reduce the size of history_item.h

history_item.h is used in 1900+ compilation units, and this CL reduces
estimated pre-processed size of history_item.h from 5.78MB to 2.03MB.

Bug: 242216
Change-Id: I1db28440031fd826349278febd2ffa79af58f1ca
Reviewed-on: https://chromium-review.googlesource.com/1111774
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569948}
[modify] https://crrev.com/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da/third_party/blink/renderer/core/events/pop_state_event.cc
[modify] https://crrev.com/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da/third_party/blink/renderer/core/events/pop_state_event.h
[modify] https://crrev.com/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da/third_party/blink/renderer/core/layout/custom/layout_custom.cc
[modify] https://crrev.com/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da/third_party/blink/renderer/core/loader/frame_loader.h
[modify] https://crrev.com/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da/third_party/blink/renderer/core/loader/history_item.cc
[modify] https://crrev.com/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da/third_party/blink/renderer/core/loader/history_item.h
[modify] https://crrev.com/3816ddd3a9aa8a35aaff936186a6ac7e0ecf18da/third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc

Project Member

Comment 51 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c803b8978405c0dd15d46a9f047ff4e4bd318d0a

commit c803b8978405c0dd15d46a9f047ff4e4bd318d0a
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jun 27 12:42:16 2018

blink: Reduce the size of local_frame.h

local_frame.h is used in 1,900+ compilation units, and this CL reduces
its pre-processed size from 7.53MB to 4.48MB.

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4f833b9994c8a5f4e950f446665135e23c92dc92
Reviewed-on: https://chromium-review.googlesource.com/1116408
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570741}
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/bindings/core/v8/script_module_test.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/bindings/core/v8/script_promise_resolver_test.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/controller/blink_initializer.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/controller/blink_leak_detector.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/dom/abort_signal.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/dom/element_visibility_observer.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/dom/events/event.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/dom/user_gesture_indicator.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/frame/dom_window.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/frame/platform_event_controller.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/frame/platform_event_controller.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/frame/platform_event_dispatcher.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/frame/web_frame_widget_base.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/html/media/html_video_element_test.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/html/track/cue_timeline.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/input/event_handling_util.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/inspector/inspector_task_runner.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/inspector/main_thread_debugger.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/inspector/thread_debugger.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/intersection_observer/intersection_observer_test.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/loader/empty_clients.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/loader/scheduled_navigation.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/svg/svg_script_element.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/timing/window_performance.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/core/workers/execution_context_worker_registry.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/background_fetch/background_fetched_event.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/clipboard/clipboard_promise.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/device_orientation/device_motion_controller.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/device_orientation/device_motion_controller.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/device_orientation/device_orientation_absolute_controller.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/device_orientation/device_orientation_controller.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/device_orientation/device_orientation_controller.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/document_metadata/copyless_paste_extractor.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/encryptedmedia/media_keys_controller.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/encryptedmedia/navigator_request_media_key_system_access.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/exported/web_dom_file_system.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/geolocation/geo_notifier.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/geolocation/geolocation.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/keyboard/keyboard_layout.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/media_controls/elements/media_control_cast_button_element.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/media_controls/elements/media_control_fullscreen_button_element.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_list_element.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/media_controls/elements/media_control_text_track_list_element.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/media_controls/media_controls_media_event_listener.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/navigatorcontentutils/navigator_content_utils.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/netinfo/network_information.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/nfc/nfc.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/notifications/notification_manager.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/presentation/presentation_availability_state.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/sensor/sensor.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/sensor/sensor_inspector_agent.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/sensor/sensor_proxy.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/sensor/sensor_proxy_inspector_impl.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/speech/speech_recognition_controller.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/storage/storage_area.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/webaudio/audio_context_test.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/webaudio/audio_scheduled_source_node.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/webaudio/audio_worklet_messaging_proxy.h
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/webaudio/script_processor_node.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/webusb/navigator_usb.cc
[modify] https://crrev.com/c803b8978405c0dd15d46a9f047ff4e4bd318d0a/third_party/blink/renderer/modules/xr/xr_device.cc

Project Member

Comment 52 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a1aae3abd6f9ba59efd4dc3b40545a13d7f14eb

commit 1a1aae3abd6f9ba59efd4dc3b40545a13d7f14eb
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jun 28 05:19:18 2018

bindings: Reduce the size of wrapper_type_info.h

wrapper_type_info.h is used in 5,000+ compilation units, and this CL
reduces its pre-processed size from 2.24MB to 1.61MB.

This CL uninlines WrapperTypeInfo::WrapperCreated() and
WrapperTypeInfo::WrapperDestroyed(). It might affect performance
slightly.

Bug: 242216
Change-Id: I8219835eee87e7b56f85437be8e01c1e69c15f31
Reviewed-on: https://chromium-review.googlesource.com/1117736
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571033}
[modify] https://crrev.com/1a1aae3abd6f9ba59efd4dc3b40545a13d7f14eb/third_party/blink/renderer/bindings/core/v8/v8_gc_controller.cc
[modify] https://crrev.com/1a1aae3abd6f9ba59efd4dc3b40545a13d7f14eb/third_party/blink/renderer/core/frame/reporting_observer.cc
[modify] https://crrev.com/1a1aae3abd6f9ba59efd4dc3b40545a13d7f14eb/third_party/blink/renderer/platform/bindings/dom_wrapper_map.h
[modify] https://crrev.com/1a1aae3abd6f9ba59efd4dc3b40545a13d7f14eb/third_party/blink/renderer/platform/bindings/v8_per_context_data.h
[modify] https://crrev.com/1a1aae3abd6f9ba59efd4dc3b40545a13d7f14eb/third_party/blink/renderer/platform/bindings/v8_per_isolate_data.cc
[modify] https://crrev.com/1a1aae3abd6f9ba59efd4dc3b40545a13d7f14eb/third_party/blink/renderer/platform/bindings/wrapper_type_info.cc
[modify] https://crrev.com/1a1aae3abd6f9ba59efd4dc3b40545a13d7f14eb/third_party/blink/renderer/platform/bindings/wrapper_type_info.h

Project Member

Comment 53 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9aa696896b948cdbec6a50d52b7e0eb789600e90

commit 9aa696896b948cdbec6a50d52b7e0eb789600e90
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jun 28 09:03:03 2018

bindings: Reduce the size of serialized_script_value.h

serialized_script_value.h is used in 2,000+ compilation units, and this
CL reduces its pre-processed size from 5.11MB to 1.79MB.

Also, this CL removes unnecessary #includes for
serialzied_script_value.h.

Bug: 242216
Change-Id: I8bbd09c96461d658770abe40df782d37871d3847
Reviewed-on: https://chromium-review.googlesource.com/1116410
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571051}
[modify] https://crrev.com/9aa696896b948cdbec6a50d52b7e0eb789600e90/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
[modify] https://crrev.com/9aa696896b948cdbec6a50d52b7e0eb789600e90/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h
[modify] https://crrev.com/9aa696896b948cdbec6a50d52b7e0eb789600e90/third_party/blink/renderer/core/layout/custom/custom_layout_constraints.cc
[modify] https://crrev.com/9aa696896b948cdbec6a50d52b7e0eb789600e90/third_party/blink/renderer/core/loader/document_threadable_loader.cc
[modify] https://crrev.com/9aa696896b948cdbec6a50d52b7e0eb789600e90/third_party/blink/renderer/core/timing/performance_mark.cc
[modify] https://crrev.com/9aa696896b948cdbec6a50d52b7e0eb789600e90/third_party/blink/renderer/core/timing/performance_measure.cc
[modify] https://crrev.com/9aa696896b948cdbec6a50d52b7e0eb789600e90/third_party/blink/renderer/core/workers/dedicated_worker.h
[modify] https://crrev.com/9aa696896b948cdbec6a50d52b7e0eb789600e90/third_party/blink/renderer/modules/serviceworkers/extendable_event.cc
[modify] https://crrev.com/9aa696896b948cdbec6a50d52b7e0eb789600e90/third_party/blink/renderer/modules/serviceworkers/wait_until_observer.h

Project Member

Comment 54 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40a6598ec8525dad0a754ecc812aeaaedc205c37

commit 40a6598ec8525dad0a754ecc812aeaaedc205c37
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jun 29 06:04:44 2018

blink: Reduce the size of security_context.h.

security_context.h is used in 3,100+ compilation units, and this CL
reduces its pre-processed size from 3.10MB to 1.74MB.

Bug: 242216
Change-Id: I0fe6dd82eea775853cfe23377f2803bd0f90b069
Reviewed-on: https://chromium-review.googlesource.com/1119613
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571404}
[modify] https://crrev.com/40a6598ec8525dad0a754ecc812aeaaedc205c37/third_party/blink/renderer/core/execution_context/security_context.h

Project Member

Comment 55 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11751062c1d636b8dd4b19db400469ee20734903

commit 11751062c1d636b8dd4b19db400469ee20734903
Author: Andrey Kraynov <iceman@yandex-team.ru>
Date: Mon Jul 02 08:49:23 2018

Clean includes in bindings/core/v8/

Looks like it is possible to move some includes to *.cc files with
forwards, and even remove some unused ones.
This can simplify compilers's work, for example touching script_function.h
header leads to recompiling 4K targets without jumbo builds.

No behavior changes.

Bug: 242216

Change-Id: Id7aacfa32400fdb150acced4603f591b24db9361
Reviewed-on: https://chromium-review.googlesource.com/1120176
Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571843}
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/referrer_script_info.h
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/scheduled_action.cc
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/scheduled_action.h
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/script_controller.h
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/script_event_listener.h
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/script_module.cc
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/script_module.h
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/script_promise.cc
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/script_promise.h
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/script_streamer_thread.cc
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/script_streamer_thread.h
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/core/v8/source_location.h
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules_test.cc
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches_test.cc
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/modules/cache_storage/cache.cc
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/modules/locks/lock.cc
[modify] https://crrev.com/11751062c1d636b8dd4b19db400469ee20734903/third_party/blink/renderer/modules/remoteplayback/remote_playback_test.cc

Project Member

Comment 56 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/015707c1649fe5bf0fb7b51150358bfb056ed0f6

commit 015707c1649fe5bf0fb7b51150358bfb056ed0f6
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Jul 03 10:49:58 2018

Blink loader: Reduce the size of resource_client.h

resource_client.h is used in 1,600+ compilation units, and this CL
reduces its estimated pre-processed size from 4.04MB to 1.73MB.

Bug: 242216
Change-Id: Iae174451fe424d9765b0ada17c0fef8e9190839c
Reviewed-on: https://chromium-review.googlesource.com/1124269
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572168}
[modify] https://crrev.com/015707c1649fe5bf0fb7b51150358bfb056ed0f6/third_party/blink/renderer/platform/loader/BUILD.gn
[add] https://crrev.com/015707c1649fe5bf0fb7b51150358bfb056ed0f6/third_party/blink/renderer/platform/loader/fetch/resource_client.cc
[modify] https://crrev.com/015707c1649fe5bf0fb7b51150358bfb056ed0f6/third_party/blink/renderer/platform/loader/fetch/resource_client.h

Project Member

Comment 57 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43e798a695b7ef7d666472a664c0997400d74061

commit 43e798a695b7ef7d666472a664c0997400d74061
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Jul 03 11:14:47 2018

blink: Reduce the size of web_url_request.h.

web_url_request.h is used in 3,600+ compilation units, and this CL
reduces its estimated pre-processed size from 2.82MB to 0.31MB.

Bug: 242216
Change-Id: I60209d15fd6faac4a2bab5696ef307a1b90d6b10
Reviewed-on: https://chromium-review.googlesource.com/1124254
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572169}
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/android_webview/browser/aw_contents_client_bridge_unittest.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/chrome/browser/offline_pages/offline_page_request_handler.h
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/chrome/renderer/sandbox_status_extension_android.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/content/renderer/service_worker/worker_fetch_context_impl.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/third_party/blink/public/platform/web_url_loader_client.h
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/third_party/blink/public/platform/web_url_request.h
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/third_party/blink/renderer/core/fetch/fetch_request_data.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/third_party/blink/renderer/modules/serviceworkers/service_worker_window_client_callback.h
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/third_party/blink/renderer/modules/vr/navigator_vr.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/third_party/blink/renderer/platform/exported/web_service_worker_request.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/43e798a695b7ef7d666472a664c0997400d74061/third_party/blink/renderer/platform/loader/fetch/resource_request.h

Project Member

Comment 58 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75

commit db30d75171b1af5e2e5fb0e96fff88d7ff91ce75
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jul 04 11:36:06 2018

bindings: Reduce the size of script_state.h

script_state.h is used in 4,500+ compilation units, and this CL reduces
its estimated pre-processed size from 2.13MB to 0.79MB.

* Move |kV8ContextPerContextDataIndex| from v8_per_context_data.h to
  script_state.h.
  Also, it should not be an enum item.

* Generated binding code doesn't include v8_per_context_data.h by
  default. So we need to include it if necessary.

Bug: 242216
Change-Id: Icb219357585ccb55a8932131473fe0a9b3bc1484
Reviewed-on: https://chromium-review.googlesource.com/1125592
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572538}
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/core/v8/generated_code_helper.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/core/v8/scheduled_action.h
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/core/v8/v8_v0_custom_element_lifecycle_callbacks.h
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/core/v8/window_proxy.h
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/scripts/generate_origin_trial_features.py
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/scripts/v8_callback_interface.py
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/scripts/v8_interface.py
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/scripts/v8_methods.py
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/tests/results/core/origin_trial_features_for_core.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.h
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/tests/results/modules/origin_trial_features_for_modules.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/core/frame/report.h
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/core/testing/v8/web_core_test_support.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/platform/bindings/dom_wrapper_world.h
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/platform/bindings/script_state.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/platform/bindings/script_state.h
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/platform/bindings/v8_dom_activity_logger.cc
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/platform/bindings/v8_per_context_data.h
[modify] https://crrev.com/db30d75171b1af5e2e5fb0e96fff88d7ff91ce75/third_party/blink/renderer/platform/bindings/v8_per_isolate_data.h

Project Member

Comment 59 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a7ad3d5b4c4e5b5a48d9280d92ba4d500543b7

commit 62a7ad3d5b4c4e5b5a48d9280d92ba4d500543b7
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jul 05 02:22:04 2018

DOM: Reduce the size of document.h

This CL reduces the estimated pre-processed size of document.h from
4.36MB to 4.16MB.

* GetScheduler():
This overrides |FrameOrWorkerScheduler* ExecutionContext::
GetScheduler()|. Document::GetScheduler() returned FrameScheduler,
which is a subclass of FrameOrWorkerScheduler, but no one needs
FrameScheduler.

Bug: 242216
Change-Id: Ic998973a3dc9b934b3ea2abef1b9e35b9e9f022c
Reviewed-on: https://chromium-review.googlesource.com/1125742
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572692}
[modify] https://crrev.com/62a7ad3d5b4c4e5b5a48d9280d92ba4d500543b7/third_party/blink/renderer/bindings/core/v8/initialize_v8_extras_binding_test.cc
[modify] https://crrev.com/62a7ad3d5b4c4e5b5a48d9280d92ba4d500543b7/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/62a7ad3d5b4c4e5b5a48d9280d92ba4d500543b7/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/62a7ad3d5b4c4e5b5a48d9280d92ba4d500543b7/third_party/blink/renderer/core/html/html_slot_element.cc
[modify] https://crrev.com/62a7ad3d5b4c4e5b5a48d9280d92ba4d500543b7/third_party/blink/renderer/core/xml/document_xpath_evaluator.cc
[modify] https://crrev.com/62a7ad3d5b4c4e5b5a48d9280d92ba4d500543b7/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc

Blockedon: 860402
Project Member

Comment 61 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9485eecb69591e5f4cdeda769d52f3d5ec003758

commit 9485eecb69591e5f4cdeda769d52f3d5ec003758
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Jul 09 04:13:07 2018

Introduce blink::ViewportData to store viewport-related stuff in blink::Document.

This reduces the pre-processed size of document.h by 856KB.

Bug: 242216, 860402
Change-Id: Ib5302d881190394db8a22e4dc40b508deb0957fe
Reviewed-on: https://chromium-review.googlesource.com/1126746
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573213}
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/css/style_engine_test.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/dom/document_test.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/frame/BUILD.gn
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/frame/local_dom_window.cc
[add] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/frame/viewport_data.cc
[add] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/frame/viewport_data.h
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/html/html_meta_element.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/html/html_meta_element_test.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/html/parser/html_preload_scanner.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/layout/text_autosizer.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/modules/media_controls/media_controls_display_cutout_delegate.cc
[modify] https://crrev.com/9485eecb69591e5f4cdeda769d52f3d5ec003758/third_party/blink/renderer/modules/media_controls/media_controls_display_cutout_delegate_test.cc

Project Member

Comment 62 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/261ddd76e3f59c55e8a946366195ac1b51a1cb26

commit 261ddd76e3f59c55e8a946366195ac1b51a1cb26
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Jul 09 22:08:25 2018

Blink style: Reduce the size of computed_style.h

computed_style.h is used in 1,300+ compilation units, and this CL
reduces its pre-processed size by 1.09MB.

* Avoid including image_resource_content.h
 image_resource_content.h is large due to dependency to mojom files.
 Stop inlining ShapeValue::IsImageValid().

* Avoid including style_svg_resource.h
  style_svg_resource.h and svg_resource.h are large due to
  dependency to mojom files.
 - Stop inlining many functions using StyleSVGResource and
   SVGResource.
 - Move ReferenceClipPathOperation and ShapeClipPathOperation
   to their own files.
 - Fix make_css_property_subclasses.py for generated
   core/css/properties/longhands/marker_*.h, which depend on
   StyleSVGResource.

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I907a7772283b282a410fb47f457c447d5417f650
Reviewed-on: https://chromium-review.googlesource.com/1128794
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573473}
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_subclasses.py
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/animation/css_basic_shape_interpolation_type.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/css/properties/computed_style_utils.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/css/properties/longhands/clip_path_custom.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/css/resolver/element_style_resources.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/layout/svg/svg_layout_support.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/layout/svg/svg_layout_tree_as_text.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/layout/svg/svg_resources.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/paint/clip_path_clipper.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/BUILD.gn
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/clip_path_operation.h
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/computed_style.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/computed_style.h
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/computed_style_test.cc
[rename] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/reference_clip_path_operation.cc
[add] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/reference_clip_path_operation.h
[add] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/shape_clip_path_operation.h
[add] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/shape_value.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/shape_value.h
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/svg_computed_style.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/svg_computed_style.h
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/svg_computed_style_defs.cc
[modify] https://crrev.com/261ddd76e3f59c55e8a946366195ac1b51a1cb26/third_party/blink/renderer/core/style/svg_computed_style_defs.h

> image_resource_content.h is large due to dependency to mojom files.

Hm, that sound a bit worrying. Are all h files generated from mojom files large? If so we should have a bug for that, that sounds like a problem for using mojo more.
> Hm, that sound a bit worrying. Are all h files generated from mojom files large? If so we should have a bug for that, that sounds like a problem for using mojo more.

I filed Issue 862064.

Project Member

Comment 65 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f

commit 4752b2f2c6b1d7b57b69f1bbeea924693bfd422f
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Jul 10 08:14:46 2018

Blink style: Remove dependency from commputed_style.h to cc/paint/.

cc/paint/*.h are large. This CL reduces computed_style.h's
pre-processed size by 1.00MB.

This CL removes some #includes for:
 - image.h, depending on cc/paint/paint_*.h
 - paint_record.h, depending on cc/paint/paint_record.h
 - skia_utils.h, depending on image.h

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I20cf47aee982475fe1319d6a6cdddd0adff024d4
Reviewed-on: https://chromium-review.googlesource.com/1130569
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573648}
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/core/css/resolver/style_builder_converter.h
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/core/css/threaded/font_object_threaded_test.cc
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/core/layout/layout_object.h
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/core/layout/layout_text_combine.h
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/core/paint/box_painter_base.h
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/core/style/filter_operations.h
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/core/style/shadow_data.cc
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/core/style/shadow_data.h
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/core/style/style_generated_image.cc
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/core/style/style_image.h
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/modules/csspaint/paint_worklet_test.cc
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/platform/graphics/box_reflection.cc
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/platform/graphics/box_reflection.h
[modify] https://crrev.com/4752b2f2c6b1d7b57b69f1bbeea924693bfd422f/third_party/blink/renderer/platform/graphics/test/mock_paint_canvas.h

Project Member

Comment 66 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2932b8bf7174dbd4ca26a7a8c162962824b15233

commit 2932b8bf7174dbd4ca26a7a8c162962824b15233
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Jul 10 12:45:17 2018

Remove cross_thread_copier.h from document_encoding_data.h.

DocumentEncodingData is never passed across threads.

Bug: 242216, 689702
Change-Id: If5a78abdb39399c3283480310f5bbe1fab669700
Reviewed-on: https://chromium-review.googlesource.com/1131046
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573694}
[modify] https://crrev.com/2932b8bf7174dbd4ca26a7a8c162962824b15233/third_party/blink/renderer/core/dom/document_encoding_data.h

Project Member

Comment 67 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/542807b25b6e7befcb71e69597fbc45dc3a52e6a

commit 542807b25b6e7befcb71e69597fbc45dc3a52e6a
Author: Andrey Kraynov <iceman@yandex-team.ru>
Date: Tue Jul 10 20:17:40 2018

bindings: Reduce size of few headers in platform/bindings/

Clean unused includes and add forward declarations for classes
when possible to reduce size of headers.

* Move implementation of the |Policy::UpdateContainerPolicy| function to
  the policy.cc file to avoid including SecurityOrigin header to policy.h.

Bug: 242216
Change-Id: Ib8923f7715b5f321d52c58ca96a7a4bbaa0dcdc5
Reviewed-on: https://chromium-review.googlesource.com/1125935
Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573881}
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/core/css/cssom/prepopulated_computed_style_property_map.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/core/fetch/fetch_request_data.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/core/policy/policy.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/core/policy/policy.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/core/script/document_modulator_impl.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/core/timing/window_performance_test.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/modules/encryptedmedia/content_decryption_module_result_promise.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/modules/encryptedmedia/content_decryption_module_result_promise.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/modules/locks/lock_manager.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/modules/payments/payment_request_details_test.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/modules/payments/payment_test_helper.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/modules/presentation/presentation_request_test.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/modules/webaudio/audio_param.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/dom_data_store.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/dom_wrapper_map.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/dom_wrapper_world.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/dom_wrapper_world.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/runtime_call_stats.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/scoped_persistent.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/to_v8.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/trace_wrapper_member.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/trace_wrapper_v8_string.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/trace_wrapper_v8_string.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/v8_binding.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/v8_per_context_data.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/v8_per_context_data.h
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/v8_per_isolate_data.cc
[modify] https://crrev.com/542807b25b6e7befcb71e69597fbc45dc3a52e6a/third_party/blink/renderer/platform/bindings/v8_per_isolate_data.h

Project Member

Comment 68 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b833f5b733ed26161ccffde48e1341528baf4f02

commit b833f5b733ed26161ccffde48e1341528baf4f02
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Jul 10 22:59:39 2018

bindings: Reduce the size of runtime_call_stats.h.

runtime_call_stats.h is used in 3,700+ compilation units, and this CL
reduces its pre-processed size by 1.09MB.

- In order to remove trace_event.h include, move some part of
  RuntimeCallStatsScopedTracer constructor to
  AddBeginTraceEventIfEnabled().
  This change didn't regress Speedometer locally.

- trace_event.h provided base::size() indirectly for many files. We need
  to update them to include base/stl_util.h.

Bug: 242216
Change-Id: I283bde2c0f2f78b95ce88885054cea1086579d74
Reviewed-on: https://chromium-review.googlesource.com/1130962
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573967}
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/core/v8/script_regexp.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/scripts/v8_callback_function.py
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/scripts/v8_dictionary.py
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/scripts/v8_union.py
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/double_or_string.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/nested_union_type.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/string_or_double.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/core/xml_http_request_or_string.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/modules/boolean_or_string.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/platform/bindings/runtime_call_stats.cc
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/platform/bindings/runtime_call_stats.h
[modify] https://crrev.com/b833f5b733ed26161ccffde48e1341528baf4f02/third_party/blink/renderer/platform/bindings/v8_dom_wrapper.h

Blockedon: 862064
Another local tool to generate treemap: https://chromium-review.googlesource.com/c/chromium/src/+/1132269

Result for layout_object.h attached.

Screen Shot 2018-07-11 at 11.39.39.png
138 KB View Download
Project Member

Comment 71 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb

commit b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jul 12 12:30:49 2018

Oilpan: Do not include wtf/functional.h

No one in platform/heap/ needs wtf/functional.h, though persistent.h
needs base/bind.h for IsWeakReceiver<> and BindUnwrapTraits<>.

This CL reduces the pre-processed size of handle.h by 31KB.

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6097a6f22dbe7a762f4b0a23560c731a07daf5ce
Reviewed-on: https://chromium-review.googlesource.com/1134809
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574536}
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_descriptor.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_service.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/budget/budget_service.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/filesystem/directory_reader.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/filesystem/file_system_callbacks.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/gamepad/gamepad_haptic_actuator.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.h
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/locks/lock.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/mediastream/media_devices_test.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/payments/payment_manager.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/service_worker/respond_with_observer.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/modules/webusb/usb_device.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image_test.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/graphics/skia_texture_holder.h
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/heap/persistent.h
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/heap/thread_state.h
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/testing/empty_web_media_player.h
[modify] https://crrev.com/b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb/third_party/blink/renderer/platform/testing/unit_test_helpers.cc

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/148dd249a40000
Project Member

Comment 74 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38fb4341b66debbe800f2e3d66f1fca1de426f4f

commit 38fb4341b66debbe800f2e3d66f1fca1de426f4f
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jul 25 12:47:53 2018

Blink scheduler: Move RAILModeObserver out from WebThreadScheduler

*.h for RAILModeObserver implementors can avoid including large
web_thread_scheduler.h by this CL.

This CL reduces the pre-processed size of platform/heap/handle.h from
3.07MB to 1.59MB

Bug: 242216
Change-Id: I95fef4e3e0dcafe5c4f5ee1f6ba77c4095a41ca1
Reviewed-on: https://chromium-review.googlesource.com/1149427
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577851}
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/content/renderer/dom_storage/local_storage_cached_area.cc
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/content/renderer/render_thread_impl.h
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/public/platform/scheduler/test/mock_renderer_scheduler.h
[add] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/public/platform/scheduler/web_rail_mode_observer.h
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/public/platform/scheduler/web_thread_scheduler.h
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/platform/heap/thread_state.cc
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/platform/heap/thread_state.h
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/platform/scheduler/common/web_thread_scheduler.cc
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/platform/scheduler/test/fake_renderer_scheduler.cc
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[modify] https://crrev.com/38fb4341b66debbe800f2e3d66f1fca1de426f4f/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 75 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca70b72c9b23286a4aab92a7cd95e868e93fc148

commit ca70b72c9b23286a4aab92a7cd95e868e93fc148
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Aug 01 08:25:47 2018

DOM: Reduce the size of registered_event_listener.h

registered_event_listener.h is used in many popular headers such as
node.h and document.h.  This reduces their pre-processed size
by 0.55MB.

If this CL causes performance regression, it should be reverted.

This CL also adds a comment on RegisteredEventListener class.

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id37380734d2600bc58a9b6d70672c61eff8f5c71
Reviewed-on: https://chromium-review.googlesource.com/1158104
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579729}
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/core/dom/events/event_listener_map.cc
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/core/dom/events/event_target.h
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/core/events/BUILD.gn
[add] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/core/events/registered_event_listener.cc
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/core/events/registered_event_listener.h
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/core/html/html_marquee_element.cc
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/core/html/plugin_document.cc
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/core/paint/block_painter_test.cc
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/core/paint/pre_paint_tree_walk_test.cc
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/modules/presentation/presentation_receiver_test.cc
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/modules/remoteplayback/remote_playback_test.cc
[modify] https://crrev.com/ca70b72c9b23286a4aab92a7cd95e868e93fc148/third_party/blink/renderer/modules/xr/xr_canvas_input_provider.cc

Project Member

Comment 76 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ed45293563fb49186ca5bd97734353337921de4

commit 8ed45293563fb49186ca5bd97734353337921de4
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Aug 24 12:08:00 2018

DOM: Reduce the size of event.h

event.h is used in 840+ compilation units, and this CL
reduces its pre-processed size by 3.54MB.

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I85f8e58fbcb96c2056536a68ec4777bfa8521f31
Reviewed-on: https://chromium-review.googlesource.com/1188167
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585800}
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/animation/css/css_animations.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/dom/events/custom_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/dom/events/event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/dom/events/event.h
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/dom/range.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/editing/commands/clipboard_commands.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/editing/commands/document_exec_command.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/editing/commands/style_commands.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/editing/commands/typing_command.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/editing/commands/undo_step.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/editing/granularity_strategy.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/editing/ime/input_method_controller.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/editing/spellcheck/hot_mode_spell_check_requester.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/animation_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/animation_playback_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/application_cache_error_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/application_cache_error_event.h
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/before_text_inserted_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/before_unload_event.h
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/drag_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/focus_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/keyboard_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/mouse_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/mouse_event.h
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/page_transition_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/pointer_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/pointer_event_factory.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/pop_state_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/progress_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/promise_rejection_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/resource_progress_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/security_policy_violation_event.h
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/touch_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/touch_event_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/transition_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/visual_viewport_resize_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/visual_viewport_scroll_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/events/wheel_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/exported/web_frame_serializer.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/exported/web_page_popup_impl.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/exported/web_remote_frame_impl.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/frame/mhtml_loading_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/frame/visual_viewport.h
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/html/forms/html_select_element.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/html/html_dialog_element.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/html/html_element.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/html/image_document_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/input/gesture_manager.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/input/keyboard_event_manager.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/input/mouse_event_manager.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/input/mouse_wheel_event_manager.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/input/pointer_event_manager.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/input/scroll_manager.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/input/scroll_snap_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/input/touch_event_manager.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/inspector/thread_debugger.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/mojo/test/mojo_interface_request_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/mojo/test/mojo_interface_request_event.h
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/page/chrome_client_impl.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/page/drag_controller.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/page/scrolling/scroll_into_view_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/core/timing/event_timing.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/app_banner/app_banner_controller.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/geolocation/geoposition.h
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/payments/payment_request.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/peerconnection/rtc_dtmf_tone_change_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_ice_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/sensor/sensor.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/speech/speech_recognition_error.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/speech/speech_recognition_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/wake_lock/screen_wake_lock_test.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/webaudio/audio_processing_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/webaudio/offline_audio_completion_event.cc
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/webmidi/midi_message_event.h
[modify] https://crrev.com/8ed45293563fb49186ca5bd97734353337921de4/third_party/blink/renderer/modules/webusb/usb.cc

Project Member

Comment 78 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47213728bc1e40d9cd30579122f901f340fe8445

commit 47213728bc1e40d9cd30579122f901f340fe8445
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Aug 28 04:05:40 2018

DOM: Reduce the size of window_event_context.h

This CL reduces the pre-processed size of window_event_context.h by
3.63MB.

Bug: 242216
Change-Id: I7a93ad794d7adf10b5f67291e41bf550703440e5
Reviewed-on: https://chromium-review.googlesource.com/1189308
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586575}
[modify] https://crrev.com/47213728bc1e40d9cd30579122f901f340fe8445/third_party/blink/renderer/core/dom/events/tree_scope_event_context.cc
[modify] https://crrev.com/47213728bc1e40d9cd30579122f901f340fe8445/third_party/blink/renderer/core/dom/events/window_event_context.h

Project Member

Comment 79 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c0f2dd7e749214e1cf96de4ba9c353005f26967

commit 8c0f2dd7e749214e1cf96de4ba9c353005f26967
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Sep 11 23:15:00 2018

Reduce the size of execution_context.h.

It is used in 4,300+ compilation units.
http://crrev.com/590155 increased its pre-processed size by 3.72MB, and
this CL fixes it.

Bug: 242216, 881537, 882997
Change-Id: If723b9d77dbd06fdde184498aa6ed7aa3e5e88e2
Reviewed-on: https://chromium-review.googlesource.com/1218388
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590526}
[modify] https://crrev.com/8c0f2dd7e749214e1cf96de4ba9c353005f26967/third_party/blink/renderer/core/execution_context/execution_context.h
[modify] https://crrev.com/8c0f2dd7e749214e1cf96de4ba9c353005f26967/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.cc

Project Member

Comment 80 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecf8cccd83987710b0e97a0741a473661e9d826e

commit ecf8cccd83987710b0e97a0741a473661e9d826e
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Sep 12 02:13:43 2018

Oilpan: handle.h doesn't provide Persistent-related stuff.

This CL reduces the pre-processed size of handle.h by 10%.

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic8a9d1c83e2cbc6eba1573eb47667a7eca8973b6
Reviewed-on: https://chromium-review.googlesource.com/1219526
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590574}
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/public/platform/web_private_ptr.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/build/scripts/templates/ProbeSink.h.tmpl
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/animation/animatable/animatable_filter_operations.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/animation/css_default_interpolation_type.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/animation/css_var_cycle_interpolation_type.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/css/active_style_sheets.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/css/css_custom_font_data.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/css/css_path_value.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/css/css_property_value_set.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/css/document_style_environment_variables.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/dom/abort_signal.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/dom/dom_node_ids.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/dom/events/scoped_event_queue.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/dom/increment_load_event_delay_count.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/dom/tree_ordered_map.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/editing/markers/grammar_marker_list_impl_test.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/editing/markers/spelling_marker_list_impl_test.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/editing/markers/suggestion_marker_list_impl_test.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/editing/markers/unsorted_document_marker_list_editor_test.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/events/registered_event_listener.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/exported/web_associated_url_loader_impl.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/exported/web_page_popup_impl.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/fetch/bytes_consumer.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/fetch/bytes_consumer_for_data_consumer_handle.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/fetch/bytes_consumer_test_util.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/fileapi/file_reader_loader.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/fileapi/public_url_manager_test.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/frame/find_in_page.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/frame/use_counter.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/html/custom/custom_element_reaction_queue_test.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_dispatcher.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_run_queue.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/html/custom/v0_custom_element_observer.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/html/custom/v0_custom_element_processing_stack.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/html/forms/file_chooser.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/layout/custom/pending_layout_registry.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/layout/ng/inline/ng_offset_mapping.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/loader/interactive_detector.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/page/page.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/scroll/scrollbar_layer_delegate.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/style/fill_layer.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/style/nine_piece_image.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/style/reference_clip_path_operation.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/style/style_inherited_variables.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/style/style_non_inherited_variables.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/workers/main_thread_worklet_reporting_proxy.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/workers/threaded_object_proxy_base.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/workers/threaded_worklet_object_proxy.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/core/xml/xpath_value.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/accessibility/ax_object.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/audio_output_devices/set_sink_id_callbacks.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/eventsource/event_source_parser_test.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/mediasource/media_source_registry.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/mediastream/media_stream_registry.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/notifications/notification_resources_loader.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/presentation/presentation_connection_callbacks.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/push_messaging/push_subscription_callbacks.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/remoteplayback/availability_callback_wrapper.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/screen_orientation/lock_orientation_callback.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/service_worker/service_worker_window_client_callback.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/webaudio/convolver_node.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/webaudio/script_processor_node.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/webdatabase/database_manager.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/webdatabase/database_tracker.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/webdatabase/sql_transaction_coordinator.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/modules/webdatabase/sqlite/sqlite_database.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/bindings/v8_per_context_data.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/bindings/v8_per_isolate_data.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/fonts/font_cache.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/fonts/font_fallback_list.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/graphics/image.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/heap/BlinkGCAPIReference.md
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/heap/handle.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/heap/heap_allocator.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/heap/heap_compact_test.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/heap/incremental_marking_test.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/heap/persistent.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/heap/persistent_node.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/heap/thread_state.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/instrumentation/tracing/memory_cache_dump_provider.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/lifecycle_context_test.cc
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/ecf8cccd83987710b0e97a0741a473661e9d826e/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler_test.cc

Project Member

Comment 81 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da12ad84505aae717967f5a6c97c6b5003654e48

commit da12ad84505aae717967f5a6c97c6b5003654e48
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Sep 12 09:09:12 2018

Reduce the size of local_frame_view.h

This CL reduces the pre-processed size of local_frame_view.h by 1.01MB.

* Change jank_tracker_ from an in-place data member to
  std::unique_ptr<>. This change reduces the size by 800KB+.


Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0aebabdde355fb071e3debe5cd628e929033727c
Reviewed-on: https://chromium-review.googlesource.com/1220867
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590625}
[modify] https://crrev.com/da12ad84505aae717967f5a6c97c6b5003654e48/third_party/blink/renderer/core/dom/range_test.cc
[modify] https://crrev.com/da12ad84505aae717967f5a6c97c6b5003654e48/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/da12ad84505aae717967f5a6c97c6b5003654e48/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/da12ad84505aae717967f5a6c97c6b5003654e48/third_party/blink/renderer/core/layout/jank_tracker.h
[modify] https://crrev.com/da12ad84505aae717967f5a6c97c6b5003654e48/third_party/blink/renderer/core/page/page_widget_delegate.cc
[modify] https://crrev.com/da12ad84505aae717967f5a6c97c6b5003654e48/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/da12ad84505aae717967f5a6c97c6b5003654e48/third_party/blink/renderer/core/paint/pre_paint_tree_walk.cc
[modify] https://crrev.com/da12ad84505aae717967f5a6c97c6b5003654e48/third_party/blink/renderer/core/svg/graphics/svg_image_test.cc

Project Member

Comment 82 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/097ff16e877dcfbd2a9f111be01220953bbf98cc

commit 097ff16e877dcfbd2a9f111be01220953bbf98cc
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Sep 13 03:14:18 2018

Move blink::Resource::Type out from blink::Resource, as blink::ResoureType.

This CL makes it possible to forward-declare ResourceType, and we can reduce
header sizes by avoiding #include "resource.h".

- Remove kLastResourceType, which is unused now.

- Rename ResourceType in frame_fetch_context.cc to MainResourceType.

- InspectorPageAgent::ResourceType has the same name as new ResourceType. We
  specify the new one as "blink::ResourceType" only in inspector_page_agent.cc

This CL reduces pre-processed header sizes of some popular headers
significantly.  For example:
- content_security_policy.h: -0.58MB
- layout_object.h: -0.55MB

Bug: 242216
Change-Id: I30771361ce7788e4c88c73f670f0f8fc87b3a08e
Reviewed-on: https://chromium-review.googlesource.com/1214980
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590907}
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/frame/ad_tracker.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/frame/ad_tracker.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/frame/ad_tracker_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/frame/csp/content_security_policy.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/frame/csp/content_security_policy.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/frame/csp/content_security_policy_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/frame/csp/csp_directive_list.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/html/parser/css_preload_scanner.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/html/parser/html_preload_scanner.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/html/parser/html_preload_scanner_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/html/parser/html_resource_preloader_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/html/parser/preload_request.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/html/parser/preload_request.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/inspector/inspector_emulation_agent.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/inspector/inspector_network_agent.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/inspector/inspector_page_agent.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/inspector/inspector_page_agent.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/inspector/inspector_trace_events.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/link_loader.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/css_style_sheet_resource.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/css_style_sheet_resource.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/document_resource.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/document_resource.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/font_resource.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/font_resource.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/image_resource.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/link_fetch_resource.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/link_fetch_resource.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/text_resource.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/text_resource.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/xsl_style_sheet_resource.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/resource/xsl_style_sheet_resource.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/worker_fetch_context.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/loader/worker_fetch_context.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/probe/CoreProbes.pidl
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/script/script_loader.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/core/testing/null_execution_context.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/modules/service_worker/wait_until_observer.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/cors/cors.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/cors/cors_error_string.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/memory_cache.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/memory_cache_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/preload_key.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/raw_resource.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/raw_resource.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/raw_resource_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/subresource_integrity_test.cc
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
[modify] https://crrev.com/097ff16e877dcfbd2a9f111be01220953bbf98cc/third_party/blink/renderer/platform/loader/testing/mock_resource.cc

Project Member

Comment 83 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2611fc593999fcc5a7844c07a0812dbefbfe4874

commit 2611fc593999fcc5a7844c07a0812dbefbfe4874
Author: Daniel Bratell <bratell@opera.com>
Date: Thu Sep 13 11:48:37 2018

[jumbo] A global enum ResourceType appeared so rename a local one

In https://chromium-review.googlesource.com/1214980 a more visible
blink::ResourceType was introduced and when jumbo compiling that
will clash with a local one inse canvas_resource_provider.cc.

This renames that enum to CanvasResourceType just to avoid the clash.

TBR=tkent@chromium.org

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I71a9a306f7763728ae6800c78be225fd1e965bb9
Reviewed-on: https://chromium-review.googlesource.com/1224012
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#590973}
[modify] https://crrev.com/2611fc593999fcc5a7844c07a0812dbefbfe4874/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc

Project Member

Comment 84 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6e6875823fb306e08baf8af3deb246b3c88ee9e

commit c6e6875823fb306e08baf8af3deb246b3c88ee9e
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Sep 18 08:48:14 2018

Reduce the size of local_frame_view.h

local_frame_view.h is used in 1,500+ compilation units, and
crrev.com/591100 increased its pre-processed size by 3.57MB.  This CL
fixes it.

Bug: 242216, 869924
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3dd48467d027f56655bb796984756ee7c25f86cd
Reviewed-on: https://chromium-review.googlesource.com/1229873
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591976}
[modify] https://crrev.com/c6e6875823fb306e08baf8af3deb246b3c88ee9e/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/c6e6875823fb306e08baf8af3deb246b3c88ee9e/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/c6e6875823fb306e08baf8af3deb246b3c88ee9e/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/c6e6875823fb306e08baf8af3deb246b3c88ee9e/third_party/blink/renderer/core/paint/pre_paint_tree_walk.cc

Project Member

Comment 85 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8508e938be1c1d862882be46400cd2b829fb24dd

commit 8508e938be1c1d862882be46400cd2b829fb24dd
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Sep 18 09:03:59 2018

Reduce the size of frame_loader.h.

frame_loader.h is used in 1,500+ compilation units, and this CL reduces
its pre-processed size by 1.85MB.

Bug: 242216
Change-Id: Iebe8791e0661f8bce25865fb5f396f03c344322d
Reviewed-on: https://chromium-review.googlesource.com/1229723
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591982}
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/core/frame/device_single_window_event_controller.cc
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/core/inspector/inspected_frames.cc
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/core/inspector/inspector_network_agent.h
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/core/loader/frame_loader.h
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump.cc
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/modules/navigatorcontentutils/navigator_content_utils.cc
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/modules/nfc/nfc.cc
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/modules/sensor/sensor_proxy.cc
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/modules/storage/dom_window_storage.cc
[modify] https://crrev.com/8508e938be1c1d862882be46400cd2b829fb24dd/third_party/blink/renderer/modules/storage/storage_area.cc

Project Member

Comment 86 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a166dc7af6b5867b4ba9804c8dd3874b9f4970dc

commit a166dc7af6b5867b4ba9804c8dd3874b9f4970dc
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Oct 02 08:11:56 2018

Reduce the size of security_context.h

security_context.h is used in 2,700+ compilation units. crrev.com/594074
increased its pre-processed size by 1.32MB, and this CL fixes it.

Bug: 242216, 888668
Change-Id: I623ad22e5351328f934a0b1cd7caece6b4b07944
Reviewed-on: https://chromium-review.googlesource.com/1256470
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595757}
[modify] https://crrev.com/a166dc7af6b5867b4ba9804c8dd3874b9f4970dc/third_party/blink/renderer/core/execution_context/security_context.h

Project Member

Comment 87 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30fe2105ff384d8485ab2da6bc0be124dcb4c44f

commit 30fe2105ff384d8485ab2da6bc0be124dcb4c44f
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Oct 17 19:36:48 2018

Remove useless includes from wtf_string.h

BUG=242216

Change-Id: Iea525e5c1091aa85193b23edbedead8bf997ab05
Reviewed-on: https://chromium-review.googlesource.com/c/1286907
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600520}
[modify] https://crrev.com/30fe2105ff384d8485ab2da6bc0be124dcb4c44f/third_party/blink/renderer/platform/wtf/text/wtf_string.h

Project Member

Comment 88 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d06dcf65745e469d1222e78499778d22bfbab1b9

commit d06dcf65745e469d1222e78499778d22bfbab1b9
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Oct 18 14:12:57 2018

Remove include from runtime_enabled_features template

BUG=242216

Change-Id: I6f897509727b026b9d1f17227b0621b30821cc56
Reviewed-on: https://chromium-review.googlesource.com/c/1286937
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600754}
[modify] https://crrev.com/d06dcf65745e469d1222e78499778d22bfbab1b9/third_party/blink/renderer/build/scripts/templates/runtime_enabled_features.h.tmpl

Project Member

Comment 89 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11faee22e4c7008afa9e40e23643b0c941d13680

commit 11faee22e4c7008afa9e40e23643b0c941d13680
Author: Fredrik Söderquist <fs@opera.com>
Date: Fri Jan 11 13:48:52 2019

Stop including node_computed_style.h in element_resolve_context.h

78cf9afa7b11d20e90bbe4838970ae13778a0f3c added this include, as well as
an 'inline' keyword on the declaration of the methods in it.
Undo this to avoid ballooning the files downstream of
element_resolve_context.h.

Fix the fallout which is all due to missing includes of
platform/wtf/functional.h.

Bug: 242216

Change-Id: Iae7d8aa96c043e76a12d3fb76972730e70113c8c
Reviewed-on: https://chromium-review.googlesource.com/c/1406247
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#621988}
[modify] https://crrev.com/11faee22e4c7008afa9e40e23643b0c941d13680/third_party/blink/renderer/core/animation/css_custom_list_interpolation_type.cc
[modify] https://crrev.com/11faee22e4c7008afa9e40e23643b0c941d13680/third_party/blink/renderer/core/animation/css_image_list_interpolation_type.cc
[modify] https://crrev.com/11faee22e4c7008afa9e40e23643b0c941d13680/third_party/blink/renderer/core/animation/css_length_list_interpolation_type.cc
[modify] https://crrev.com/11faee22e4c7008afa9e40e23643b0c941d13680/third_party/blink/renderer/core/animation/css_shadow_list_interpolation_type.cc
[modify] https://crrev.com/11faee22e4c7008afa9e40e23643b0c941d13680/third_party/blink/renderer/core/animation/css_size_list_interpolation_type.cc
[modify] https://crrev.com/11faee22e4c7008afa9e40e23643b0c941d13680/third_party/blink/renderer/core/animation/list_interpolation_functions_test.cc
[modify] https://crrev.com/11faee22e4c7008afa9e40e23643b0c941d13680/third_party/blink/renderer/core/css/resolver/element_resolve_context.h
[modify] https://crrev.com/11faee22e4c7008afa9e40e23643b0c941d13680/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/11faee22e4c7008afa9e40e23643b0c941d13680/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/11faee22e4c7008afa9e40e23643b0c941d13680/third_party/blink/renderer/core/html/html_style_element.cc

Project Member

Comment 90 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2f937a18e0c1c4c2559ee171ce7178090984fd8

commit d2f937a18e0c1c4c2559ee171ce7178090984fd8
Author: Fredrik Söderquist <fs@opera.com>
Date: Fri Jan 11 16:45:00 2019

Remove some includes of console_message.h in central headers

Remove the (unneeded) includes of console_message.h from
core/dom/document.h and core/execution_context/security_context.h.

This should for instance avoids indirectly including dom_node_ids.h
more than needed.

This will hopefully improve compilation speed a little bit, for
some people.

Bug: 242216
Change-Id: I775478624933833981c0f9ccd28e82e1bf815e00
Reviewed-on: https://chromium-review.googlesource.com/c/1406974
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#622027}
[modify] https://crrev.com/d2f937a18e0c1c4c2559ee171ce7178090984fd8/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/d2f937a18e0c1c4c2559ee171ce7178090984fd8/third_party/blink/renderer/core/execution_context/security_context.h
[modify] https://crrev.com/d2f937a18e0c1c4c2559ee171ce7178090984fd8/third_party/blink/renderer/core/html/forms/listed_element.cc
[modify] https://crrev.com/d2f937a18e0c1c4c2559ee171ce7178090984fd8/third_party/blink/renderer/core/timing/performance_observer.cc

Project Member

Comment 91 by bugdroid1@chromium.org, Jan 14 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b32f46e421683240c8cede7069940cc909c2145

commit 2b32f46e421683240c8cede7069940cc909c2145
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Jan 14 17:12:36 2019

Reduce the size of execution_context.h

execution_context.h is used in 4400+ compilation units. This reduces
its pre-processed size by ~1.1M.

The referrer_policy.mojom-shared.h include was added by
https://crrev.com/611587.

Bug: 242216, 860403
Change-Id: I5cdcbf17f05a6b121672f7fa9263f098a6450ee5
Reviewed-on: https://chromium-review.googlesource.com/c/1408970
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#622488}
[modify] https://crrev.com/2b32f46e421683240c8cede7069940cc909c2145/third_party/blink/renderer/core/execution_context/execution_context.h

Sign in to add a comment