New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 239656 link

Starred by 11 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

Refactor NaCl integration to eliminate the trusted, in-process plugin.

Project Member Reported by dmichael@chromium.org, May 9 2013

Issue description

Refactor NaCl integration to eliminate the trusted, in-process plugin.

See the design document here for more information: https://docs.google.com/a/google.com/document/d/1EMzz5ZgreHLzrsytZikr8UT6KpriAUr_wR6CSxnSkvA/edit
 
Showing comments 63 - 162 of 162 Older
Project Member

Comment 63 by bugdroid1@chromium.org, May 6 2014

------------------------------------------------------------------
r268578 | teravest@chromium.org | 2014-05-06T19:20:06.565325Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/file_utils.cc?r1=268578&r2=268577&pathrev=268578
   D http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/file_utils.h?r1=268578&r2=268577&pathrev=268578
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.gypi?r1=268578&r2=268577&pathrev=268578
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=268578&r2=268577&pathrev=268578
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=268578&r2=268577&pathrev=268578
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_resources.cc?r1=268578&r2=268577&pathrev=268578
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_resources.h?r1=268578&r2=268577&pathrev=268578
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=268578&r2=268577&pathrev=268578
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=268578&r2=268577&pathrev=268578

Pepper: Remove file_utils from trusted plugin.

This change moves some file reading and JSON parsing for pnacl resource info
outside the trusted plugin. This allows us to remove file_utils entirely from
the trusted plugin.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/261143002
-----------------------------------------------------------------
Project Member

Comment 64 by bugdroid1@chromium.org, May 10 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48fed1cf88260ead7236c047a75ec84c66f79578

commit 48fed1cf88260ead7236c047a75ec84c66f79578
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat May 10 02:01:28 2014

Pepper: Move DoPostMessage out of trusted plugin.

This is the first effort at moving some of the ReverseService logic out of the
trusted plugin. I'd like to move these over soon since the tangled callback is
pretty nasty, and hidehiko@ has run into the ugliness while adding features for
Bare Metal Mode.

This one is pretty easy since it's stateless.

BUG=239656

Review URL: https://codereview.chromium.org/268793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269480 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 65 by bugdroid1@chromium.org, May 10 2014

------------------------------------------------------------------
r269480 | teravest@chromium.org | 2014-05-10T02:01:28.160883Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=269480&r2=269479&pathrev=269480
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.h?r1=269480&r2=269479&pathrev=269480
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=269480&r2=269479&pathrev=269480
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=269480&r2=269479&pathrev=269480
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/pepper/pepper_plugin_instance_impl.cc?r1=269480&r2=269479&pathrev=269480
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/pepper/pepper_plugin_instance_impl.h?r1=269480&r2=269479&pathrev=269480
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/pepper_plugin_instance.h?r1=269480&r2=269479&pathrev=269480
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/pepper/fake_pepper_plugin_instance.cc?r1=269480&r2=269479&pathrev=269480
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=269480&r2=269479&pathrev=269480
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=269480&r2=269479&pathrev=269480
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/pepper/fake_pepper_plugin_instance.h?r1=269480&r2=269479&pathrev=269480

Pepper: Move DoPostMessage out of trusted plugin.

This is the first effort at moving some of the ReverseService logic out of the
trusted plugin. I'd like to move these over soon since the tangled callback is
pretty nasty, and hidehiko@ has run into the ugliness while adding features for
Bare Metal Mode.

This one is pretty easy since it's stateless.

BUG=239656

Review URL: https://codereview.chromium.org/268793002
-----------------------------------------------------------------
Project Member

Comment 66 by bugdroid1@chromium.org, May 13 2014

------------------------------------------------------------------
r269962 | teravest@chromium.org | 2014-05-13T01:49:38.914590Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=269962&r2=269961&pathrev=269962
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.h?r1=269962&r2=269961&pathrev=269962

Pepper: Remove unnecessary CloseManifestEntry code.

There's some logic in ServiceRuntime to support a future implementation for
CloseManifestEntry, but since we don't take any useful action, it's much
simpler to always return true. This makes ServiceRuntime even smaller.

This also removes an unused struct in ServiceRuntime.

BUG=239656

Review URL: https://codereview.chromium.org/280613002
-----------------------------------------------------------------
Project Member

Comment 67 by bugdroid1@chromium.org, May 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec38b18a1a93f1c90b6f0ce881b07726d4f8f076

commit ec38b18a1a93f1c90b6f0ce881b07726d4f8f076
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue May 13 01:49:38 2014

Pepper: Remove unnecessary CloseManifestEntry code.

There's some logic in ServiceRuntime to support a future implementation for
CloseManifestEntry, but since we don't take any useful action, it's much
simpler to always return true. This makes ServiceRuntime even smaller.

This also removes an unused struct in ServiceRuntime.

BUG=239656

Review URL: https://codereview.chromium.org/280613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269962 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 68 by bugdroid1@chromium.org, May 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2ce39ba8c17d53dd587d0f40cadfe361b7ce6ca

commit e2ce39ba8c17d53dd587d0f40cadfe361b7ce6ca
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue May 13 04:14:05 2014

Pepper: Miscellaneous trusted plugin cleanup.

This does some small cleanup of a bunch of little things without any logic
changes.

BUG=239656

Review URL: https://codereview.chromium.org/270863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270010 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 70 by bugdroid1@chromium.org, May 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08eaa53a13d75d1d0a3f3f200207894ad3d84d50

commit 08eaa53a13d75d1d0a3f3f200207894ad3d84d50
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue May 13 17:47:07 2014

Pepper: Simplify LaunchSelLdr error reporting.

This moves error reporting for LaunchSelLdr out of the trusted plugin, removing
the need for a callback in ServiceRuntime to unpack the error string and report
it.

This is part of a larger effort to move all code out of the trusted plugin.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/282683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270140 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 71 by bugdroid1@chromium.org, May 13 2014

------------------------------------------------------------------
r270140 | teravest@chromium.org | 2014-05-13T17:47:07.344178Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/nexe_load_manager.h?r1=270140&r2=270139&pathrev=270140
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin_error.h?r1=270140&r2=270139&pathrev=270140
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=270140&r2=270139&pathrev=270140
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=270140&r2=270139&pathrev=270140
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/nacl_entry_points.h?r1=270140&r2=270139&pathrev=270140
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc?r1=270140&r2=270139&pathrev=270140
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=270140&r2=270139&pathrev=270140
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=270140&r2=270139&pathrev=270140
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h?r1=270140&r2=270139&pathrev=270140
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=270140&r2=270139&pathrev=270140
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.h?r1=270140&r2=270139&pathrev=270140

Pepper: Simplify LaunchSelLdr error reporting.

This moves error reporting for LaunchSelLdr out of the trusted plugin, removing
the need for a callback in ServiceRuntime to unpack the error string and report
it.

This is part of a larger effort to move all code out of the trusted plugin.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/282683002
-----------------------------------------------------------------
Project Member

Comment 72 by bugdroid1@chromium.org, May 16 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63c146773649fd120b69d3b5de979c9a23e5ce33

commit 63c146773649fd120b69d3b5de979c9a23e5ce33
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri May 16 01:22:19 2014

Pepper: Simplify manifest download logic.

This cleans up some of the trusted plugin logic for requesting a NaCl manifest
and removes some interfaces in PPB_NaCl_Private, providing better
encapsulation.

This code is easier to follow after this change, as well, since more of the
logic is unified in ppb_nacl_private_impl.cc. This is part of a larger effort
to remove the trusted plugin.

BUG=239656

Review URL: https://codereview.chromium.org/288773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270887 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 73 by bugdroid1@chromium.org, May 16 2014

------------------------------------------------------------------
r270887 | teravest@chromium.org | 2014-05-16T01:22:19.944838Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=270887&r2=270886&pathrev=270887
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/nexe_load_manager.cc?r1=270887&r2=270886&pathrev=270887
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=270887&r2=270886&pathrev=270887
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/nexe_load_manager.h?r1=270887&r2=270886&pathrev=270887
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=270887&r2=270886&pathrev=270887
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=270887&r2=270886&pathrev=270887
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.cc?r1=270887&r2=270886&pathrev=270887
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/manifest_downloader.cc?r1=270887&r2=270886&pathrev=270887
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/manifest_downloader.h?r1=270887&r2=270886&pathrev=270887

Pepper: Simplify manifest download logic.

This cleans up some of the trusted plugin logic for requesting a NaCl manifest
and removes some interfaces in PPB_NaCl_Private, providing better
encapsulation.

This code is easier to follow after this change, as well, since more of the
logic is unified in ppb_nacl_private_impl.cc. This is part of a larger effort
to remove the trusted plugin.

BUG=239656

Review URL: https://codereview.chromium.org/288773002
-----------------------------------------------------------------
Project Member

Comment 74 by bugdroid1@chromium.org, May 20 2014

Project Member

Comment 75 by bugdroid1@chromium.org, May 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f154c2deb5c4ab1010fb5ed85c6b05f56841139

commit 4f154c2deb5c4ab1010fb5ed85c6b05f56841139
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue May 20 18:44:14 2014

Pepper: Manifest refactoring in trusted plugin.

This lifts more manifest processing code out of the trusted plugin.
Specifically, instead of the trusted plugin receiving a PP_Var with the contents
of the manifest and making another method to create the manifest id, the
trusted plugin now simply receives the manifest ID directly.

BUG=239656

Review URL: https://codereview.chromium.org/287153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271719 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 76 by bugdroid1@chromium.org, May 21 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d28e0c3facbec17f162ecaea0dbe0ded982e1f8

commit 7d28e0c3facbec17f162ecaea0dbe0ded982e1f8
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed May 21 19:21:29 2014

Pepper: Remove url_info_map from trusted plugin.

This appears to be a vestigal part of some StreamAsFile() operation that no
longer exists. It's not necessary to cache this file info in the plugin, as we
only ever return it once.

I've split this off from a bigger StreamAsFile() refactoring to make the diff
smaller, to help debug Windows failures on that patch.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/297763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271940 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 77 by bugdroid1@chromium.org, May 21 2014

------------------------------------------------------------------
r271940 | teravest@chromium.org | 2014-05-21T19:21:29.184577Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=271940&r2=271939&pathrev=271940
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.cc?r1=271940&r2=271939&pathrev=271940
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h?r1=271940&r2=271939&pathrev=271940

Pepper: Remove url_info_map from trusted plugin.

This appears to be a vestigal part of some StreamAsFile() operation that no
longer exists. It's not necessary to cache this file info in the plugin, as we
only ever return it once.

I've split this off from a bigger StreamAsFile() refactoring to make the diff
smaller, to help debug Windows failures on that patch.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/297763002
-----------------------------------------------------------------
Project Member

Comment 78 by bugdroid1@chromium.org, May 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0834db611c7fe73b896dc9f415bf9223890fa9e

commit e0834db611c7fe73b896dc9f415bf9223890fa9e
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu May 22 14:02:25 2014

Pepper: Remove jsoncpp from trusted plugin.

Now that manifest parsing has been moved to components/nacl, the trusted plugin
no longer depends on jsoncpp.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/291173007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272174 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 79 by bugdroid1@chromium.org, May 22 2014

------------------------------------------------------------------
r272174 | teravest@chromium.org | 2014-05-22T14:02:25.179106Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/DEPS?r1=272174&r2=272173&pathrev=272174
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_resources.cc?r1=272174&r2=272173&pathrev=272174
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.gyp?r1=272174&r2=272173&pathrev=272174

Pepper: Remove jsoncpp from trusted plugin.

Now that manifest parsing has been moved to components/nacl, the trusted plugin
no longer depends on jsoncpp.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/291173007
-----------------------------------------------------------------
Project Member

Comment 80 by bugdroid1@chromium.org, May 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f2ce3f74685a9a5926af9c452c0057f5a9a4be9

commit 6f2ce3f74685a9a5926af9c452c0057f5a9a4be9
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu May 22 17:13:58 2014

Pepper: Remove Quota management from TempFile.

TempFile quota management only serves to limit the write limits of the llc and
ld processes when translating PNaCl pexe files. There are many other ways to
fill the disk, so this doesn't serve much purpose, and the code will be simpler
to understand without it.

I hope to remove MakeFileDescQuota() from native_client after making that
change, and removing the implementation, including the necessary methods in
nacl::ReverseInterface.

BUG=239656
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/290993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272210 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 81 by bugdroid1@chromium.org, May 22 2014

------------------------------------------------------------------
r272210 | teravest@chromium.org | 2014-05-22T17:13:58.466512Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=272210&r2=272209&pathrev=272210
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/temporary_file.h?r1=272210&r2=272209&pathrev=272210
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.h?r1=272210&r2=272209&pathrev=272210
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc?r1=272210&r2=272209&pathrev=272210
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/temporary_file.cc?r1=272210&r2=272209&pathrev=272210

Pepper: Remove Quota management from TempFile.

TempFile quota management only serves to limit the write limits of the llc and
ld processes when translating PNaCl pexe files. There are many other ways to
fill the disk, so this doesn't serve much purpose, and the code will be simpler
to understand without it.

I hope to remove MakeFileDescQuota() from native_client after making that
change, and removing the implementation, including the necessary methods in
nacl::ReverseInterface.

BUG=239656
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/290993006
-----------------------------------------------------------------
Project Member

Comment 82 by bugdroid1@chromium.org, May 23 2014

Project Member

Comment 83 by bugdroid1@chromium.org, May 23 2014

------------------------------------------------------------------
r272593 | teravest@chromium.org | 2014-05-23T21:24:13.898350Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/file_downloader.cc?r1=272593&r2=272592&pathrev=272593
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/file_downloader.h?r1=272593&r2=272592&pathrev=272593

Pepper: FileDownloader cleanup.

Now that StreamAsFile() has moved out of the trusted plugin, we can remove the
support in FileDownloader for downloading to a file and providing file
information as output.

This makes FileDownloader quite a bit smaller and easier to read.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/292323007
-----------------------------------------------------------------
Project Member

Comment 84 by bugdroid1@chromium.org, May 27 2014

------------------------------------------------------------------
r273034 | teravest@chromium.org | 2014-05-27T21:19:56.657097Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h?r1=273034&r2=273033&pathrev=273034
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=273034&r2=273033&pathrev=273034
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.cc?r1=273034&r2=273033&pathrev=273034

Pepper: Remove Plugin::StreamAsFile.

This method isn't necessary any longer. This is a small change to clean up more
of the OpenManifestEntry logic and move it out of the trusted plugin.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/296403010
-----------------------------------------------------------------
Project Member

Comment 85 by bugdroid1@chromium.org, May 27 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6cbfe881c4fb3dbc6f3ccc45429b7f94530b571

commit d6cbfe881c4fb3dbc6f3ccc45429b7f94530b571
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue May 27 21:19:56 2014

Pepper: Remove Plugin::StreamAsFile.

This method isn't necessary any longer. This is a small change to clean up more
of the OpenManifestEntry logic and move it out of the trusted plugin.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/296403010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273034 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 86 by bugdroid1@chromium.org, May 28 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26bfc62c007622310431230d31a07bdcd87852f6

commit 26bfc62c007622310431230d31a07bdcd87852f6
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed May 28 13:58:48 2014

Pepper: PnaclResources cleanup.

This simplifies some code in PnaclResources a bit in anticipation of moving
more code out of the trusted plugin.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/301743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273210 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 87 by bugdroid1@chromium.org, May 28 2014

------------------------------------------------------------------
r273210 | teravest@chromium.org | 2014-05-28T13:58:48.412887Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=273210&r2=273209&pathrev=273210
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_resources.cc?r1=273210&r2=273209&pathrev=273210
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_resources.h?r1=273210&r2=273209&pathrev=273210

Pepper: PnaclResources cleanup.

This simplifies some code in PnaclResources a bit in anticipation of moving
more code out of the trusted plugin.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/301743003
-----------------------------------------------------------------
Project Member

Comment 88 by bugdroid1@chromium.org, May 29 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ccac3ba006f02cb5706661d69bafea3f7a5e2d6

commit 5ccac3ba006f02cb5706661d69bafea3f7a5e2d6
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu May 29 00:22:28 2014

Pepper: FileDownloader cleanup.

More cleaning up of unused code in FileDownloader.

BUG=239656

Review URL: https://codereview.chromium.org/293403008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273417 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 90 by bugdroid1@chromium.org, May 29 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/604ba5a5b167f2001767a21ba6e5c5f1cc520635

commit 604ba5a5b167f2001767a21ba6e5c5f1cc520635
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu May 29 19:10:42 2014

Pepper: Manifest ID cleanup.

This removes a bunch of code for managing manifest IDs. Any given instance can
only have one "Json Manifest", as parsed from user-supplied NMF data. Helper
processes (llc and ld) have no corresponding NMF, but do make IRT
open_resource() calls, which eventually manifest in a call to
ManifestResolveKey.

This code should be quite a bit easier to read now, and makes the relationship
between manifest data and instances clearer.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/301013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273535 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 91 by bugdroid1@chromium.org, May 29 2014

------------------------------------------------------------------
r273535 | teravest@chromium.org | 2014-05-29T19:10:42.915396Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=273535&r2=273534&pathrev=273535
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=273535&r2=273534&pathrev=273535
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=273535&r2=273534&pathrev=273535
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.h?r1=273535&r2=273534&pathrev=273535
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=273535&r2=273534&pathrev=273535
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=273535&r2=273534&pathrev=273535
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.cc?r1=273535&r2=273534&pathrev=273535
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h?r1=273535&r2=273534&pathrev=273535

Pepper: Manifest ID cleanup.

This removes a bunch of code for managing manifest IDs. Any given instance can
only have one "Json Manifest", as parsed from user-supplied NMF data. Helper
processes (llc and ld) have no corresponding NMF, but do make IRT
open_resource() calls, which eventually manifest in a call to
ManifestResolveKey.

This code should be quite a bit easier to read now, and makes the relationship
between manifest data and instances clearer.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/301013002
-----------------------------------------------------------------
Project Member

Comment 92 by bugdroid1@chromium.org, Jun 2 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/292305e95a0313ed2675b055d6cb465095587e10

commit 292305e95a0313ed2675b055d6cb465095587e10
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Jun 02 14:31:47 2014

Pepper: Refactor PNaCl OpenManifestEntry logic.

This change moves some more OpenManifestEntry logic out of the trusted plugin.
This code specifically looks up file descriptors for support files for helper
processes (llc, ld) for the PNaCl translator.

BUG=239656

Review URL: https://codereview.chromium.org/307933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274233 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 93 by bugdroid1@chromium.org, Jun 2 2014

Project Member

Comment 94 by bugdroid1@chromium.org, Jun 3 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/007a844d0b6741f9382d22b3a5a238420de86560

commit 007a844d0b6741f9382d22b3a5a238420de86560
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 03 15:02:34 2014

Pepper: Refactor OpenManifestEntry.

This change pulls out more OpenManifestEntry code from service_runtime, making
PPB_NaCl_Private a smallter interface, and preparing for pulling all of that
logic out of the trusted plugin.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/302093012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274530 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 96 by bugdroid1@chromium.org, Jun 3 2014

------------------------------------------------------------------
r274588 | teravest@chromium.org | 2014-06-03T19:14:48.512739Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=274588&r2=274587&pathrev=274588
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=274588&r2=274587&pathrev=274588
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=274588&r2=274587&pathrev=274588
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=274588&r2=274587&pathrev=274588
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=274588&r2=274587&pathrev=274588

Revert of Pepper: Refactor OpenManifestEntry. (https://codereview.chromium.org/302093012/)

Reason for revert:
This broke NaClBrowserTestPnaclNonSfi.IrtManifestFile on linux 32. That test will have to pass on the right trybot before landing. I'm not sure why it broke yet.

Original issue's description:
> Pepper: Refactor OpenManifestEntry.
> 
> This change pulls out more OpenManifestEntry code from service_runtime, making
> PPB_NaCl_Private a smallter interface, and preparing for pulling all of that
> logic out of the trusted plugin.
> 
> BUG=239656
> R=dmichael@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274530

TBR=dmichael@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=239656

Review URL: https://codereview.chromium.org/318463002
-----------------------------------------------------------------
Project Member

Comment 97 by bugdroid1@chromium.org, Jun 3 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd3f8a6dfb50d917d62ba6f78f694bc586d40831

commit cd3f8a6dfb50d917d62ba6f78f694bc586d40831
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 03 19:14:48 2014

Revert of Pepper: Refactor OpenManifestEntry. (https://codereview.chromium.org/302093012/)

Reason for revert:
This broke NaClBrowserTestPnaclNonSfi.IrtManifestFile on linux 32. That test will have to pass on the right trybot before landing. I'm not sure why it broke yet.

Original issue's description:
> Pepper: Refactor OpenManifestEntry.
> 
> This change pulls out more OpenManifestEntry code from service_runtime, making
> PPB_NaCl_Private a smallter interface, and preparing for pulling all of that
> logic out of the trusted plugin.
> 
> BUG=239656
> R=dmichael@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274530

TBR=dmichael@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=239656

Review URL: https://codereview.chromium.org/318463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274588 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 98 by bugdroid1@chromium.org, Jun 3 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b158e44a4c18974906b0b9fe7fb96989b115c2c

commit 8b158e44a4c18974906b0b9fe7fb96989b115c2c
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 03 19:57:20 2014

Pepper: Remove Plugin::EnqueueProgressEvent.

This wrapper isn't providing much benefit; we may as well tear it out. This
also removes the LengthComputable enum.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/316653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274598 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 99 by bugdroid1@chromium.org, Jun 3 2014

------------------------------------------------------------------
r274598 | teravest@chromium.org | 2014-06-03T19:57:20.028014Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.cc?r1=274598&r2=274597&pathrev=274598
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h?r1=274598&r2=274597&pathrev=274598
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=274598&r2=274597&pathrev=274598

Pepper: Remove Plugin::EnqueueProgressEvent.

This wrapper isn't providing much benefit; we may as well tear it out. This
also removes the LengthComputable enum.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/316653002
-----------------------------------------------------------------
Project Member

Comment 100 by bugdroid1@chromium.org, Jun 3 2014

Project Member

Comment 101 by bugdroid1@chromium.org, Jun 3 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0b83a167aaceae84273f270afafbb927191c7ea

commit e0b83a167aaceae84273f270afafbb927191c7ea
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 03 21:02:15 2014

Pepper: Simplify error reporting in PnaclResources.

This change reduces the size of the public API for PnaclCoordinator and
simplifies error reporting inside PnaclResources, making it easier to follow.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/315583005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274621 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 102 by bugdroid1@chromium.org, Jun 4 2014

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/007a844d0b6741f9382d22b3a5a238420de86560

commit 007a844d0b6741f9382d22b3a5a238420de86560
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 03 15:02:34 2014

Project Member

Comment 103 by bugdroid1@chromium.org, Jun 4 2014

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/cd3f8a6dfb50d917d62ba6f78f694bc586d40831

commit cd3f8a6dfb50d917d62ba6f78f694bc586d40831
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 03 19:14:48 2014

Project Member

Comment 104 by bugdroid1@chromium.org, Jun 4 2014

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/8b158e44a4c18974906b0b9fe7fb96989b115c2c

commit 8b158e44a4c18974906b0b9fe7fb96989b115c2c
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 03 19:57:20 2014

Project Member

Comment 105 by bugdroid1@chromium.org, Jun 4 2014

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/e0b83a167aaceae84273f270afafbb927191c7ea

commit e0b83a167aaceae84273f270afafbb927191c7ea
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 03 21:02:15 2014

Project Member

Comment 106 by bugdroid1@chromium.org, Jun 4 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1243f4693811b468dd117b0be8a38ea76855c89b

commit 1243f4693811b468dd117b0be8a38ea76855c89b
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 04 17:46:47 2014

Pepper: Move JsonManifestMap to json_manifest.h

I'd like to break out OpenManifestEntry and some other functions out of
ppb_nacl_private_impl.cc so they're easier to reuse and less tightly-bound to
the PPB_NaCl_Private interface.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/310113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274860 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 107 by bugdroid1@chromium.org, Jun 4 2014

------------------------------------------------------------------
r274860 | teravest@chromium.org | 2014-06-04T17:46:47.580629Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/json_manifest.cc?r1=274860&r2=274859&pathrev=274860
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/json_manifest.h?r1=274860&r2=274859&pathrev=274860
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=274860&r2=274859&pathrev=274860

Pepper: Move JsonManifestMap to json_manifest.h

I'd like to break out OpenManifestEntry and some other functions out of
ppb_nacl_private_impl.cc so they're easier to reuse and less tightly-bound to
the PPB_NaCl_Private interface.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/310113002
-----------------------------------------------------------------
Project Member

Comment 108 by bugdroid1@chromium.org, Jun 4 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1f0c722f5eec45c6bcb210a04bac9db85f15428

commit a1f0c722f5eec45c6bcb210a04bac9db85f15428
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 04 20:29:48 2014

Pepper: Miscellaneous trusted plugin cleanup.

This removes some more unnecessary methods and moves some more UMA reporting
out of the trusted plugin, reducing the total line count.

It's a little awkward that we have to pass the max value of NaClErrorCode to
the new reporting method, but it keeps that enum out of the public NaCl
interface.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/315753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274898 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 109 by bugdroid1@chromium.org, Jun 4 2014

------------------------------------------------------------------
r274898 | teravest@chromium.org | 2014-06-04T20:29:48.136535Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=274898&r2=274897&pathrev=274898
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=274898&r2=274897&pathrev=274898
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=274898&r2=274897&pathrev=274898
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=274898&r2=274897&pathrev=274898
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=274898&r2=274897&pathrev=274898
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.cc?r1=274898&r2=274897&pathrev=274898
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h?r1=274898&r2=274897&pathrev=274898

Pepper: Miscellaneous trusted plugin cleanup.

This removes some more unnecessary methods and moves some more UMA reporting
out of the trusted plugin, reducing the total line count.

It's a little awkward that we have to pass the max value of NaClErrorCode to
the new reporting method, but it keeps that enum out of the public NaCl
interface.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/315753003
-----------------------------------------------------------------
Project Member

Comment 110 by bugdroid1@chromium.org, Jun 5 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1999f8669277869d7373f6e4ed0e3147a27cccc4

commit 1999f8669277869d7373f6e4ed0e3147a27cccc4
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 05 19:40:40 2014

Pepper: Clean up trusted plugin error reporting.

This change cleans up some error reporting and removes some unnecessary and
dead code. Not a very exciting change; just doing more cleanup.

BUG=239656

Review URL: https://codereview.chromium.org/311273007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275220 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 111 by bugdroid1@chromium.org, Jun 5 2014

------------------------------------------------------------------
r275220 | teravest@chromium.org | 2014-06-05T19:40:40.384661Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=275220&r2=275219&pathrev=275220
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=275220&r2=275219&pathrev=275220
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=275220&r2=275219&pathrev=275220
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.h?r1=275220&r2=275219&pathrev=275220
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin_error.h?r1=275220&r2=275219&pathrev=275220
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=275220&r2=275219&pathrev=275220
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=275220&r2=275219&pathrev=275220
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.cc?r1=275220&r2=275219&pathrev=275220
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h?r1=275220&r2=275219&pathrev=275220

Pepper: Clean up trusted plugin error reporting.

This change cleans up some error reporting and removes some unnecessary and
dead code. Not a very exciting change; just doing more cleanup.

BUG=239656

Review URL: https://codereview.chromium.org/311273007
-----------------------------------------------------------------
Project Member

Comment 112 by bugdroid1@chromium.org, Jun 12 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c70eae7d0badbff5763c481c097da03a8aca81ea

commit c70eae7d0badbff5763c481c097da03a8aca81ea
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 12 21:05:07 2014

Pepper: Make ManifestResolveKey resuable.

I'd like to simplify the OpenResource implementation for the Non-SFI case. I
think that this can all stop using the trusted plugin now; this change makes
the ManifestResolveKey method easier to use from within
ppb_nacl_private_impl.cc.

BUG=239656

Review URL: https://codereview.chromium.org/329593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276802 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 113 by bugdroid1@chromium.org, Jun 12 2014

------------------------------------------------------------------
r276802 | teravest@chromium.org | 2014-06-12T21:05:07.553715Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=276802&r2=276801&pathrev=276802

Pepper: Make ManifestResolveKey resuable.

I'd like to simplify the OpenResource implementation for the Non-SFI case. I
think that this can all stop using the trusted plugin now; this change makes
the ManifestResolveKey method easier to use from within
ppb_nacl_private_impl.cc.

BUG=239656

Review URL: https://codereview.chromium.org/329593002
-----------------------------------------------------------------
Project Member

Comment 114 by bugdroid1@chromium.org, Jun 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/468953b3ef45522178b43b82cbf8d2229aad7249

commit 468953b3ef45522178b43b82cbf8d2229aad7249
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 13 19:40:43 2014

Pepper: Refactor some coordinator histograms.

We have a bunch of histograms that log data at the same time as
ReportTranslationFinished(), so we may as well move some of that logic out of
the trusted plugin. We use a different time range for translation for other
metrics, so I had to add a "HistogramTimeTranslate" method in addition to the
existing ones for "small", "medium", and "large" times.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/307403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277073 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 115 by bugdroid1@chromium.org, Jun 13 2014

------------------------------------------------------------------
r277073 | teravest@chromium.org | 2014-06-13T19:40:43.776278Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=277073&r2=277072&pathrev=277073
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/histogram.cc?r1=277073&r2=277072&pathrev=277073
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=277073&r2=277072&pathrev=277073
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/histogram.h?r1=277073&r2=277072&pathrev=277073
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=277073&r2=277072&pathrev=277073
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=277073&r2=277072&pathrev=277073
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h?r1=277073&r2=277072&pathrev=277073
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=277073&r2=277072&pathrev=277073

Pepper: Refactor some coordinator histograms.

We have a bunch of histograms that log data at the same time as
ReportTranslationFinished(), so we may as well move some of that logic out of
the trusted plugin. We use a different time range for translation for other
metrics, so I had to add a "HistogramTimeTranslate" method in addition to the
existing ones for "small", "medium", and "large" times.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/307403005
-----------------------------------------------------------------
Project Member

Comment 116 by bugdroid1@chromium.org, Jun 16 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55cd5b803430afdc255356bbaef6575230242298

commit 55cd5b803430afdc255356bbaef6575230242298
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Jun 16 14:22:19 2014

Pepper: Move more UMA stuff out of trusted plugin.

This is yet another pretty simple change just lifting more lines out of the
trusted plugin. I added a method to PPB_NaCl_Private that's safe to call from
a background thread (there are other methods that are safe as well) to keep the
call sites simple.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/331973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277424 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 117 by bugdroid1@chromium.org, Jun 16 2014

------------------------------------------------------------------
r277424 | teravest@chromium.org | 2014-06-16T14:22:19.067608Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc?r1=277424&r2=277423&pathrev=277424
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h?r1=277424&r2=277423&pathrev=277424
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=277424&r2=277423&pathrev=277424
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=277424&r2=277423&pathrev=277424
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=277424&r2=277423&pathrev=277424
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=277424&r2=277423&pathrev=277424
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=277424&r2=277423&pathrev=277424

Pepper: Move more UMA stuff out of trusted plugin.

This is yet another pretty simple change just lifting more lines out of the
trusted plugin. I added a method to PPB_NaCl_Private that's safe to call from
a background thread (there are other methods that are safe as well) to keep the
call sites simple.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/331973002
-----------------------------------------------------------------
Project Member

Comment 118 by bugdroid1@chromium.org, Jun 18 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10c865f029317feac758d73d23ca61cf35112127

commit 10c865f029317feac758d73d23ca61cf35112127
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 18 19:19:48 2014

Pepper: Small cleanup in PNaClCoordinator.

This simplifies the case where we fail to open all the necessary temporary
files as part of PNaCl translation.

RunTranslate() isn't called if num_object_files_opened_ != split_module_count_
anyway, so this should be equivalent to the existing behavior.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/335343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278143 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 119 by bugdroid1@chromium.org, Jun 18 2014

------------------------------------------------------------------
r278143 | teravest@chromium.org | 2014-06-18T19:19:48.725370Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=278143&r2=278142&pathrev=278143
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h?r1=278143&r2=278142&pathrev=278143

Pepper: Small cleanup in PNaClCoordinator.

This simplifies the case where we fail to open all the necessary temporary
files as part of PNaCl translation.

RunTranslate() isn't called if num_object_files_opened_ != split_module_count_
anyway, so this should be equivalent to the existing behavior.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/335343006
-----------------------------------------------------------------
Project Member

Comment 120 by bugdroid1@chromium.org, Jun 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3833fe876803c050cdddb1d62d26fa492de4dc2

commit d3833fe876803c050cdddb1d62d26fa492de4dc2
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 20 23:31:34 2014

Pepper: Simplify OpenResource() for Non-SFI.

The Non-SFI implementation of OpenResource is pretty complicated. This is
because the logic to support that operation was entirely in the trusted
plugin. Now, we can perform the necessary logic entirely in Chromium, so
it can be made much simpler.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32
BUG=239656

Review URL: https://codereview.chromium.org/339213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278859 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 121 by bugdroid1@chromium.org, Jun 20 2014

------------------------------------------------------------------
r278859 | teravest@chromium.org | 2014-06-20T23:31:34.739993Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=278859&r2=278858&pathrev=278859
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.h?r1=278859&r2=278858&pathrev=278859
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=278859&r2=278858&pathrev=278859
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=278859&r2=278858&pathrev=278859
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=278859&r2=278858&pathrev=278859

Pepper: Simplify OpenResource() for Non-SFI.

The Non-SFI implementation of OpenResource is pretty complicated. This is
because the logic to support that operation was entirely in the trusted
plugin. Now, we can perform the necessary logic entirely in Chromium, so
it can be made much simpler.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32
BUG=239656

Review URL: https://codereview.chromium.org/339213003
-----------------------------------------------------------------
Project Member

Comment 122 by bugdroid1@chromium.org, Jun 23 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc4f946cf0d4110706a05b300229c2fa538851c8

commit bc4f946cf0d4110706a05b300229c2fa538851c8
Author: hidehiko@chromium.org <hidehiko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Jun 23 18:24:45 2014

Use base::File for the OpenResourceCallback's argument.

ManifestServiceChannel can be removed while the DownloadFile is running.
In such a case, ManifestServiceProxy::DidDownloadFile is called upon
the completion of DownloadFile, and then callback is invoked.
However, as the callback refers the ManifestServiceChannel weakly, so
the native file descriptor will be leaked.
By this change, OpenResourceCallback takes the base::File instead of
base::PlatformFile. Since base::File will take the ownership of the
native file descriptor, it will be closed correctly, even if the
ManifestServiceChannel is deleted before.

BUG=239656
TEST=Ran browser_tests --gtest_filter=*NonSfi*:*NonSFI* locally and trybots.
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Review URL: https://codereview.chromium.org/348323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279146 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 123 by bugdroid1@chromium.org, Jun 23 2014

------------------------------------------------------------------
r279146 | hidehiko@chromium.org | 2014-06-23T18:24:45.175728Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=279146&r2=279145&pathrev=279146
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/manifest_service_channel.cc?r1=279146&r2=279145&pathrev=279146
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/manifest_service_channel.h?r1=279146&r2=279145&pathrev=279146

Use base::File for the OpenResourceCallback's argument.

ManifestServiceChannel can be removed while the DownloadFile is running.
In such a case, ManifestServiceProxy::DidDownloadFile is called upon
the completion of DownloadFile, and then callback is invoked.
However, as the callback refers the ManifestServiceChannel weakly, so
the native file descriptor will be leaked.
By this change, OpenResourceCallback takes the base::File instead of
base::PlatformFile. Since base::File will take the ownership of the
native file descriptor, it will be closed correctly, even if the
ManifestServiceChannel is deleted before.

BUG=239656
TEST=Ran browser_tests --gtest_filter=*NonSfi*:*NonSFI* locally and trybots.
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Review URL: https://codereview.chromium.org/348323002
-----------------------------------------------------------------
Project Member

Comment 124 by bugdroid1@chromium.org, Jun 24 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9565a418880f5149f721f5657c3f9b1a408e8dad

commit 9565a418880f5149f721f5657c3f9b1a408e8dad
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 24 20:47:07 2014

Pepper: Remove callback for resource loading.

Using CompletionCallbacks for PNaClResources::StartLoad and
PNaClResources::ReadResourceInfo doesn't accomplish much and makes
the code more complicated. This is in preparation for a larger
change to get rid of FileDownloader for streaming pexe downloads.

BUG=239656

Review URL: https://codereview.chromium.org/358443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279485 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 125 by bugdroid1@chromium.org, Jun 24 2014

------------------------------------------------------------------
r279485 | teravest@chromium.org | 2014-06-24T20:47:07.549603Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=279485&r2=279484&pathrev=279485
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h?r1=279485&r2=279484&pathrev=279485
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_resources.cc?r1=279485&r2=279484&pathrev=279485
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_resources.h?r1=279485&r2=279484&pathrev=279485

Pepper: Remove callback for resource loading.

Using CompletionCallbacks for PNaClResources::StartLoad and
PNaClResources::ReadResourceInfo doesn't accomplish much and makes
the code more complicated. This is in preparation for a larger
change to get rid of FileDownloader for streaming pexe downloads.

BUG=239656

Review URL: https://codereview.chromium.org/358443002
-----------------------------------------------------------------
Project Member

Comment 126 by bugdroid1@chromium.org, Jun 25 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbff16497e63fb3e6d9aed099dc75bf843b10d6e

commit cbff16497e63fb3e6d9aed099dc75bf843b10d6e
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 25 22:01:20 2014

Pepper: Refactor OpenManifestEntry.

This change pulls out more OpenManifestEntry code from service_runtime, making
PPB_NaCl_Private a smallter interface, and preparing for pulling all of that
logic out of the trusted plugin.

An earlier version of this change was reverted after breaking Non-SFI mode, but
the Non-SFI case no longer uses this codepath.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32
BUG=239656

Review URL: https://codereview.chromium.org/357773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279832 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 127 by bugdroid1@chromium.org, Jun 25 2014

------------------------------------------------------------------
r279832 | teravest@chromium.org | 2014-06-25T22:01:20.258787Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=279832&r2=279831&pathrev=279832
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=279832&r2=279831&pathrev=279832
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=279832&r2=279831&pathrev=279832
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=279832&r2=279831&pathrev=279832
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=279832&r2=279831&pathrev=279832

Pepper: Refactor OpenManifestEntry.

This change pulls out more OpenManifestEntry code from service_runtime, making
PPB_NaCl_Private a smallter interface, and preparing for pulling all of that
logic out of the trusted plugin.

An earlier version of this change was reverted after breaking Non-SFI mode, but
the Non-SFI case no longer uses this codepath.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32
BUG=239656

Review URL: https://codereview.chromium.org/357773002
-----------------------------------------------------------------
Project Member

Comment 128 by bugdroid1@chromium.org, Jun 26 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/014349cbb32390cc8a11f8dd0bfc08be39582c0e

commit 014349cbb32390cc8a11f8dd0bfc08be39582c0e
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 26 20:08:31 2014

Pepper: Move Pnacl init time out of trusted plugin.

This change moves the pnacl init time out of the trusted plugin. It's part of a
series of changes to get rid of the trusted plugin entirely.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/356923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280082 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 129 by bugdroid1@chromium.org, Jun 26 2014

Project Member

Comment 130 by bugdroid1@chromium.org, Jun 27 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dd756d25890e948424a9284a49b86846c0d938f

commit 4dd756d25890e948424a9284a49b86846c0d938f
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jun 27 02:07:29 2014

Pepper: Remove PPP_ManifestService.

Now that enough logic has been moved out of the trusted plugin, we can get rid
of PPP_ManifestService and make the code in the Non-SFI case much clearer.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32
BUG=239656

Review URL: https://codereview.chromium.org/356053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280204 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 131 by bugdroid1@chromium.org, Jun 27 2014

------------------------------------------------------------------
r280204 | teravest@chromium.org | 2014-06-27T02:07:29.475953Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=280204&r2=280203&pathrev=280204
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=280204&r2=280203&pathrev=280204
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc?r1=280204&r2=280203&pathrev=280204
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=280204&r2=280203&pathrev=280204
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=280204&r2=280203&pathrev=280204
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h?r1=280204&r2=280203&pathrev=280204
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=280204&r2=280203&pathrev=280204

Pepper: Remove PPP_ManifestService.

Now that enough logic has been moved out of the trusted plugin, we can get rid
of PPP_ManifestService and make the code in the Non-SFI case much clearer.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32
BUG=239656

Review URL: https://codereview.chromium.org/356053004
-----------------------------------------------------------------
Project Member

Comment 132 by bugdroid1@chromium.org, Jun 30 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9166b3989e0e9acbb01a85464e46b6d1cd1dba3

commit a9166b3989e0e9acbb01a85464e46b6d1cd1dba3
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Jun 30 22:56:28 2014

Pepper: SelLdrLauncherChrome cleanup.

The indirection provided by SelLdrLauncherChrome::Start() isn't much help.
Instead, we just expose the channel so that ServiceRuntime can pass it to
LaunchSelLdr directly.

BUG=239656

Review URL: https://codereview.chromium.org/360743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280686 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 133 by bugdroid1@chromium.org, Jun 30 2014

------------------------------------------------------------------
r280686 | teravest@chromium.org | 2014-06-30T22:56:28.398214Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc?r1=280686&r2=280685&pathrev=280686
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc?r1=280686&r2=280685&pathrev=280686
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h?r1=280686&r2=280685&pathrev=280686
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.h?r1=280686&r2=280685&pathrev=280686

Pepper: SelLdrLauncherChrome cleanup.

The indirection provided by SelLdrLauncherChrome::Start() isn't much help.
Instead, we just expose the channel so that ServiceRuntime can pass it to
LaunchSelLdr directly.

BUG=239656

Review URL: https://codereview.chromium.org/360743002
-----------------------------------------------------------------
Project Member

Comment 134 by bugdroid1@chromium.org, Jul 3 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51ea8de009420bb4cc6258e7846fa3080b93f4d6

commit 51ea8de009420bb4cc6258e7846fa3080b93f4d6
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jul 03 00:22:03 2014

Pepper: Remove program_url in trusted plugin.

This reduces the amount of state in the trusted plugin (slightly).

BUG=239656

Review URL: https://codereview.chromium.org/367153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281127 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 135 by bugdroid1@chromium.org, Jul 3 2014

Blockedon: chromium:394497
Project Member

Comment 137 by bugdroid1@chromium.org, Jul 22 2014

------------------------------------------------------------------
r284684 | teravest@chromium.org | 2014-07-22T15:54:45.971638Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=284684&r2=284683&pathrev=284684
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=284684&r2=284683&pathrev=284684
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=284684&r2=284683&pathrev=284684
   A http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppp_pexe_stream_handler.idl?r1=284684&r2=284683&pathrev=284684
   D http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/file_downloader.cc?r1=284684&r2=284683&pathrev=284684
   D http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/callback_source.h?r1=284684&r2=284683&pathrev=284684
   D http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/file_downloader.h?r1=284684&r2=284683&pathrev=284684
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h?r1=284684&r2=284683&pathrev=284684
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=284684&r2=284683&pathrev=284684
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.gypi?r1=284684&r2=284683&pathrev=284684
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc?r1=284684&r2=284683&pathrev=284684
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h?r1=284684&r2=284683&pathrev=284684
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=284684&r2=284683&pathrev=284684
   A http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppp_pexe_stream_handler.h?r1=284684&r2=284683&pathrev=284684
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h?r1=284684&r2=284683&pathrev=284684

Pepper: Delete FileDownloader in trusted plugin.

This simplifies PnaclCoordinator considerably and reduces the total
amount of code in the trusted plugin.

BUG=239656

Review URL: https://codereview.chromium.org/393693004
-----------------------------------------------------------------
Project Member

Comment 138 by bugdroid1@chromium.org, Jul 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/262509a82256d68cf728cbd6f0a9f4c80888250f

commit 262509a82256d68cf728cbd6f0a9f4c80888250f
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jul 22 15:54:45 2014

Pepper: Delete FileDownloader in trusted plugin.

This simplifies PnaclCoordinator considerably and reduces the total
amount of code in the trusted plugin.

BUG=239656

Review URL: https://codereview.chromium.org/393693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284684 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 139 by bugdroid1@chromium.org, Jul 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf25409780d50c9aa2f3c3f6071c4cafd08513b

commit 5cf25409780d50c9aa2f3c3f6071c4cafd08513b
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jul 22 21:06:11 2014

Pepper: Simplify TempFile in trusted plugin.

This change makes the behavior of internal_handle_ in TempFile easier to reason
about. This change is possible after a large refactoring of PnaclCoordinator
that happened as a result of removing FileDownloader.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/413493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284766 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 140 by bugdroid1@chromium.org, Jul 22 2014

------------------------------------------------------------------
r284766 | teravest@chromium.org | 2014-07-22T21:06:11.187911Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=284766&r2=284765&pathrev=284766
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/temporary_file.cc?r1=284766&r2=284765&pathrev=284766
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/temporary_file.h?r1=284766&r2=284765&pathrev=284766

Pepper: Simplify TempFile in trusted plugin.

This change makes the behavior of internal_handle_ in TempFile easier to reason
about. This change is possible after a large refactoring of PnaclCoordinator
that happened as a result of removing FileDownloader.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/413493002
-----------------------------------------------------------------
Project Member

Comment 141 by bugdroid1@chromium.org, Jul 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdb0e21c3e8eae56068895c859d887a9a3542468

commit bdb0e21c3e8eae56068895c859d887a9a3542468
Author: sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jul 22 23:08:18 2014

Revert 284766 "Pepper: Simplify TempFile in trusted plugin."

Sorry I had to revert this. It's not because it caused problems, but
rather I needed to revert r284684 as it caused problems and your patch
touches the same files.

> Pepper: Simplify TempFile in trusted plugin.
> 
> This change makes the behavior of internal_handle_ in TempFile easier to reason
> about. This change is possible after a large refactoring of PnaclCoordinator
> that happened as a result of removing FileDownloader.
> 
> BUG=239656
> R=bbudge@chromium.org
> 
> Review URL: https://codereview.chromium.org/413493002

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/406383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284790 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 142 by bugdroid1@chromium.org, Jul 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d21e4a40ecf63968b03a32b4da6725eb2be7b9f1

commit d21e4a40ecf63968b03a32b4da6725eb2be7b9f1
Author: sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jul 22 23:09:52 2014

Revert 284684 "Pepper: Delete FileDownloader in trusted plugin."

Reverting as broke chrome and chromeos dbg builders:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32615/steps/browser_tests/logs/SuccessfulLoadUMA
[ RUN      ] NaClBrowserTestPnacl.SuccessfulLoadUMA
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[18889:18889:0722/130648:WARNING:password_store_factory.cc(215)] Using
basic (unencrypted) store for password storage. See
http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more
information about password storage options.
HTTP server started on http://127.0.0.1:56115...
sending server_data: {"host": "127.0.0.1", "port": 56115} (36 bytes)
[9:10:0722/130650:ERROR:pnacl_translation_resource_host.cc(135)] Got
invalid platformfilefortransit
/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/vector:461:
    error: attempt to insert into container with an iterator from a
    different container.

Objects involved in the operation:
sequence "this" @ 0x0x392ba6c93260 {
}
iterator "__position" @ 0x0x7fff9ff24e20 {
  state = past-the-end;
  references sequence @ 0x0x7fff9ff24e20
}
[18889:18938:0722/130651:WARNING:raw_channel_posix.cc(214)] recvmsg:
Connection reset by peer
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7fe4bf491cee base::debug::StackTrace::StackTrace()
#1 0x000004af93fa content::(anonymous
namespace)::DumpStackTraceSignalHandler()
#2 0x7fe4b68074a0 \u003Cunknown>
#3 0x7fe4b68b9a43 __poll
#4 0x7fe4b76faff6 \u003Cunknown>
#5 0x7fe4b76fb124 g_main_context_iteration
#6 0x7fe4bf44ff75 base::MessagePumpGlib::Run()
#7 0x7fe4bf54b1f0 base::MessageLoop::RunHandler()
#8 0x7fe4bf5b18e2 base::RunLoop::Run()
#9 0x000004b63969 content::RunThisRunLoop()
#10 0x000004b638fa content::RunMessageLoop()
#11 0x000004b0ea15 content::JavascriptTestObserver::Run()
#12 0x000001312927 NaClBrowserTestBase::RunJavascriptTest()
#13 0x000001312a48 NaClBrowserTestBase::RunLoadTest()
#14 0x00000130f514 (anonymous
namespace)::NaClBrowserTestPnacl_SuccessfulLoadUMA_Test::RunTestOnMai
...

> Pepper: Delete FileDownloader in trusted plugin.
> 
> This simplifies PnaclCoordinator considerably and reduces the total
> amount of code in the trusted plugin.
> 
> BUG=239656
> 
> Review URL: https://codereview.chromium.org/393693004

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/406323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284791 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 143 by bugdroid1@chromium.org, Jul 22 2014

------------------------------------------------------------------
r284790 | sky@chromium.org | 2014-07-22T23:08:18.013089Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=284790&r2=284789&pathrev=284790
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/temporary_file.cc?r1=284790&r2=284789&pathrev=284790
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/temporary_file.h?r1=284790&r2=284789&pathrev=284790

Revert 284766 "Pepper: Simplify TempFile in trusted plugin."

Sorry I had to revert this. It's not because it caused problems, but
rather I needed to revert r284684 as it caused problems and your patch
touches the same files.

> Pepper: Simplify TempFile in trusted plugin.
> 
> This change makes the behavior of internal_handle_ in TempFile easier to reason
> about. This change is possible after a large refactoring of PnaclCoordinator
> that happened as a result of removing FileDownloader.
> 
> BUG=239656
> R=bbudge@chromium.org
> 
> Review URL: https://codereview.chromium.org/413493002

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/406383002
-----------------------------------------------------------------
Project Member

Comment 144 by bugdroid1@chromium.org, Jul 22 2014

------------------------------------------------------------------
r284791 | sky@chromium.org | 2014-07-22T23:09:52.636899Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/file_downloader.h?r1=284791&r2=284790&pathrev=284791
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h?r1=284791&r2=284790&pathrev=284791
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=284791&r2=284790&pathrev=284791
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.gypi?r1=284791&r2=284790&pathrev=284791
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc?r1=284791&r2=284790&pathrev=284791
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h?r1=284791&r2=284790&pathrev=284791
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=284791&r2=284790&pathrev=284791
   D http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppp_pexe_stream_handler.h?r1=284791&r2=284790&pathrev=284791
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h?r1=284791&r2=284790&pathrev=284791
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=284791&r2=284790&pathrev=284791
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=284791&r2=284790&pathrev=284791
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=284791&r2=284790&pathrev=284791
   D http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppp_pexe_stream_handler.idl?r1=284791&r2=284790&pathrev=284791
   A http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/file_downloader.cc?r1=284791&r2=284790&pathrev=284791
   A http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/callback_source.h?r1=284791&r2=284790&pathrev=284791

Revert 284684 "Pepper: Delete FileDownloader in trusted plugin."

Reverting as broke chrome and chromeos dbg builders:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32615/steps/browser_tests/logs/SuccessfulLoadUMA
[ RUN      ] NaClBrowserTestPnacl.SuccessfulLoadUMA
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[18889:18889:0722/130648:WARNING:password_store_factory.cc(215)] Using
basic (unencrypted) store for password storage. See
http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more
information about password storage options.
HTTP server started on http://127.0.0.1:56115...
sending server_data: {"host": "127.0.0.1", "port": 56115} (36 bytes)
[9:10:0722/130650:ERROR:pnacl_translation_resource_host.cc(135)] Got
invalid platformfilefortransit
/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/vector:461:
    error: attempt to insert into container with an iterator from a
    different container.

Objects involved in the operation:
sequence "this" @ 0x0x392ba6c93260 {
}
iterator "__position" @ 0x0x7fff9ff24e20 {
  state = past-the-end;
  references sequence @ 0x0x7fff9ff24e20
}
[18889:18938:0722/130651:WARNING:raw_channel_posix.cc(214)] recvmsg:
Connection reset by peer
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7fe4bf491cee base::debug::StackTrace::StackTrace()
#1 0x000004af93fa content::(anonymous
namespace)::DumpStackTraceSignalHandler()
#2 0x7fe4b68074a0 \u003Cunknown>
#3 0x7fe4b68b9a43 __poll
#4 0x7fe4b76faff6 \u003Cunknown>
#5 0x7fe4b76fb124 g_main_context_iteration
#6 0x7fe4bf44ff75 base::MessagePumpGlib::Run()
#7 0x7fe4bf54b1f0 base::MessageLoop::RunHandler()
#8 0x7fe4bf5b18e2 base::RunLoop::Run()
#9 0x000004b63969 content::RunThisRunLoop()
#10 0x000004b638fa content::RunMessageLoop()
#11 0x000004b0ea15 content::JavascriptTestObserver::Run()
#12 0x000001312927 NaClBrowserTestBase::RunJavascriptTest()
#13 0x000001312a48 NaClBrowserTestBase::RunLoadTest()
#14 0x00000130f514 (anonymous
namespace)::NaClBrowserTestPnacl_SuccessfulLoadUMA_Test::RunTestOnMai
...

> Pepper: Delete FileDownloader in trusted plugin.
> 
> This simplifies PnaclCoordinator considerably and reduces the total
> amount of code in the trusted plugin.
> 
> BUG=239656
> 
> Review URL: https://codereview.chromium.org/393693004

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/406323003
-----------------------------------------------------------------
Project Member

Comment 145 by bugdroid1@chromium.org, Jul 23 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a490e0be828962ef7d89c30dd551afb34ea221

commit b7a490e0be828962ef7d89c30dd551afb34ea221
Author: teravest@chromium.org <teravest@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jul 23 16:58:15 2014

Pepper: Delete FileDownloader in trusted plugin.

This simplifies PnaclCoordinator considerably and reduces the total
amount of code in the trusted plugin.

BUG=239656

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284684

R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/393693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284961 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 146 by bugdroid1@chromium.org, Jul 23 2014

------------------------------------------------------------------
r284961 | teravest@chromium.org | 2014-07-23T16:58:15.778041Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppp_pexe_stream_handler.idl?r1=284961&r2=284960&pathrev=284961
   D http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/file_downloader.cc?r1=284961&r2=284960&pathrev=284961
   D http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/file_downloader.h?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppb_nacl_private.h?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/private/ppb_nacl_private.idl?r1=284961&r2=284960&pathrev=284961
   D http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/callback_source.h?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/plugin.gypi?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/temporary_file.cc?r1=284961&r2=284960&pathrev=284961
   A http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/private/ppp_pexe_stream_handler.h?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/src/trusted/plugin/temporary_file.h?r1=284961&r2=284960&pathrev=284961
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc?r1=284961&r2=284960&pathrev=284961

Pepper: Delete FileDownloader in trusted plugin.

This simplifies PnaclCoordinator considerably and reduces the total
amount of code in the trusted plugin.

BUG=239656

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284684

R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/393693004
-----------------------------------------------------------------
Project Member

Comment 147 by bugdroid1@chromium.org, Aug 14 2014

------------------------------------------------------------------
r289503 | fsamuel@chromium.org | 2014-08-14T09:46:52.193536Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/app_view/app_view_constants.h?r1=289503&r2=289502&pathrev=289503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.js?r1=289503&r2=289502&pathrev=289503
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/common/api/app_runtime.idl?r1=289503&r2=289502&pathrev=289503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/app_view/app_view_guest.cc?r1=289503&r2=289502&pathrev=289503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/app_view.js?r1=289503&r2=289502&pathrev=289503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/app_view/app_view_guest.h?r1=289503&r2=289502&pathrev=289503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/apps/app_view_browsertest.cc?r1=289503&r2=289502&pathrev=289503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/platform_apps/app_view/shim/main.js?r1=289503&r2=289502&pathrev=289503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/app_view/app_view_constants.cc?r1=289503&r2=289502&pathrev=289503

Allow passing parameters within appview

BUG=239656

Review URL: https://codereview.chromium.org/287153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271719 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/460133002
-----------------------------------------------------------------
Project Member

Comment 148 by bugdroid1@chromium.org, Aug 14 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a65d0d851f4c4f4c3c6b51da74716c2daedb456

commit 7a65d0d851f4c4f4c3c6b51da74716c2daedb456
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Aug 14 09:46:52 2014

Allow passing parameters within appview

BUG=239656

Review URL: https://codereview.chromium.org/287153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271719 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/460133002

Cr-Commit-Position: refs/heads/master@{#289503}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289503 0039d316-1c4b-4281-b951-d872f2087c98


Blockedon: chromium:394130
Project Member

Comment 151 by bugdroid1@chromium.org, Jan 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e58ead2e061d1044b10a3781f9c21d3ed10e0c

commit 70e58ead2e061d1044b10a3781f9c21d3ed10e0c
Author: mseaborn <mseaborn@chromium.org>
Date: Sat Jan 24 06:19:30 2015

NaCl: Simplify the plumbing for PPAPI's DevInterfacesEnabled flag

There's no need for this flag to be sent from ppb_nacl_private_impl.cc
to plugin.cc and back again.  It can stay within
ppb_nacl_private_impl.cc.

This merges two error-handling checks in LaunchSelLdr().

BUG=239656
TEST=browser_tests

Review URL: https://codereview.chromium.org/874603002

Cr-Commit-Position: refs/heads/master@{#313010}

[modify] http://crrev.com/70e58ead2e061d1044b10a3781f9c21d3ed10e0c/components/nacl/renderer/ppb_nacl_private_impl.cc
[modify] http://crrev.com/70e58ead2e061d1044b10a3781f9c21d3ed10e0c/ppapi/api/private/ppb_nacl_private.idl
[modify] http://crrev.com/70e58ead2e061d1044b10a3781f9c21d3ed10e0c/ppapi/c/private/ppb_nacl_private.h
[modify] http://crrev.com/70e58ead2e061d1044b10a3781f9c21d3ed10e0c/ppapi/native_client/src/trusted/plugin/service_runtime.cc
[modify] http://crrev.com/70e58ead2e061d1044b10a3781f9c21d3ed10e0c/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c

Project Member

Comment 152 by bugdroid1@chromium.org, Jan 26 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a202e283da0aa3a26f48af80ed2933ccae8f7289

commit a202e283da0aa3a26f48af80ed2933ccae8f7289
Author: mseaborn <mseaborn@chromium.org>
Date: Mon Jan 26 17:59:37 2015

NaCl: Fix Chromium style warnings in src/trusted/plugin/

This fixes warnings that appear when moving this code into
components/nacl/.  (The Chromium style checker is disabled for code
under ppapi/.)

Fix warnings about "override".

Fix warning about NaClSubprocess:
"[chromium-style] Complex constructor has an inlined body".

BUG=239656
TEST=none

Review URL: https://codereview.chromium.org/868273002

Cr-Commit-Position: refs/heads/master@{#313091}

[modify] http://crrev.com/a202e283da0aa3a26f48af80ed2933ccae8f7289/ppapi/native_client/src/trusted/plugin/module_ppapi.h
[modify] http://crrev.com/a202e283da0aa3a26f48af80ed2933ccae8f7289/ppapi/native_client/src/trusted/plugin/nacl_subprocess.cc
[modify] http://crrev.com/a202e283da0aa3a26f48af80ed2933ccae8f7289/ppapi/native_client/src/trusted/plugin/nacl_subprocess.h
[modify] http://crrev.com/a202e283da0aa3a26f48af80ed2933ccae8f7289/ppapi/native_client/src/trusted/plugin/plugin.h
[modify] http://crrev.com/a202e283da0aa3a26f48af80ed2933ccae8f7289/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h

Project Member

Comment 153 by bugdroid1@chromium.org, Jan 29 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f

commit 45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f
Author: mseaborn <mseaborn@chromium.org>
Date: Thu Jan 29 19:39:22 2015

NaCl: Move src/trusted/plugin/ to components/nacl/renderer/plugin/

This moves the "trusted plugin" code so that all the NaCl
renderer-side code is in the same place, under
components/nacl/renderer/.  I've used the "renderer/plugin/" subdir so
that this legacy code is distinguished from the newer code that's
directly under "renderer/".

This will make further incremental cleanups easier: It will enable
closer integration between renderer/* and renderer/plugin/*.  Rather
than indirecting through PPB_NaCl_Private/PPP_PexeStreamHandler, it
would be reasonable for the two sides to share pointers to C++
objects.  Doing that will be more acceptable when the two sides live
in the same directory.

 * chrome/chrome_tests.gypi: Declaring a runtime dependency isn't
   necessary since the trusted plugin isn't a separate DSO/DLL these
   days.

 * .gitignore: Remove reference to ppGoogleNaClPluginChrome.xml, which
   no longer exists.

 * module_ppapi.h: Added an #include guard.

BUG=239656
TEST=trybots

Review URL: https://codereview.chromium.org/876483002

Cr-Commit-Position: refs/heads/master@{#313759}

[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/.gitignore
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/chrome/BUILD.gn
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/chrome/app/BUILD.gn
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/chrome/app/DEPS
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/chrome/app/chrome_main_delegate.cc
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/chrome/chrome.gyp
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/chrome/chrome_tests.gypi
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/chrome/chrome_tests_unit.gypi
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/chrome/test/BUILD.gn
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl.gyp
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/histogram.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/DEPS
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/module_ppapi.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/module_ppapi.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/nacl_subprocess.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/nacl_subprocess.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/plugin.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/plugin.gyp
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/plugin.gypi
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/plugin.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/plugin_error.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/pnacl_coordinator.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/pnacl_coordinator.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/pnacl_resources.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/pnacl_resources.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/pnacl_translate_thread.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/pnacl_translate_thread.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/ppapi_entrypoints.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/ppapi_entrypoints.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/sel_ldr_launcher_chrome.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/sel_ldr_launcher_chrome.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/service_runtime.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/service_runtime.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/srpc_client.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/srpc_client.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/srpc_params.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/srpc_params.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/temporary_file.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/temporary_file.h
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/utility.cc
[rename] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/components/nacl/renderer/plugin/utility.h
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/extensions/shell/common/DEPS
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/extensions/shell/common/shell_content_client.cc
[modify] http://crrev.com/45df3da06ad59fd20f0c3e7efdd9bc4b5a0e213f/ppapi/native_client/DEPS

Project Member

Comment 155 by bugdroid1@chromium.org, Feb 10 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cf62d9ade1564df31b3887b01df5afad745a124

commit 3cf62d9ade1564df31b3887b01df5afad745a124
Author: mseaborn <mseaborn@chromium.org>
Date: Tue Feb 10 21:20:01 2015

NaCl cleanup: Move ppb_nacl_private.h into components/nacl/renderer/

Since PPB_NaCl_Private is both implemented and consumed in
components/nacl/renderer/, there's no need for the interface to be
defined in ppapi/.  The fact that this is a PPAPI interface at all is
just a holdover from when the code for the NaCl trusted plugin lived
outside the Chromium repo.

We can drop the ppb_nacl_private.idl file.

Benefits:

 * This reduces the friction for changing ppb_nacl_private.h.  It's no
   longer necessary to change ppb_nacl_private.idl and re-run the
   generator.

 * This removes PPB_NaCl_Private from the PPAPI shims, reducing code
   size.

 * ppb_nacl_private.h no longer has to follow the PPAPI C header
   style.  For example, it would no longer need to define its own
   "struct PP_NaClFileInfo" type -- it could share a definition that's
   marshallable over Chrome IPC.

Changes to ppb_nacl_private.h:

 * Add comment to explain the status of this interface.
 * Remove unused "*_1_0" variants of #define and typedef.

BUG=239656
BUG= 251460 
TEST=trybots

Review URL: https://codereview.chromium.org/911463003

Cr-Commit-Position: refs/heads/master@{#315641}

[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/chrome/renderer/chrome_content_renderer_client.cc
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/chrome/test/nacl/nacl_browsertest_uma.cc
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/file_downloader.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/histogram.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/json_manifest.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/manifest_downloader.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/nexe_load_manager.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/plugin/module_ppapi.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/plugin/plugin.cc
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/plugin/plugin.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/plugin/plugin_error.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/plugin/pnacl_resources.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/plugin/sel_ldr_launcher_chrome.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/plugin/utility.h
[rename] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/ppb_nacl_private.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/ppb_nacl_private_impl.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/progress_event.cc
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/components/nacl/renderer/progress_event.h
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/extensions/shell/browser/shell_nacl_browser_delegate.cc
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/extensions/shell/renderer/shell_content_renderer_client.cc
[delete] http://crrev.com/8a9231d90a62da8563ea983336d5c73d0b210dd1/ppapi/api/private/ppb_nacl_private.idl
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/ppapi/ppapi_sources.gypi
[modify] http://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124/ppapi/tests/all_c_includes.h

Owner: ----
Status: Available
Project Member

Comment 157 by sheriffbot@chromium.org, Apr 22 2016

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Hotlist-Recharge-Cold label is added for tracking. Please re-triage this issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Cc: raymes@chromium.org binji@chromium.org
Labels: -MovedFrom-31 movedfrom-31
What's left at this point?
Cc: dmichael@chromium.org
The last I've heard from dmichael and bbudge was that we gave up on this, and there is still significant work remaining. Pepper and NaCl are destaffed.
dmichael/bbudge: do you remember details?
In theory, it should be possible now that the PDF plugin is out-of-process, and the NaCl plugin has been whittled down to a shell, and the SRPC proxy has been disconnected.

I don't think anyone really knows how much effort it would take to complete at this point. Nobody is working at it right now, or has plans to do so in the future.
Project Member

Comment 162 by sheriffbot@chromium.org, Oct 13 2017

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Showing comments 63 - 162 of 162 Older

Sign in to add a comment