New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 23833 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2009
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

browser actions: popups should have a nice border

Reported by erikkay@chromium.org, Oct 5 2009

Issue description

See the mocks in  issue 23596  for an example.

For now, we'll make the border fixed.  In the future, we may want to support 
a 9-grid API to allow authors to do something custom.

 

Comment 1 by aa@chromium.org, Oct 5 2009

Labels: Mstone-4 ReleaseBlock-Beta

Comment 2 by aa@chromium.org, Oct 5 2009

Labels: -Pri-2 Pri-1
Status: Started
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28187 

------------------------------------------------------------------------
r28187 | erikkay@chromium.org | 2009-10-06 16:50:06 -0700 (Tue, 06 Oct 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_bubble.h?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_bubble_win.cc?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bubble_border.cc?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bubble_border.h?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_popup.cc?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_popup.h?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_page_color/manifest.json?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html?r1=28187&r2=28186

Add an BubbleBorder to BrowserAction popups and fix positioning of the
popup.

BUG= 23833 , 23835 
TEST=none

Review URL: http://codereview.chromium.org/259065
------------------------------------------------------------------------

Status: Fixed
Labels: Feature-Extensions
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-4 -Feature-Extensions M-4 Cr-Platform-Extensions
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment