New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 23832 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2009
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

browser actions: popup should be able to close itself

Reported by erikkay@chromium.org, Oct 5 2009

Issue description

The popup code is the only place that really knows when it's done an action 
which should cause it to dismiss.  For simplicity's sake, window.close() 
should just work.

 

Comment 1 by aa@chromium.org, Oct 5 2009

Labels: Mstone-4 ReleaseBlock-Beta
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28053 

------------------------------------------------------------------------
r28053 | erikkay@chromium.org | 2009-10-05 15:00:05 -0700 (Mon, 05 Oct 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=28053&r2=28052
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=28053&r2=28052
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_bubble_win.cc?r1=28053&r2=28052
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=28053&r2=28052
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html?r1=28053&r2=28052

Allow popups to close themselves with window.close().

This also fixes an issue where not all of the parts of WebPreferences were being serialized/deserialized across IPC.

BUG= 23832 
TEST=run set_page_color extension, when it sets the color, the popup
should close

Review URL: http://codereview.chromium.org/243096
------------------------------------------------------------------------

Status: Fixed
Labels: Feature-Extensions
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-4 -Feature-Extensions M-4 Cr-Platform-Extensions
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment