Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 1 user
Status: Verified
Owner:
Closed: May 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 234509



Sign in to add a comment
Implement :unresolved pseudoclass
Project Member Reported by ericbidelman@chromium.org, May 1 2013 Back to list
"The :unresolved pseudoclass could be used to mitigate the Flash of Unstyled Content (FOUC) issues with custom elements."

We need this!

https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/custom/index.html#unresolved-element-pseudoclass
 
Cc: dominicc@chromium.org
Labels: -Type-Bug Type-Feature
Labels: -Pri-2 Pri-3
Owner: dominicc@chromium.org
Status: Started
Interesting coincidence; I started working on this to bring up some machinery necessary for  Issue 233775 . First patch is up for review here:

<https://codereview.chromium.org/14846002/>

Because upgrade of existing elements isn't implemented yet, this pseudoclass is not super interesting... yet.
Blocking: chromium:234509
Project Member Comment 5 by bugdroid1@chromium.org, May 3 2013
------------------------------------------------------------------------
r149628 | dominicc@chromium.org | 2013-05-03T02:27:50.401753Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSSelector.h?r1=149628&r2=149627&pathrev=149628
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Element.cpp?r1=149628&r2=149627&pathrev=149628
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/custom/unresolved-pseudoclass.html?r1=149628&r2=149627&pathrev=149628
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleResolver.cpp?r1=149628&r2=149627&pathrev=149628
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/CustomElementRegistry.cpp?r1=149628&r2=149627&pathrev=149628
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/SelectorChecker.cpp?r1=149628&r2=149627&pathrev=149628
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Element.h?r1=149628&r2=149627&pathrev=149628
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSSelector.cpp?r1=149628&r2=149627&pathrev=149628
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/CustomElementRegistry.h?r1=149628&r2=149627&pathrev=149628
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/custom/unresolved-pseudoclass-expected.txt?r1=149628&r2=149627&pathrev=149628

Implement the Custom Elements :unresolved pseudoclass

The :unresolved pseudoclass lets Custom Element authors avoid flash of unstyled content until their Custom Element definitions load.

This is a trivial initial implementation because element upgrade is not implemented yet.

BUG= 237215 

Review URL: https://chromiumcodereview.appspot.com/14846002
------------------------------------------------------------------------
The other half of this will be ready soon in <https://codereview.chromium.org/14626005/>
Owner: ericbidelman@chromium.org
Status: Fixed
The first cut of the element upgrade algorithm landed in <http://src.chromium.org/viewvc/blink?view=rev&revision=149688> so :unresolved is implemented *and* useful now.

Assigning this to Eric to verify.
Status: Verified
Sign in to add a comment