Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 236639 Windows scroll vertically by page feature doesn't take scrollbar visibility into account
Starred by 4 users Project Member Reported by jam...@chromium.org, Apr 29 2013 Back to list
Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 175502



Sign in to add a comment
On windows, mouse wheels can scroll by a fixed delta or scroll by page.  Scroll by page requires special handling since the amount to scroll depends on the content.  There is basic support for this, but it fails on content that is vertically scrollable but doesn't have a compositor scrollbar.

For now, these scrolls just go to the main thread.  It'd be better to handle them on the compositor thread.
 
Comment 1 by jam...@chromium.org, Apr 29 2013
The specific bug is here:

https://code.google.com/p/chromium/codesearch#chromium/src/cc/trees/layer_tree_host_impl.cc&q=layer_tree_host_impl.cc&sq=package:chromium&type=cs&l=1716

    if (!layer_impl->vertical_scrollbar_layer())
      continue;

Without that line, we incorrectly scroll on pages that don't have a vertical scrollbar (say they have overflow-y hidden).  With that line, we incorrectly fail to scroll on pages that do have a vertical scrollbar but that scrollbar is not registered with the compositor - i.e. it's a CSS styled one or something else the compositor does not understand.
Cc: rjkroege@chromium.org
Project Member Comment 3 by sheriffbot@chromium.org, Aug 26 2016
Labels: Hotlist-Recharge-Cold
Status: Untriaged
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: bokan@chromium.org
Components: Blink>Scroll
Cc: majidvp@chromium.org
I am not sure if this bug is still relevant.

We don't check scroll bar existence anymore rather we seem to depend on user_scrollable_horizontal and user_scrollable_vertical [1] which are set by blink based on the overflow property and do not depend on existence of scrollbar.

[1] 
https://cs.chromium.org/chromium/src/cc/trees/scroll_node.h?q=user_scrollable_vertical&sq=package:chromium&l=59&dr=C 
Labels: -Pri-2 Hotlist-Input-Dev Pri-3
Status: Available
It is since we're still punting wheels that scroll by page to the main thread:
https://cs.chromium.org/chromium/src/ui/events/blink/input_handler_proxy.cc?sq=package:chromium&rcl=1484237857&l=636

Though, as you mention, the reasons the bug was intractable no longer applies. We should try removing this and handling the wheel event on the compositor (assuming the scroll by page logic still exists in CC).
Sign in to add a comment