New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 23593 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2009
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

browser action button disappears when loading a new extension

Reported by erikkay@chromium.org, Oct 1 2009

Issue description

I had the print button browser action loaded via --load-extension.  I then 
manually loaded mappy from chrome://extensions.  When I did that, the print 
browser action button disappeared (although the space for the button 
remained).
 
This also reproduces for me if I "reload" an extension with a browser action.
Status: Assigned
Status: Started

Comment 4 by bugdro...@gmail.com, Oct 15 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29143 

------------------------------------------------------------------------
r29143 | sidchat@chromium.org | 2009-10-15 11:00:38 -0700 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=29143&r2=29142

Fix bug: browser action button disappears when loading a new extension. This was happenening because BrowserActionContainer, on receiving notification about an extension load/unload/change, deletes all BrowserAction views, re-adds all the views again, and asks the toolbar to SetBounds for the BrowserActionContainer. However, during deletion, it does not re-set the bounds. As a result, when SetBounds is called by the toolbar again, it does not see any changed in BrowserActionContainer, and does not layout again, causing all the browser actions to disappear. The solution lies in forcing  Layout() after SetBounds() in ToolbarView.

BUG= 23593 
TEST=none
Review URL: http://codereview.chromium.org/276033
------------------------------------------------------------------------

Status: Fixed
Labels: Feature-Extensions
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Feature-Extensions Cr-Platform-Extensions

Sign in to add a comment