Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 235457 Enable @viewport on all platforms
Starred by 13 users Project Member Reported by joh...@chromium.org, Apr 25 2013 Back to list
Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature


Sign in to add a comment
Currently meta viewport tag support is enabled at runtime on Android, but disabled on all other platforms, even touchscreens like Chromebook Pixel and Windows 8.

I spoke to Rick about this a while ago, and he said for compatibility reasons he'd rather never support the meta viewport tag on desktop, but that it would make sense to support CSS Device Adaption (@viewport) uniformly across all platforms (see also issue 155477).

The main difference being, that many sites written for meta viewport tag might assume the tag will only be applied on mobile, whereas sites using @viewport are more likely to take into account touchscreen laptops, and realise that they have to test @viewport on desktop too.

This sounds reasonable. This meta-bug tracks anything that blocks enabling @viewport on platforms other than Android.
 
Comment 1 by joh...@chromium.org, Apr 25 2013
Blocking: chromium:235464
Comment 2 by rbyers@chromium.org, Apr 25 2013
FWIW I'm now leaning towards trying to support the whole viewport meta tag on ChromeOS - see  issue 232102 .  We just need to see how many sites are broken by this (under the assumption that it's mobile-specific).

Regardless, I agree that enabling @viewport should be done for all platforms at essentially the same time.  We shouldn't propagate the mobile/desktop divide for new web platform features...
Comment 3 by r...@opera.com, Apr 29 2013
I support enabling @viewport on all platforms. There's an open issue on the implications for "desktop" browsers being discussed here: http://lists.w3.org/Archives/Public/www-style/2013Mar/0023.html

Project Member Comment 4 by bugdroid1@chromium.org, Jun 10 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=152152

------------------------------------------------------------------------
r152152 | kenneth.r.christiansen@intel.com | 2013-06-10T19:17:45.905166Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-016-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.h?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/ViewportStyleResolver.h?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-008-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/descriptor-values-001-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleRule.h?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-constructors-listing-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/cascading-003-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/descriptor-values-005-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValueKeywords.in?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPropertyNames.in?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/cssom-001-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/RuntimeEnabledFeatures.in?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSRule.idl?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSViewportRule.idl?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleSheetContents.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSViewportRule.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSRule.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSComputedStyleDeclaration.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-001-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RuleSet.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/ViewportStyleResolver.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-013-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-005-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-017-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-009-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSGrammar.y.in?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSProperty.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/descriptor-values-002-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/cascading-004-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/descriptor-values-006-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/syntax-001-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSParser.h?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.h?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8CSSRuleCustom.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-010-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-002-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-014-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSRule.h?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSViewportRule.h?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-006-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-018-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/cascading-001-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/descriptor-values-003-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/descriptor-values-007-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSParser.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/syntax-002-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/UseCounter.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-011-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-003-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-015-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-007-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/StyleRule.cpp?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-019-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/cascading-002-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/descriptor-values-004-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/syntax-003-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/features.gypi?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/FrameView.h?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-012-expected.txt?r1=152152&r2=152151&pathrev=152152
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/device-adapt/opera/constrain-004-expected.txt?r1=152152&r2=152151&pathrev=152152

Move the CSS Device Adaptation @viewport rule support behind
a runtime flag

As this is an experimental feature it is not enabled for
stable releases, but it is enabled for testing purposes or
by using the flag --enable-experimental-webkit-features and
--enable-viewport to the content_shell

Unprefix the CSSOM interface. The style rule will be unprefixed
separately as it affects all the tests

Some tests are failing now due to some changes in the tests/spec
which were added in another commit. This will be fixed in a
separate patch.

initialViewportSize was not used by Chromium (leftover from
WebKit). Hook it up directly.

BUG=235457, 155477
R=alexis.menard@intel.com, apavlov@chromium.org, johnme@chromium.org, marja@chromium.org, peter@chromium.org

Review URL: https://codereview.chromium.org/16646002
------------------------------------------------------------------------
Comment 5 by bokan@chromium.org, Jan 9 2015
Blocking: chromium:357686
Comment 6 by laforge@google.com, Jan 9 2015
Labels: -Cr-Blink-Rendering Cr-Blink-Layout
Migrate from Cr-Blink-Rendering to Cr-Blink-Layout
Comment 7 by rbyers@chromium.org, Feb 19 2015
Cc: -abarth@chromium.org
Owner: bokan@chromium.org
Status: Assigned
We'd like to try to drive this forward (eg. as a solution for issue 455471).

Comment 8 by rbyers@chromium.org, Feb 19 2015
Blocking: chromium:455471
Comment 9 by rbyers@chromium.org, Apr 27 2015
Labels: Hotlist-Input-Dev
Blockedon: chromium:528028
Project Member Comment 11 by sheriffbot@chromium.org, Jul 3 2016
Labels: Hotlist-OpenBugWithCL
A change has landed for this issue, but it's been open for over 6 months. Please review and close it if applicable. If this issue should remain open, remove the "Hotlist-OpenBugWithCL" label. If no action is taken, it will be archived in 30 days.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-OpenBugWithCL
I was wondering what we should do with this?  We've had the @viewport code behind a flag (and quite well-tested) for years now, but there's not any momentum towards launching it because in practice, we haven't seen compelling use cases.  (The dominant use of meta viewport is just "width=device-width" which is equivalent to desktop browsers' behavior anyway.)

Is it time to start thinking about deleting the implementation from Blink instead?
The discussion has been recently resurrected in https://github.com/w3c/csswg-drafts/issues/258

My read is that the current design of @viewport will never be shipped but there may be some redesign to make it less of a performance footgun. It would be nice to have something to be able to set pinch-zoom limits on desktop so I'd like to see something here ship but I don't think we should keep it around indefinitely if this fails to move forward again. Perhaps Yoav's suggestion of just adding an attribute to the viewport <meta> to make it apply on desktop is enough?
Sign in to add a comment