New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 23269 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2009
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Feature
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Browser actions: implement setIcon(ImageData)

Project Member Reported by aa@chromium.org, Sep 28 2009

Issue description

You should be able to draw the browser action icon dynamically using the 
ImageData object from canvas.
 
Status: Started
Status: Available

Comment 3 by aa@chromium.org, Oct 5 2009

Labels: ReleaseBlock-Beta

Comment 4 by aa@chromium.org, Oct 5 2009

Labels: Size-Large
Status: Started

Comment 5 by aa@chromium.org, Oct 5 2009

Labels: Pri-1
Marking this P1 because it is an important thing to try and prove works asap.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28130 

------------------------------------------------------------------------
r28130 | mpcomplete@chromium.org | 2009-10-06 11:15:58 -0700 (Tue, 06 Oct 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/values.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/values.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_extension_function.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_extension_function.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_dom_ui.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_dom_ui.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_dispatcher.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/ipc_message_utils.cc?r1=28130&r2=28129

Modify extension request IPC messages to pass a ListValue instead of a string.

This allows us to pass binary values through extension requests. I use this in
my next CL to pass SkBitmaps.

BUG= 23269 
TEST=no

Review URL: http://codereview.chromium.org/251093
------------------------------------------------------------------------

Status: Fixed
Labels: Feature-Extensions
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-4 -Feature-Extensions M-4 Cr-Platform-Extensions
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment