Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 231959 Expose and enable timeout property of XHR
Starred by 21 users Reported by dominik....@intel.com, Apr 16 2013 Back to list
Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2013
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Status: ----
Launch-Test: ----
Launch-UI: ----



Sign in to add a comment
Change description:
Implement the timeout property according to the XHR spec, mainly by adding timeout support to Chromium's ResourceHandle.cpp and default-enabling the already-implemented feature in Blink.

Changes to API surface:
* Adding timeout property to XHR
* Activate behaviors associated with that property, i.e. generate timeout events and errors.

WebKit bug: 
http://crbug.com/160077
http://wkbug.com/103251

Public standards discussion: Feature in XHR working draft http://www.w3.org/TR/XMLHttpRequest/#the-timeout-attribute

Support in other browsers: current (expected)
Internet Explorer: 9 - no, 10 - no
Firefox: yes
Safari: no 
Safari mobile: (yes)
Opera: yes (allows timeout for SYNC request)

*Make sure to fill in any labels with a -?, including all OSes this change
affects. Feel free to leave other labels at the defaults.
 
Comment 1 by meh@chromium.org, Apr 16 2013
Cc: meh@chromium.org darin@chromium.org abarth@chromium.org komoroske@chromium.org
Issue 160077 has been merged into this issue.
Comment 2 by meh@chromium.org, Apr 16 2013
Issue 231957 has been merged into this issue.
Comment 3 by meh@chromium.org, Apr 16 2013
Cc: dominik....@intel.com
Labels: -OWP-LaunchBug-Needed OWP-LaunchBug-NA OWP-Type-NewAPI OWP-Format-Unprefixed OWP-Standards-OfficialSpec
Owner: meh@chromium.org
Comment 5 by meh@chromium.org, May 9 2013
Labels: M-29
Looks like this didn't make it into M-28. Targeting M-29.
Project Member Comment 7 by bugdroid1@chromium.org, Jun 17 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=152531

------------------------------------------------------------------------
r152531 | dominik.rottsches@intel.com | 2013-06-17T09:11:30.181083Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentThreadableLoader.h?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/ThreadableLoader.h?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XMLHttpRequest.idl?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/resources/load-and-stall.php?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XMLHttpRequest.cpp?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/xml/XMLHttpRequest.h?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout.js?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/DocumentThreadableLoader.cpp?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html?r1=152531&r2=152530&pathrev=152531
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html?r1=152531&r2=152530&pathrev=152531

Implementing timeout support for XHR

Adding timeout support to DocumentThreadableLoader. Implementation in higher level of Blink's
networking stack in order to allow ResourceHandle abstraction to be reduced to WebUrlLoader after Darin's feedback
in https://codereview.chromium.org/14246006/#msg15
Remove WebKit's legacy #ifdef ENABLE_XHR_TIMEOUT and enable the feature by default.
Late timeout changes/resets after XHR is sent are not implemented at this point, will file comment on spec.

BUG= 231959 
TEST=Unskipping 11 LayoutTests in http/tests/xmlhttprequest/timeout
R=abarth@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14246006
------------------------------------------------------------------------
Status: Fixed
Issue 157421 has been merged into this issue.
Issue 133809 has been merged into this issue.
For the record, this has been available in Internet Explorer since IE8.
Issue 119500 has been merged into this issue.
Comment 14 by laforge@google.com, Jun 13 2015
Cc: drott@chromium.org
Comment 15 by laforge@google.com, Jun 13 2015
Attempting to remove dominik.rottsches@intel.com from cc.
Sign in to add a comment