New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 23057 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Google Chrome Frame Check

Reported by sanjiv.p...@gmail.com, Sep 25 2009

Issue description

Currently only Internet Explorer 6, 7, and 8 on Win7,  Vista or XP SP2
are supported.

However, the check() method redirect the user to the install page even
when there is nothing the user can install.
For example, I am using IE7 with Win2003 server, and I cannot download
anything from the ChromeFrame install page. But the check() method
still shows me the dialog.

Would it possible to redirect the user only when the user can really
download a ChromeFrame to install?
And if the user's OS + Browser combination is not supported, just skip
the check.
Because it does not help but blocked the user with the dialog.

ChromeFrame is a really great project!
Thanks!
 
Labels: -Area-Misc Area-ChromeFrame
Status: Assigned
Labels: -Pri-2 Pri-1
Labels: ReleaseBlock-Beta Mstone-4
Labels: -OS-All OS-Windows
Labels: -ReleaseBlock-Beta

Comment 7 by bugdro...@gmail.com, Nov 10 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31539 

------------------------------------------------------------------------
r31539 | slightlyoff@chromium.org | 2009-11-09 19:16:31 -0800 (Mon, 09 Nov 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/CFInstall.js?r1=31539&r2=31538
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/chrome_frame_unittests.cc?r1=31539&r2=31538
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_basic.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_dismiss.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_overlay.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_place.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/chrome_frame_tester_helpers.js?r1=31539&r2=31538
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/http_server.cc?r1=31539&r2=31538

Updates CFInstall.js to:

  * provide a new 'overlay' prompt mode that includes a "close" button with a cookie that respects the user preference for any originating site
  * handle requesting the install UI from a host page loaded from a file:// URL
  * expands UA detection to stop taunting Win2K (and below) users with visions of WebKit goodness
  * preserves full compat with previous version

BUG= 23057 , 22738 , 23132 
TEST=see new test files in this change or build chrome_frame_tests and run with: chrome_frame_tests.exe --gtest_filter=*CFInstall*

Review URL: http://codereview.chromium.org/345032
------------------------------------------------------------------------

Status: Fixed
The landing pages have been updated to allow Win2k3 users and the detection scirpts 
have been tightened up to disallow IE 6 on XP prior to SP2.

Comment 9 by bugdro...@gmail.com, Nov 19 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31539 

------------------------------------------------------------------------
r31539 | slightlyoff@chromium.org | 2009-11-09 19:16:31 -0800 (Mon, 09 Nov 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/CFInstall.js?r1=31539&r2=31538
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/chrome_frame_unittests.cc?r1=31539&r2=31538
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_basic.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_dismiss.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_overlay.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_place.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/chrome_frame_tester_helpers.js?r1=31539&r2=31538
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/http_server.cc?r1=31539&r2=31538

Updates CFInstall.js to:

  * provide a new 'overlay' prompt mode that includes a "close" button with a cookie that respects the user preference for any originating site
  * handle requesting the install UI from a host page loaded from a file:// URL
  * expands UA detection to stop taunting Win2K (and below) users with visions of WebKit goodness
  * preserves full compat with previous version

BUG= 23057 , 22738 , 23132 
TEST=see new test files in this change or build chrome_frame_tests and run with: chrome_frame_tests.exe --gtest_filter=*CFInstall*

Review URL: http://codereview.chromium.org/345032
------------------------------------------------------------------------

Labels: Area-Internals Internals-Install
Labels: -Area-Internals -Internals-Install
Fixing a bulk edit. Looks like the search query was not correct.
Labels: -Area-ChromeFrame bulkmove Feature-ChromeFrame
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-4 -Feature-ChromeFrame M-4 Cr-ChromeFrame
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment