New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 23031 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Extension Shelf on Linux doesn't use GTK theme colors

Reported by benjo...@gmail.com, Sep 25 2009

Issue description

Chrome Version       : 4.0.219.0 (Developer Build Ubuntu build 27064)
URLs (if applicable) : N/A
Other browsers tested: N/A

What steps will reproduce the problem?
1. Have an extension that uses the extension shelf
2. Options -> Personal Stuff -> Set to GTK+ theme
3. Observe the default colors aren't consistent (text comes from GTK theme, 
but background doesn't)

What is the expected result?
Shelf takes colors from GTK+ theme.

What happens instead?
Default (hard-coded?) color is used.

Please provide any additional information below. Attach a screenshot if
possible.

It appears that the shelf is getting the default text color from the 
desktop theme (when the theme is set to the GTK+ theme, at least). In that 
case, wouldn't it make sense to get the background color from GTK too?

As it is, the shelf doesn't match the rest of the UI when it is set to the 
GTK+ theme, and it can be hard to read the text in the shelf when it is set 
to a bright color.
 
Screenshot-New Tab - Chromium.png
19.0 KB View Download

Comment 1 by calebegg@gmail.com, Sep 25 2009

Labels: -OS-All -Area-Misc OS-Linux Area-BrowserUI Size-Small
Status: Untriaged

Comment 2 by e...@chromium.org, Sep 25 2009

While I can confirm that we aren't themeing the extension shelf yet, I don't know why 
your text is green there. That text is supposed to be hard coded to black.

What gtk theme are you running?

Comment 3 by benjo...@gmail.com, Sep 25 2009

Just plain "Clearlooks". (That is to say, not "Human-Clearlooks" or 
"ClearlooksClassic")

Comment 4 by e...@chromium.org, Sep 25 2009

Status: Started
Are you sure? I'm looking at Clearlooks right now and it doesn't have green and orange 
text and Clearlooks has a light gray background instead of a black one...

(Also, I've found the place where we aren't updating the CSS properly.)

Comment 5 by benjo...@gmail.com, Sep 25 2009

Yeah, I customized the colors (colors tab, under "customize..." in Ubuntu's Appearance 
Preferences). It's apparently using the input box text color, which I set as #B8EEA5. I tried changing it to a red color and reloading the extension, and the color of the 
text changed as expected (suspected?).

Comment 6 by bugdro...@gmail.com, Sep 28 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27368 

------------------------------------------------------------------------
r27368 | erg@google.com | 2009-09-28 09:54:09 -0700 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=27368&r2=27367
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc?r1=27368&r2=27367

Extensions: Listen for BROWSER_THEME_CHANGED and send updated CSS.
GTK: Listen for BROWSER_THEME_CHANGED and upload proper colors.

BUG= 23031 

Review URL: http://codereview.chromium.org/248006
------------------------------------------------------------------------

Comment 7 by e...@chromium.org, Sep 28 2009

Status: Fixed
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 19 2013

Project: chromiumos/third_party/kernel-next
Branch : chromeos-3.8
Author : Kees Cook <keescook@chromium.org>
Commit : 5527d4458b34d07e472c73bfb902620cc38311db

Code Review +1: Grant Grundler
Code Review +2: Sonny Rao
Verified    +1: Kees Cook
Change-Id     : I1fce3783adf65f3ce87e8b2addb792e7050adcbc
Reviewed-at   : https://gerrit.chromium.org/gerrit/62431

CHROMIUM: panic: call panic handlers before kmsg_dump

Since the panic handlers may produce additional information for the
kernel log, it should be reported as part of the panic output saved by
kmsg_dump(). Without this, stuff like the kASLR offset is not visible
in pstore, and therefore not visible to crash reporters.

BUG= chromium:23031 
TEST=manual crashing of a kASLR kernel shows offset in crash reports.

Signed-off-by: Kees Cook <keescook@chromium.org>

M  kernel/panic.c

Sign in to add a comment