New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2013
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 226192
issue 231003



Sign in to add a comment
link

Issue 230124: Support SPDY/4

Reported by akalin@chromium.org, Apr 10 2013 Project Member

Issue description

Support SPDY/4
 

Comment 1 by akalin@chromium.org, Apr 10 2013

SPDY/4 alpha 1 will have the framing changes and stream flow control
SPDY/4 alpha 2 will have the new framing changes from httpbis
SPDY/4 alpha 3 will (probably) have the new prioritization

Unclear when the new compressor will come in.

Comment 2 by bugdroid1@chromium.org, Apr 12 2013

Project Member
------------------------------------------------------------------------
r193832 | akalin@chromium.org | 2013-04-12T02:42:32.294614Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/ssl_client_socket.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory.h?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.h?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session.h?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_http_stream.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_test_util_spdy3.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_test_util_spdy3.h?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_protocol.h?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session_spdy3_unittest.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_info.h?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_framer.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/next_proto.h?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction_spdy3_unittest.cc?r1=193832&r2=193831&pathrev=193832
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_network_transaction_spdy3_unittest.cc?r1=193832&r2=193831&pathrev=193832

[SPDY] Add flag and about:flags entry for SPDY/4 alpha 1

BUG= 230124 

Review URL: https://codereview.chromium.org/13845012
------------------------------------------------------------------------

Comment 3 by toni.m.k...@gmail.com, Apr 12 2013

I'm not sure what happened but when I enabled SPDY/4 alpha 1 any website which I tried to open didn't open, chrome:// didn't open either.

I have Windows 7 Professional x64 SP1 and Chromium 28.0.1476.0 (193873).

Comment 4 by akalin@chromium.org, Apr 12 2013

SPDY/4a1 is only used if the server speaks it, so it's doubtful that turning it on would cause *all* sites to stop working. You can open chrome://net-internals and look at the SPDY tab to find out which sites are using which versions of SPDY.

That having been said, it's usually not a good idea to enable something in about:flags unless you know exactly what it is doing. :) In this case, it's unlikely to be useful unless you're hacking on SPDY/4.

Comment 5 by akalin@chromium.org, Apr 13 2013

Blockedon: chromium:231003
#3, you may be hitting the problem described in 231003.

Comment 6 by bugdroid1@chromium.org, May 15 2013

Project Member
------------------------------------------------------------------------
r200342 | akalin@chromium.org | 2013-05-15T20:42:36.307328Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session_spdy3_unittest.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_http_stream_spdy3_unittest.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_framer_test.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_framer.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/next_proto.h?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_network_transaction_spdy3_unittest.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/ssl_client_socket.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_test_util_common.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.h?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory.h?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_frame_builder_test.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_frame_builder.cc?r1=200342&r2=200341&pathrev=200342
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_frame_builder.h?r1=200342&r2=200341&pathrev=200342

[SPDY] Incorporate latest framing changes from HTTP2 into SPDY 4 as SPDY 4a2.
Removes support for SPDY 4a1.

Remove --enable-spdy4 flag for now (until we get test
coverage).

This lands server change 45362310.

BUG= 230124 
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14189003
------------------------------------------------------------------------

Comment 7 by akalin@chromium.org, Jun 11 2013

Blockedon: chromium:226192

Comment 8 by bugdroid1@chromium.org, Jun 27 2013

Project Member
------------------------------------------------------------------------
r208997 | akalin@chromium.org | 2013-06-27T20:52:43.282738Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_job_unittest.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/next_proto.h?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_proxy_client_socket_pool_unittest.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session_unittest.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.h?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_test_util_common.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_proxy_client_socket_unittest.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_test_util_common.h?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_http_stream_unittest.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_stream_unittest.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction_unittest.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_network_transaction_unittest.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_websocket_stream_unittest.cc?r1=208997&r2=208996&pathrev=208997
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory_impl.cc?r1=208997&r2=208996&pathrev=208997

[SPDY] Enable tests for SPDY/3.1 and SPDY/4a2

Make the sending of the initial stream window size part
of SpdySession::SendInitialSettings(). Since this is
already turned off for tests, this makes it a lot easier
to enable tests for SPDY/3.1 and above, since we don't
have to conditionally expect the initial WINDOW_UPDATE
frame.

Actually test handling of Alternate-Protocol header in
http_network_transaction_unittest.cc.

Fix handling of SPDY/3.1 and above in AlternateProtocolToString()
and HttpStreamFactoryImpl::GetAlternateProtocolRequestFor().

Other misc. cleanup.

BUG= 230124 
R=rch@chromium.org

Review URL: https://codereview.chromium.org/17760008
------------------------------------------------------------------------

Comment 11 by akalin@chromium.org, Jun 28 2013

the SPDY/4a2 about:flag is in latest canary (30.0.1550)

Comment 12 by akalin@chromium.org, Jul 16 2013

Status: Fixed

Comment 13 by laforge@google.com, Mar 4 2015

Labels: -Cr-Internals-Network-SPDY Cr-Internals-Network-HTTP2
Migrate from Cr-Internals-Network-SPDY to Cr-Internals-Network-HTTP2

Sign in to add a comment