New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 229615 link

Starred by 11 users

Issue metadata

Status: Assigned
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on:
issue 154769
issue 229166
issue 229468
issue 229926



Sign in to add a comment

[META][CSS Blending] Implement CSS blending specification in Chromium

Reported by caban...@gmail.com, Apr 9 2013

Issue description

The CSS blending and compositing spec describes several areas where blending and compositing can happen.
This is the master bug to manage all the different features.

W3C spec: https://dvcs.w3.org/hg/FXTF/rawfile/default/compositing/index.html
WK Bugs: wkbug.com/110427, wkbug.com/91908, wkbug.com/100069, wkbug.com/108546




 

Comment 1 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 18 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=162219

------------------------------------------------------------------------
r162219 | mitica@adobe.com | 2013-11-18T18:44:51.323664Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderObject.h?r1=162219&r2=162218&pathrev=162219
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/isolation-isolate-blended-child-expected.html?r1=162219&r2=162218&pathrev=162219
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/isolation-isolate-blended-child.html?r1=162219&r2=162218&pathrev=162219
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleAdjuster.cpp?r1=162219&r2=162218&pathrev=162219
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/RenderStyle.cpp?r1=162219&r2=162218&pathrev=162219
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/isolation-isolate-simple-expected.txt?r1=162219&r2=162218&pathrev=162219
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/RenderStyle.h?r1=162219&r2=162218&pathrev=162219
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderObject.cpp?r1=162219&r2=162218&pathrev=162219
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/isolation-isolate-simple.html?r1=162219&r2=162218&pathrev=162219

[Blending and compositing] Implement the isolation CSS property in software
Spec: http://dev.w3.org/fxtf/compositing-1/#isolation
Implement "isolation:isolate" for HTML elements under the compositing runtime flag.

BUG=229615

Review URL: https://codereview.chromium.org/75303002
------------------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 20 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=162360

------------------------------------------------------------------------
r162360 | mitica@adobe.com | 2013-11-20T13:25:30.122121Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/isolation-isolate-simple.html?r1=162360&r2=162359&pathrev=162360
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderObject.h?r1=162360&r2=162359&pathrev=162360
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/isolation-isolate-simple-expected.txt?r1=162360&r2=162359&pathrev=162360
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderObject.cpp?r1=162360&r2=162359&pathrev=162360

[CSS Blending] Fix isolation for the hardware path.
For "isolation:isolate" with accelerated elements, an ASSERT was
triggered in RenderLayerCompositor::subtreeReasonsForCompositing.
This was caused by errorneously including |hasIsolation| to RenderObject::CreateGroup.
Also, removing the comment from the method since it is misleading.

BUG=229615

Review URL: https://codereview.chromium.org/77723004
------------------------------------------------------------------------
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 27 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=162763

------------------------------------------------------------------------
r162763 | rosca@adobe.com | 2013-11-27T15:08:24.815308Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/mix-blend-mode-with-opacity-change-js-expected.html?r1=162763&r2=162762&pathrev=162763
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/mix-blend-mode-with-opacity-change-js.html?r1=162763&r2=162762&pathrev=162763
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderLayer.cpp?r1=162763&r2=162762&pathrev=162763

[CSS Blending] Fix blending when mix-blend-mode is set from javascript

If mix-blend-mode is set from javascript to an element that is also a
stacking context, blending is not limited to the parent stacking
context.

BUG=229615

Review URL: https://codereview.chromium.org/90983002
------------------------------------------------------------------------
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 17 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=164026

------------------------------------------------------------------------
r164026 | mitica@adobe.com | 2013-12-17T18:03:55.005509Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=164026&r2=164025&pathrev=164026
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderLayer.cpp?r1=164026&r2=164025&pathrev=164026

[CSS Blending] When applying mix-blend-mode on an element,
its contents and its children should blend as a whole with the
backdrop.

BUG=229615

Review URL: https://codereview.chromium.org/104663003
------------------------------------------------------------------------
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 17 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=164028

------------------------------------------------------------------------
r164028 | mitica@adobe.com | 2013-12-17T18:40:44.864140Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/style/RenderStyle.cpp?r1=164028&r2=164027&pathrev=164028
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGRenderingContext.cpp?r1=164028&r2=164027&pathrev=164028
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/svg-isolation-default-expected.html?r1=164028&r2=164027&pathrev=164028
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/svg-isolation-default.html?r1=164028&r2=164027&pathrev=164028
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/svg-isolation-simple-expected.html?r1=164028&r2=164027&pathrev=164028
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/svg-isolation-simple.html?r1=164028&r2=164027&pathrev=164028
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/svg-isolation-isolated-group-expected.html?r1=164028&r2=164027&pathrev=164028
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/svg-isolation-isolated-group.html?r1=164028&r2=164027&pathrev=164028

[CSS Blending] Implement the isolation property for SVG.

This patch adds the isolation functionality to SVG, performs
some cleanup on the current blend modes SVG implementation
and adds tests to validate the feature.

BUG=229615

Review URL: https://codereview.chromium.org/108163004
------------------------------------------------------------------------
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 6 2014

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=164504

------------------------------------------------------------------------
r164504 | mitica@adobe.com | 2014-01-06T11:27:22.539149Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/svg-blend-overlapping-elements-expected.html?r1=164504&r2=164503&pathrev=164504
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/svg/SVGRenderingContext.cpp?r1=164504&r2=164503&pathrev=164504
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/css3/compositing/svg-blend-overlapping-elements.html?r1=164504&r2=164503&pathrev=164504

[CSS Blending] SVG overlapping elements within a group don't blend together.

For a group of overlapping elements in an SVG, if mix-blend-mode is
specified on the group, the intersection of any overlapping elements also
incorrectly blends. This patch addresses the issue.
The problem is similar to https://codereview.chromium.org/104663003/

BUG=229615

Review URL: https://codereview.chromium.org/98543012
------------------------------------------------------------------------
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 7 2014

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=164547

------------------------------------------------------------------------
r164547 | ojan@chromium.org | 2014-01-07T02:57:47.282877Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/css3/compositing/mix-blend-mode-simple-text-expected.png?r1=164547&r2=164546&pathrev=164547
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/css3/compositing/mix-blend-mode-simple-text-expected.png?r1=164547&r2=164546&pathrev=164547
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=164547&r2=164546&pathrev=164547
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/css3/compositing/mix-blend-mode-simple-text-expected.png?r1=164547&r2=164546&pathrev=164547
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/css3/compositing/mix-blend-mode-simple-text-expected.png?r1=164547&r2=164546&pathrev=164547
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/css3/compositing/mix-blend-mode-isolated-group-3-expected.png?r1=164547&r2=164546&pathrev=164547
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/css3/compositing/mix-blend-mode-isolated-group-3-expected.png?r1=164547&r2=164546&pathrev=164547
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/css3/compositing/mix-blend-mode-isolated-group-3-expected.png?r1=164547&r2=164546&pathrev=164547

Auto-rebaseline for r164026

http://src.chromium.org/viewvc/blink?view=revision&revision=164026

BUG=229615
TBR=mitica@adobe.com

Review URL: https://codereview.chromium.org/123463008
------------------------------------------------------------------------
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 22 2014

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=167622

------------------------------------------------------------------------
r167622 | mitica@adobe.com | 2014-02-22T00:45:06.633183Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RuntimeCSSEnabled.cpp?r1=167622&r2=167621&pathrev=167622
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt?r1=167622&r2=167621&pathrev=167622
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/parser/BisonCSSParser-in.cpp?r1=167622&r2=167621&pathrev=167622

Expose the CSS background-blend-mode property,
part of the CSS Blending and Compositing spec.
The change consists of removing the property from under the
cssCompositing() runtime flag.

BUG=229615

Review URL: https://codereview.chromium.org/174903002
------------------------------------------------------------------------
Cc: mihnea.a...@gmail.com
Summary: [META] Implement CSS blending specification in Chromium (was: Implement CSS blending specification in Chromium)
Blockedon: chromium:229468
Cc: ro...@adobe.com
Summary: [META][CSS Blending] Implement CSS blending specification in Chromium (was: [META] Implement CSS blending specification in Chromium)
Blockedon: chromium:229166
Blockedon: chromium:154769
Blockedon: chromium:229926
Project Member

Comment 18 by sheriffbot@chromium.org, Jul 3 2016

Labels: Hotlist-OpenBugWithCL
A change has landed for this issue, but it's been open for over 6 months. Please review and close it if applicable. If this issue should remain open, remove the "Hotlist-OpenBugWithCL" label. If no action is taken, it will be archived in 30 days.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-OpenBugWithCL
Removing Hotlist-OpenBugWithCL label as this bug has blocked on issue.
Components: Blink>CSS
Labels: Update-Quarterly
Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Labels: -Update-Quarterly

Sign in to add a comment