New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 22768 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Chrome Frame Crashes IE 8 on New Tab

Reported by laurinke...@gmail.com, Sep 23 2009

Issue description

Chrome Version       : <Copy from: 'about:version'>
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 4:
Firefox 3.x:
IE 7:
         IE 8:OK

What steps will reproduce the problem?
1.Open New Tab where Home Page has the meta tag to activate Chrome Frame
2.
3.

What is the expected result?


What happens instead?


Please provide any additional information below. Attach a screenshot if
possible.

 
Labels: FeedbackRequested
Can you please give us the steps to repro this issue?
When I open a new tab, either by clicking New Tab or by clicking an external link 
that opens one, about 50% of the time I get an error message that Internet Explorer 
has stopped working.

Actually, my description above may be incorrect. That depends on whether or not IE 
opens the Home Page when an external link is clicked and IE is set to open the Home 
Page when a new tab is opened (which mine is.) My Home Page is set to a page that 
uses the meta tag.
I've tried that and it doesn't crash for me. Can you please point me to that webpage 
which is your homepage? 
Also, go to start > Run > Type eventvwr. Select Application and check if you have any 
events recorded with source=chrome. Open that event and you should find a Crash Id. 
Please post that, if you can.
The site is on our Intranet, and you can't access it. 

However, I did find some events in the logs, but they are not source=chrome. Here's 
one, do you want the rest:

Log Name:      Application
Source:        Application Error
Date:          9/23/2009 11:23:00 AM
Event ID:      1000
Task Category: (100)
Level:         Error
Keywords:      Classic
User:          N/A
Computer:      KDAVIS.pridedallas.com
Description:
Faulting application iexplore.exe, version 8.0.6001.18813, time stamp 0x4a6621ae, 
faulting module npchrome_tab.dll_unloaded, version 0.0.0.0, time stamp 0x4ab83764, 
exception code 0xc0000005, fault offset 0x6765f895, process id 0x1a10, application 
start time 0x01ca3c69e7825414.
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Application Error" />
    <EventID Qualifiers="0">1000</EventID>
    <Level>2</Level>
    <Task>100</Task>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2009-09-23T16:23:00.000Z" />
    <EventRecordID>7755</EventRecordID>
    <Channel>Application</Channel>
    <Computer>KDAVIS.pridedallas.com</Computer>
    <Security />
  </System>
  <EventData>
    <Data>iexplore.exe</Data>
    <Data>8.0.6001.18813</Data>
    <Data>4a6621ae</Data>
    <Data>npchrome_tab.dll_unloaded</Data>
    <Data>0.0.0.0</Data>
    <Data>4ab83764</Data>
    <Data>c0000005</Data>
    <Data>6765f895</Data>
    <Data>1a10</Data>
    <Data>01ca3c69e7825414</Data>
  </EventData>
</Event>
Labels: -Area-Misc Area-ChromeFrame
Amit or Alex might help.

Comment 6 by ananta@chromium.org, Sep 25 2009

Comment 7 by bugdro...@gmail.com, Sep 25 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27191 

------------------------------------------------------------------------
r27191 | ananta@chromium.org | 2009-09-25 09:04:43 -0700 (Fri, 25 Sep 2009) | 16 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/bho.cc?r1=27191&r2=27190
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/protocol_sink_wrap.cc?r1=27191&r2=27190
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/protocol_sink_wrap.h?r1=27191&r2=27190
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/vtable_patch_manager.cc?r1=27191&r2=27190

This fixes a crash in IE8 with ChromeFrame when a new tab was created. 

ChromeFrame VTable patches the IInternetProtocol interface for the CLSID_HttpProtocol
and CLSID_HttpSProtocol handlers. However we were using the same VTable information to patch both
the handlers essentially overwriting the first one. While this all worked purely by chance, it
exposed a bug in IE8 where every new tab initially goes into a new process and if the chromeframe 
is unloaded we would leave behind an IInternetProtocol interface in urlmon patched, which would
crash when dereferenced.

Added a check in the VTable patching code for this case.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=22768

Bug= 22768 

Review URL: http://codereview.chromium.org/244002
------------------------------------------------------------------------

Comment 8 by ananta@chromium.org, Sep 25 2009

Status: Fixed
Remove label: Feedback Requested.
New Revision: 27191

Log:
This fixes a crash in IE8 with ChromeFrame when a new tab was created.

ChromeFrame VTable patches the IInternetProtocol interface for the CLSID_HttpProtocol
and CLSID_HttpSProtocol handlers. However we were using the same VTable information 
to patch both
the handlers essentially overwriting the first one. While this all worked purely by 
chance, it
exposed a bug in IE8 where every new tab initially goes into a new process and if the 
chromeframe
is unloaded we would leave behind an IInternetProtocol interface in urlmon patched, 
which would
crash when dereferenced.

Added a check in the VTable patching code for this case.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=22768

Bug= 22768 

Review URL: http://codereview.chromium.org/244002

Comment 11 Deleted

 Issue 24873  has been merged into this issue.
Labels: -FeedbackRequested bulkmove Action-FeedbackNeeded
Chrome Version       : &lt;Copy from: 'about:version'&gt;
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 4:
Firefox 3.x:
IE 7:
         IE 8:OK

What steps will reproduce the problem?
1.Open New Tab where Home Page has the meta tag to activate Chrome Frame
2.
3.

What is the expected result?


What happens instead?


Please provide any additional information below. Attach a screenshot if
possible.
Labels: -Area-ChromeFrame Feature-ChromeFrame
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Action-FeedbackNeeded Needs-Feedback
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Feature-ChromeFrame Cr-ChromeFrame

Sign in to add a comment