New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 22760 link

Starred by 7 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2011
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

IE User Agent string contains 'chromeframe' string even when chromeframe add-on is disabled in IE

Reported by darren.k...@digicom.net.au, Sep 23 2009

Issue description

Chrome Version       : chromeframe
URLs (if applicable) : NA
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 4:
Firefox 3.x:
IE 7:
         IE 8: FAIL

What steps will reproduce the problem?

1. Install chromeframe into IE8
2. Restart IE8
3. Verify 'chromeframe' string is part of browser user agent string
4. Disable chromeframe add-on in IE8's Tools -> Manage Add-ons menu
5. Restart IE8

What is the expected result?

'chromeframe' should no longer be added to browser user agent string

What happens instead?

'chromeframe' is still added to browser user agent string even though
plugin is disabled.  ChromeFrame renderer does not function as expected.

eg. this was captured with the chromeframe add-on disabled.

Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; GTB6;
chromeframe; SLCC1; .NET CLR 2.0.50727; .NET CLR 3.5.30729; InfoPath.1;
.NET CLR 3.0.30729

 
Labels: -Area-Misc Area-ChromeFrame
for best scalability I would like to suggest what I have already said in the ML
Being the UA meta forced with chromeframe=1, where I guess 1 means "true" or "on", I
would use same strategy for the UA string when the plugin is disabled.

chromeframe installed but disabled, the UA will contain chromeframe=0
chromeframe installed and enabled, the UA contain chromeframe=1

If one day there will be possibility to decide which version of the plugin we would
like to run, chromeframe=2 or 4, or 5, to keep Chrome main revision consistent with
the chose one (so right now it should be chromeframe=4 , since this seems to be the
main revision)

Makes sense?
Status: WontFix
After a long discussion with Amit, we've decided not to fix this. Our options were:

  * patch vtables in order to modify the UA string for every request (brittle and 
problematic but would handle this)
  * implement an alternative form of disabling (toolbar UI, etc.) but leave the issue 
essentially untouched
  * implement a right-click style menu for "reload this page without GCF" and inform 
users that if they want to fully disable GCF, they should uninstall it.

We're opting for the 3rd.

Comment 4 by amit@chromium.org, Oct 6 2009

Status: Assigned
I am going to regret this but Tommi, go ahead with your fix. :)
Issue 23994 has been merged into this issue.
Labels: Mstone-4 ReleaseBlock-Beta
Labels: -OS-All OS-Windows

Comment 9 by bugdro...@gmail.com, Oct 19 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29370 

------------------------------------------------------------------------
r29370 | tommi@chromium.org | 2009-10-16 21:48:37 -0700 (Fri, 16 Oct 2009) | 2 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/bho.cc?r1=29370&r2=29369
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame.gyp?r1=29370&r2=29369
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_tab.cc?r1=29370&r2=29369
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/html_utils.cc?r1=29370&r2=29369
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/html_utils.h?r1=29370&r2=29369
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/http_negotiate.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/http_negotiate.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/protocol_sink_wrap.cc?r1=29370&r2=29369
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/protocol_sink_wrap.h?r1=29370&r2=29369
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/html_util_unittests.cc?r1=29370&r2=29369
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/http_negotiate_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/utils.h?r1=29370&r2=29369
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/vtable_patch_manager.cc?r1=29370&r2=29369
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/vtable_patch_manager.h?r1=29370&r2=29369

Add the chromeframe tag to the user agent header at runtime instead of statically in the registry.TEST=Try disabling GCF and see if the chromeframe tag in the user agent is still set.  It should not be. Also make sure you don't have an older version installed... the chromeframe tag should not be in the registry - if it is, you've got an older version still registered.  This should fix the issue with going to wave.google.com after disabling chrome frame and seeing the white page of death.R=amitBUG=22760
Review URL: http://codereview.chromium.org/259025
------------------------------------------------------------------------

Labels: Area-Internals Internals-Install
Labels: -Area-Internals -Internals-Install
Fixing a bulk edit. Looks like the search query was not correct.

Comment 12 by *mdu@chromium.org, Feb 5 2010

Labels: -Pri-2 Pri-1 Regression
Status: Untriaged
This issue come back again in build 5.0.317.0 (Official Build 38070), have to reopen it.

This is a regression.

Comment 13 by amit@chromium.org, Feb 8 2010

Status: Assigned
The code for this hasn't changed, so it would be nice if the following could be 
verified:
1. Was IE restarted after disabling the BHO? No other instance of IE was running?
2. Is "chromeframe" present under 
HKLM\Software\Microsoft\Windows\CurrentVersion\Internet Settings\User Agent\Post 
Platform



Comment 14 by *mdu@chromium.org, Feb 8 2010

Status: Verified
I didn't find a "chromeframe" under HKLM but I found it under HKCU, after I deleted
it IE becomes work fine.

It seems this is a legacy problem, close it then.

Comment 15 by *mdu@chromium.org, Jan 19 2011

Labels: -ReleaseBlock-Beta
There seems a regression here, it happens again on build 10.0.642.0 (Official Build 71626), with IE6/XP SP3

Note: there is a string like "chromeframe/10.0.642.0" under HKLM\Software\Microsoft\Windows\CurrentVersion\Internet Settings\User Agent\Post Platform

Comment 16 by *mdu@chromium.org, Jan 19 2011

Status: Untriaged

Comment 17 by *mdu@chromium.org, Jan 19 2011

Labels: -Pri-1 -Mstone-4 Pri-2

Comment 18 by tommi@chromium.org, Jan 19 2011

Status: WontFix
Yes, this has regressed but we've decided to live with it as is for now.
Thanks for keeping a watchful eye.
Labels: -Regression bulkmove Type-Regression
Chrome Version       : chromeframe
URLs (if applicable) : NA
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 4:
Firefox 3.x:
IE 7:
         IE 8: FAIL

What steps will reproduce the problem?

1. Install chromeframe into IE8
2. Restart IE8
3. Verify 'chromeframe' string is part of browser user agent string
4. Disable chromeframe add-on in IE8's Tools -> Manage Add-ons menu
5. Restart IE8

What is the expected result?

'chromeframe' should no longer be added to browser user agent string

What happens instead?

'chromeframe' is still added to browser user agent string even though
plugin is disabled.  ChromeFrame renderer does not function as expected.

eg. this was captured with the chromeframe add-on disabled.

Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; GTB6;
chromeframe; SLCC1; .NET CLR 2.0.50727; .NET CLR 3.5.30729; InfoPath.1;
.NET CLR 3.0.30729
Labels: -Area-ChromeFrame Feature-ChromeFrame
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Feature-ChromeFrame Type-Bug-Regression Cr-ChromeFrame

Sign in to add a comment