New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 22738 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit 17 days ago
Closed: Nov 2009
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

CFInstall.js doesn't allow to dismiss installation iframe

Reported by bragi.ra...@gmail.com, Sep 23 2009

Issue description

Chrome Version       : http://ajax.googleapis.com/ajax/libs/chrome-
frame/1/CFInstall.min.js
Other browsers tested:
         IE 6: Fail

What steps will reproduce the problem?
1. Add meta to opt in for Google Chrome Frame from 
http://code.google.com/chrome/chromeframe/developers_guide.html
2. Add CFInstall JavaScript code
3. Open page in IE6
4. Frame with instructions to install Google Chrome Frame cover the page 
and there is no way to cancel installation.

What is the expected result?

There should be a 'Cancel' button together with possibly 'X' button near 
the right top corner of the iframe (or in the div containing the iframe) that 
allows to cancel plugin installation and use page in IE.

Rationale:

Not everyone has administrator rights on their computer or even WANT to 
install another plugin. Maybe they want just to check out the page.

Additional points for:

- Adding a notification that the site may not look as expected when 
viewed without a plugin
- Allow user to dismiss this dialog until next visit/never show this dialog 
again

What happens instead?


Please provide any additional information below. Attach a screenshot if
possible.

 
Labels: -Area-Misc Area-ChromeFrame

Comment 2 by *mdu@chromium.org, Oct 2 2009

Status: Assigned
Labels: ReleaseBlock-Beta Mstone-4
Labels: -OS-All OS-Windows

Comment 5 by bugdro...@gmail.com, Nov 10 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31539 

------------------------------------------------------------------------
r31539 | slightlyoff@chromium.org | 2009-11-09 19:16:31 -0800 (Mon, 09 Nov 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/CFInstall.js?r1=31539&r2=31538
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/chrome_frame_unittests.cc?r1=31539&r2=31538
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_basic.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_dismiss.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_overlay.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_place.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/chrome_frame_tester_helpers.js?r1=31539&r2=31538
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/http_server.cc?r1=31539&r2=31538

Updates CFInstall.js to:

  * provide a new 'overlay' prompt mode that includes a "close" button with a cookie that respects the user preference for any originating site
  * handle requesting the install UI from a host page loaded from a file:// URL
  * expands UA detection to stop taunting Win2K (and below) users with visions of WebKit goodness
  * preserves full compat with previous version

BUG= 23057 , 22738 , 23132 
TEST=see new test files in this change or build chrome_frame_tests and run with: chrome_frame_tests.exe --gtest_filter=*CFInstall*

Review URL: http://codereview.chromium.org/345032
------------------------------------------------------------------------

Status: Fixed
update pushed to CDN.

Comment 7 by bugdro...@gmail.com, Nov 19 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31539 

------------------------------------------------------------------------
r31539 | slightlyoff@chromium.org | 2009-11-09 19:16:31 -0800 (Mon, 09 Nov 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/CFInstall.js?r1=31539&r2=31538
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/chrome_frame_unittests.cc?r1=31539&r2=31538
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_basic.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_dismiss.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_overlay.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_place.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/chrome_frame_tester_helpers.js?r1=31539&r2=31538
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/http_server.cc?r1=31539&r2=31538

Updates CFInstall.js to:

  * provide a new 'overlay' prompt mode that includes a "close" button with a cookie that respects the user preference for any originating site
  * handle requesting the install UI from a host page loaded from a file:// URL
  * expands UA detection to stop taunting Win2K (and below) users with visions of WebKit goodness
  * preserves full compat with previous version

BUG= 23057 , 22738 , 23132 
TEST=see new test files in this change or build chrome_frame_tests and run with: chrome_frame_tests.exe --gtest_filter=*CFInstall*

Review URL: http://codereview.chromium.org/345032
------------------------------------------------------------------------

Labels: Area-Internals Internals-Install
Labels: -Area-Internals -Internals-Install
Fixing a bulk edit. Looks like the search query was not correct.
Labels: -Area-ChromeFrame bulkmove Feature-ChromeFrame
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-4 -Feature-ChromeFrame M-4 Cr-ChromeFrame
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment