New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 22654 link

Starred by 12 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Nov 2009
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

focus traversal doesn't work in extension views

Reported by erikkay@chromium.org, Sep 22 2009

Issue description

Make a toolstrip or a mole with some form elements.  Put focus into one and 
then try to tab to the next one.  All that happens is that the first one 
loses focus.  I'm sure there's some basic machinery that we haven't hooked up 
here.  

cc'ing Jay since he knows the focus logic well.
 
I'll look at it

Comment 2 by aa@chromium.org, Oct 12 2009

Status: WontFix
The extensions team has decided that we like browser actions 
(code.google.com/p/chromium/w/edit/BrowserActions) better than toolstrips, 
and will be removing toolstrips before beta. So please don't do any more work 
on toolstrips.
 Issue 25523  has been merged into this issue.
Status: Assigned
this is not specific to toolstrips or moles, but rather all extension views, including browser action popups
Labels: ReleaseBlock-Beta
This seems worth fixing in time for our Beta release.

Jay, do you have bandwidth to work on this?
I'll take a look.
Also, dunno if this is related or not, but when the popup of a browser action opens it 
doesn't get the focus which is pretty annoying because if, for example, i have a 
textbox (like a search box) in it, the user has to click it before typing (tried every 
possible way to set focus programmaticaly =]).

Comment 8 by aa@chromium.org, Nov 11 2009

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable

Comment 9 by aa@chromium.org, Nov 16 2009

Labels: Feature-Extensions
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32335 

------------------------------------------------------------------------
r32335 | jcampan@chromium.org | 2009-11-18 09:36:33 -0800 (Wed, 18 Nov 2009) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=32335&r2=32334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=32335&r2=32334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_bubble_win.cc?r1=32335&r2=32334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_view.cc?r1=32335&r2=32334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_view.h?r1=32335&r2=32334

Fixes several focus issue with popup in the extensions' browser actions:
- when opening a browser action popup, it gets the focus.
- tab traversal now works in the popup
- pressing esc closes the popup (if the keyboard event is not processed by the page)

BUG= 22654 ,  28087 ,  28086 
TEST=Create an extension with a browser extension that shows a popup. Make the popup
     so that it has a textfield (that gets focused when the popup show) and a button.
     Install the extension. Open the popup, the textfield should have focus. Press
     tab, the focus should go to the button. Press Esc, the popup should be closed.

Review URL: http://codereview.chromium.org/402036
------------------------------------------------------------------------

Status: Fixed
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32335 

------------------------------------------------------------------------
r32335 | jcampan@chromium.org | 2009-11-18 09:36:33 -0800 (Wed, 18 Nov 2009) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=32335&r2=32334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=32335&r2=32334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_bubble_win.cc?r1=32335&r2=32334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_view.cc?r1=32335&r2=32334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_view.h?r1=32335&r2=32334

Fixes several focus issue with popup in the extensions' browser actions:
- when opening a browser action popup, it gets the focus.
- tab traversal now works in the popup
- pressing esc closes the popup (if the keyboard event is not processed by the page)

BUG= 22654 ,  28087 ,  28086 
TEST=Create an extension with a browser extension that shows a popup. Make the popup
     so that it has a textfield (that gets focused when the popup show) and a button.
     Install the extension. Open the popup, the textfield should have focus. Press
     tab, the focus should go to the button. Press Esc, the popup should be closed.

Review URL: http://codereview.chromium.org/402036
------------------------------------------------------------------------

Labels: Mstone-4
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32529 

------------------------------------------------------------------------
r32529 | jcampan@chromium.org | 2009-11-19 11:16:08 -0800 (Thu, 19 Nov 2009) | 16 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_host.cc?r1=32529&r2=32528
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/browser_actions_container.cc?r1=32529&r2=32528
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/browser_bubble_win.cc?r1=32529&r2=32528
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/extensions/extension_view.cc?r1=32529&r2=32528
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/extensions/extension_view.h?r1=32529&r2=32528

Merge 32335
Fixes several focus issue with popup in the extensions' browser actions:
 when opening a browser action popup, it gets the focus.
 tab traversal now works in the popup
 pressing esc closes the popup (if the keyboard event is not processed by the page)

BUG= 22654 ,  28087 ,  28086 
TEST=Create an extension with a browser extension that shows a popup. Make the popup
     so that it has a textfield (that gets focused when the popup show) and a button.
     Install the extension. Open the popup, the textfield should have focus. Press
     tab, the focus should go to the button. Press Esc, the popup should be closed.

Review URL: http://codereview.chromium.org/402036

TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/415001
------------------------------------------------------------------------

Status: Verified
Works fine with Google Chrome 4.0.249.11 (Official Build 32790)
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32529 

------------------------------------------------------------------------
r32529 | jcampan@chromium.org | 2009-11-19 11:16:08 -0800 (Thu, 19 Nov 2009) | 16 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_host.cc?r1=32529&r2=32528
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/browser_actions_container.cc?r1=32529&r2=32528
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/browser_bubble_win.cc?r1=32529&r2=32528
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/extensions/extension_view.cc?r1=32529&r2=32528
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/extensions/extension_view.h?r1=32529&r2=32528

Merge 32335
Fixes several focus issue with popup in the extensions' browser actions:
 when opening a browser action popup, it gets the focus.
 tab traversal now works in the popup
 pressing esc closes the popup (if the keyboard event is not processed by the page)

BUG= 22654 ,  28087 ,  28086 
TEST=Create an extension with a browser extension that shows a popup. Make the popup
     so that it has a textfield (that gets focused when the popup show) and a button.
     Install the extension. Open the popup, the textfield should have focus. Press
     tab, the focus should go to the button. Press Esc, the popup should be closed.

Review URL: http://codereview.chromium.org/402036

TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/415001
------------------------------------------------------------------------

Labels: Area-Internals Internals-Install
Labels: -Area-Internals -Internals-Install
Fixing a bulk edit. Looks like the search query was not correct.
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 20 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Feature-Extensions -Mstone-4 M-4 Cr-Platform-Extensions
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment