New issue
Advanced search Search tips
Starred by 24 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature


Sign in to add a comment

Implement CSS3 Box Alignment spec

Project Member Reported by cbiesin...@chromium.org, Apr 3 2013

Issue description

Migrated from WebKit Bugzilla: https://bugs.webkit.org/show_bug.cgi?id=111616
Originally reported 2013-03-06 12:37 PST by Christian Biesinger (cbiesinger@chromium.org).
URL: http://dev.w3.org/csswg/css3-align/


Description:
See URL. Basically allows justify-content, align-items, etc. to apply to any box, not just flex items.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2013

Labels: -WebKit-ID-111616 WebKit-ID-111616-NEW
https://bugs.webkit.org/show_bug.cgi?id=111616

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2013

Labels: Cr-Blink
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content-CSS Cr-Blink-CSS

Comment 4 by ojan@chromium.org, Oct 16 2014

Cc: -ojan@chromium.org
Blockedon: chromium:474798
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 26 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=194466

------------------------------------------------------------------
r194466 | jfernandez@igalia.com | 2015-04-26T21:02:11.458220Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleBuilderConverter.cpp?r1=194466&r2=194465&pathrev=194466
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/style/StyleContentAlignmentData.h?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleAdjuster.cpp?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleBuilderCustom.cpp?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleBuilderConverter.h?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutGrid.cpp?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/ComputedStyle.cpp?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutBox.cpp?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/ComputedStyle.h?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl?r1=194466&r2=194465&pathrev=194466
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/style/StyleSelfAlignmentData.h?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/StyleRareNonInheritedData.cpp?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/ComputedStyleCSSValueMapping.cpp?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutMenuList.cpp?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutFullScreen.cpp?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/layout/LayoutFlexibleBox.cpp?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/style/StyleRareNonInheritedData.h?r1=194466&r2=194465&pathrev=194466
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSProperties.in?r1=194466&r2=194465&pathrev=194466

[Alignment] Single class for holding the alignment data.

The new CSS3 Box Alignment specification changed the value of alignment
properties, like align-self, align-items and justify-content to be
complex values rather than single keywords.

We have implemented the new spec by defining different class fields for
each kind of keyword, eg. <item-position>, <content-position>, <overflow>
and <content-distribution>. This approach has been proved to be fairly
inconsitent and buggy, as several Flexbox regressions have shown so far.

This patch defines a single class to hold all the alignment data stored
before in the different StyleRareNonInherited class fields. This way we
can detect style changes more easily, provide more consitent behavior
and ensuring backward compatibility with Flexbox implementation.

BUG=226252

Review URL: https://codereview.chromium.org/1070143002
-----------------------------------------------------------------
Could some one change the status from "No Active Development" to "In Active Development" at https://www.chromestatus.com/features/6173208034148352 ?

Comment 9 by timloh@chromium.org, May 12 2015

I updated the status.
I don't know that it's really in development other than insofar as needed
for grid. Seems misleading to call it in progress in general?
I don't know that it's really in development other than insofar as needed for grid. Seems misleading to call it in progress in general?
Status: Assigned
@cbiesinger - are you still the right owner?
Owner: ----
Nope!
Cc: cbiesin...@chromium.org mikelawther@chromium.org
Labels: -Cr-Blink Cr-Blink-Layout
Status: Available
Labels: -Type-Bug Type-Feature
Blockedon: chromium:505846
Project Member

Comment 18 by sheriffbot@chromium.org, Jun 30 2016

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Hotlist-Recharge-Cold label is added for tracking. Please re-triage this issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -WebKit-Rendering -Pri-2 -Hotlist-Recharge-Cold Pri-3
Status: Available (was: Untriaged)
P3 for a general implementation

P1-2 for Grid-specific aspects but I think those are tracked elsewhere
Components: -Blink>CSS
The remaining implementation for this seems more layout related than style related.
Project Member

Comment 21 by sheriffbot@chromium.org, Sep 22 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 22 by e...@chromium.org, Sep 23 2017

Cc: -mikelawther@chromium.org kojii@chromium.org e...@chromium.org
Status: Available (was: Untriaged)

Sign in to add a comment