New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 22589 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Sep 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

desktop shortcut file must me executable

Project Member Reported by f...@sofaraway.org, Sep 22 2009

Issue description

Desktop files created by chromium are displayed as a text files on the
desktop. When double clicked, a popup says it's an "Untrusted application
launcher", and proposes to "Launch Anyway", "Mark as Trusted" or "Cancel".

(that's with Nautilus 2.27.92 on Ubuntu Karmic)

This happens to just be a chmod issue. 755 instead of 644 fixes it.
This also turns the text icon to the proper chromium icon.

Note that Nautilus creates its launchers with a "#!/usr/bin/env xdg-open"
shebang, which while not mandatory, would be good to have too.
 

Comment 1 by est...@chromium.org, Sep 22 2009

Status: Assigned
also see  issue 22566 
Security guys, please advise. The change in code would be trivial, but I'm not sure 
about security implications here.

Comment 3 by lcam...@gmail.com, Sep 22 2009

I think that's OK, assuming the launcher is itself constructed well (it's text-based,
so we should make sure there is no shell command injection via unescaped $, |, `, ;,
\r, \n, &, ", ', \, >, < anywhere, etc).
Status: Started
Can someone remind me how to create an application shortcut on Linux? The "Create 
Application Shortcuts" option in the page menu doesn't seem to do anything for me.
Should work on ToT. If it doesn't, please file a new bug with your env, location and 
name of Chrome's .desktop file, and whether you're using Chrome or Chromium.
I'll try ToT. Can you assume for a moment that I'm stupid and give me a click-by-click 
guide to what to do to create an application shortcut? (Gmail as a concrete example 
would be useful).
Just doing Page-> Create application shortcuts->Create should work. Make sure that the 
"Desktop" checkbox is selected. After a while a shortcut should appear on your desktop 
(it's asynchronous).
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27194 

------------------------------------------------------------------------
r27194 | phajdan.jr@chromium.org | 2009-09-25 09:21:57 -0700 (Fri, 25 Sep 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/shell_integration_linux.cc?r1=27194&r2=27193
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/shell_integration_unittest.cc?r1=27194&r2=27193

Improve desktop shortcut creation:

- remove more comments (which generally only apply to the browser itself)
- add #!/usr/bin/env xdg-open shebang
- make the .desktop file placed on the desktop executable
- add more tests to make sure we're still secure

TEST=Covered by unit_tests.
BUG= 22589 

Review URL: http://codereview.chromium.org/232003
------------------------------------------------------------------------

Status: Fixed
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Sign in to add a comment