New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 22575 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Oct 2009
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
M-4

Blocking:
issue 22099

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Browser actions (and page actions): Need to be able to decode images on the fly

Project Member Reported by finnur@chromium.org, Sep 21 2009

Issue description

I thought there was a bug on this already, but couldn't find it.

During the implementation of PageActions we discussed being able to change 
the icon to something that was not necessarily declared in the manifest. This 
would require changes to how we unpack the images in the renderer.

Now, with the concept of a BrowserAction ( bug 22099 ), this looks to me like 
it is becoming a requirement.
 
Status: Started

Comment 2 by aa@chromium.org, Sep 29 2009

Summary: Browser actions (and page actions): Need to be able to decode images on the fly
Status: Available

Comment 4 by aa@chromium.org, Oct 5 2009

Labels: Mstone-4 ReleaseBlock-Beta
This should come relatively easily with the dynamic images work.

Comment 5 by aa@chromium.org, Oct 16 2009

Labels: -Pri-2 Pri-1
Bumping this to p1 because the manifest parsing code is in a weird broken state without 
it (we don't allow iconIndex in the new manifest format, but we have no replacement for 
it).

Comment 6 by aa@chromium.org, Oct 16 2009

Status: Started

Comment 7 by bugdro...@gmail.com, Oct 20 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29495 

------------------------------------------------------------------------
r29495 | aa@chromium.org | 2009-10-19 22:16:54 -0700 (Mon, 19 Oct 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/browser_action_apitest.cc?r1=29495&r2=29494
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29495&r2=29494
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=29495&r2=29494
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=29495&r2=29494
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/browserAction.html?r1=29495&r2=29494
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extension_process_bindings.js?r1=29495&r2=29494
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update2.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/background.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon1.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon2.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon3.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon4.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon5.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/manifest.json

Implement chrome.browserAction.setIcon({path:...});

BUG= 22575 

Review URL: http://codereview.chromium.org/269103
------------------------------------------------------------------------

Comment 8 by aa@chromium.org, Oct 20 2009

Status: Fixed
Labels: Feature-Extensions
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 12 2012

Blocking: -chromium:22099 chromium:22099
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-4 -Feature-Extensions M-4 Cr-Platform-Extensions
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment