New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 22558 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Omnibox should draw red bar over "https" for bad certs

Project Member Reported by thakis@chromium.org, Sep 21 2009

Issue description

Chrome Version       : 4.0.211

What steps will reproduce the problem?
1. Go to a page with a bad https cert

What is the expected result?

Windows draws a red line through https, see e.g. 
http://www.joeno1.net/wp/wp-
content/uploads/2009/04/chrome_warning_04162009.png .

What happens instead?

No line on OS X. Not sure about Linux – cc'ing erg for that.
 
http://codereview.chromium.org/215038/show adds a normal horizontal strikethrough.  If this is good enough, 
I can send it out for review.  If we have to have the diagonal strikethrough, then this change won't work :)

Comment 2 by thakis@chromium.org, Sep 21 2009

That's probably up the the UI team. CC'ing alcor.
Labels: ReleaseBlock-Beta Mstone-4
Status: Assigned
I checked with Cole - taking the CL for the horizontal red strike though is fine for beta. 
Thanks!
Status: Started

Comment 5 by bugdro...@gmail.com, Sep 24 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27064 

------------------------------------------------------------------------
r27064 | rohitrao@chromium.org | 2009-09-24 07:55:21 -0700 (Thu, 24 Sep 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm?r1=27064&r2=27063

[Mac] Add a strikethrough through insecure url schemes.

BUG= http://crbug.com/22558 
TEST=Go to https://www.twitter.com/.  See the cert mismatch warning.  Check that "https://" in the omnibox is red with a strikethrough.
Review URL: http://codereview.chromium.org/215038
------------------------------------------------------------------------

Status: Fixed

Comment 7 by ismail@chromium.org, Sep 28 2009

Status: Verified
Horizontal strike on https://

Platform:
  Hostname: Macintosh-0017f2d64524.local
  Mac OS X Version 10.5.8 (Build 9L27)
  Processor: 2 Intel 2.33 GHz
  RAM: 2048 MB

Chromium:
  Chromium version: 4.0.219.4 SVN Revision: 27365  <<<Release>>>
  QuickTime Player: 7.6.4
  QuickTime PlayerX: <unknown>
  Flash Player: 10.0.32

Comment 8 by ismail@chromium.org, Sep 29 2009

Labels: -OS-Mac OS-Linux
Status: Untriaged
This was fixed and Verified for Win and Mac.

Reproducible on Linux ( UBUNTU ) .

Tested on 4.0.219.3 ( Ubuntu build 27338 ).

Comment 9 by krisr@chromium.org, Sep 29 2009

Labels: -OS-Linux OS-Mac
Status: Verified
Ismail, can you create a new one for Linux?
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-4 M-4
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment