Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 222603 DEPENDENCIES test failing does not honor experimental
Starred by 1 user Project Member Reported by johndhong@chromium.org, Mar 21, 2013 Back to list
Status: WontFix
Owner: akes...@chromium.org
Closed: Mar 2013
OS: Chrome
Pri: 1
Type: Bug


Sign in to add a comment
http://chromegw/i/chromeos/builders/stout%20canary/builds/1088
http://chromegw/i/chromeos/builders/stout%20canary/builds/1089

experimental_desktopui_VideoDecodeAcceleration test is failing but since it is an experimental test HWTest be yellow instead of red.
 
Comment 1 by milleral@chromium.org, Mar 21, 2013
Summary: DEPENDENCIES test failing does not honor experimental (was: experimental_desktopui_VideoDecodeAcceleration failed test shows red but should be yellow)
There is code in reimager.py that goes through any tests depending on hosts that have failed, and emits an ERROR for them.  In the case of an experimental test, it should emit WARNING.
Comment 2 by scottz@chromium.org, Mar 21, 2013
Owner: akes...@chromium.org
Status: Assigned
Aviv can you look at fixing this please.
Comment 3 by quiche@chromium.org, Mar 21, 2013
Labels: -Pri-2 Pri-1 TreeCloser
increasing priority, since this is causing tree closures.

FWIW, here's the end of stdio for build 1088

@@@STEP_FAILURE@@@
08:04:49: ERROR: Traceback (most recent call last):
  File "/b/cbuild/stout-canary-master/chromite/buildbot/builderstage.py", line 269, in Run
    self._PerformStage()
  File "/b/cbuild/stout-canary-master/chromite/buildbot/cbuildbot_stages.py", line 1412, in _PerformStage
    debug)
  File "/b/cbuild/stout-canary-master/chromite/buildbot/cbuildbot_commands.py", line 485, in RunHWTestSuite
    cros_build_lib.RunCommand(cmd)
  File "/b/cbuild/stout-canary-master/chromite/lib/cros_build_lib.py", line 457, in RunCommand
    raise RunCommandError(msg, cmd_result)
RunCommandError: return code: 1
Failed command "['/b/build_internal/scripts/slave-internal/autotest_rpc/autotest_rpc_client.py', 'master2', 'RunSuite', '-i', 'stout-release/R27-3883.0.0', '-s', 'bvt', '-b', 'stout', '-p', 'bvt', '-u', '3', '-f', 'True', '-n', 'False']", cwd=None, extra env=None

Comment 4 by akes...@chromium.org, Mar 21, 2013
I should have a fix by the afternoon.
Comment 5 by akes...@chromium.org, Mar 21, 2013
Do we want to take experimental_desktopui_VideoDecodeAcceleration out of bvt in the meantime?
Comment 6 by scottz@chromium.org, Mar 21, 2013
Yeah send a CL my way and we can chump it.

Thanks.
Comment 7 by dshi@chromium.org, Mar 21, 2013
Will the fix also clear part of following issue?

Issue 187993:	[stout] experimental_desktopui_VideoSanity - Autotest client terminated unexpectedly DUT rebooted during the test run

From Scott: "look in to stopping run_suite.py from erroring when any experimental tests fail."
Comment 8 by quiche@chromium.org, Mar 21, 2013
Labels: -TreeCloser
My bad, this was not a TreeCloser. (Got it crossed with a similar looking bug.)
Project Member Comment 9 by bugdroid1@chromium.org, Mar 21, 2013
Project: chromiumos/third_party/autotest
Branch : master
Author : Aviv Keshet <akeshet@chromium.org>
Commit : 515f1c35b388be060e5e09812e2fb0344a8e33b2

Code Review  +2: Scott Zawalski
Verified     +1: Aviv Keshet
Commit Queue   : Chumped
Change-Id      : I20ee583109136047ce2a8145cd65793b89029f04
Reviewed-at    : https://gerrit.chromium.org/gerrit/46135

[autotest] temporarily remove desktopui_VideoDecodeAcceleration from bvt

Temporarily remove this test while fixing bug with unsatisfyable
dependencies.

BUG=chromium:222603
TEST=None

M  client/site_tests/desktopui_VideoDecodeAcceleration/control.bvt
Comment 10 by akes...@chromium.org, Mar 21, 2013
I think there are two unrelated issues being discussed here.

johndhong and possibly quiche are talking about a "DUT rebooted during test" failure.

milleral, and possibly scottz are talking about failures due to dynamic suite not finding matching hosts to satisfy the dependencies of an experimental test.


Yup.  I totally should have actually read closer, or remembered that there were two issues like this going on.  There's one that DUT aborts can bypass experimental, and one that DEPENDENCIES can bypass experimental, and I totally got those confused.

I'll go copy-paste john's original text into the bug that's already filed about experimental tests and DUT rebooting.
Comment 12 by akes...@chromium.org, Mar 21, 2013
Ok, so be it decreed that henceforth and forevermore this bug is about unmet DEPENDENCIES bypassing experimental.
Comment 13 by akes...@chromium.org, Mar 21, 2013
This bug does not in fact seem to be occurring. See for instance:

http://chromegw/i/chromeos/builders/x86-zgb%20canary/builds/3135

in which desktopui_VideoDecodeAcceleration has unsatisfied dependencies and gives a TEST_NA result, but HWTest does not go red (it goes yellow, either because of this or because of the failed try jobs)
Status: WontFix
Good call.  I am indeed incorrect.  run_suite does handle the result rewriting in this case correctly.
Sign in to add a comment