New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users
Status: Fixed
Owner:
Last visit 29 days ago
Closed: Jan 2010
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: ----
Type: Bug

Blocking:
issue 28287

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
Allow compilation with system libevent
Reported by bcafa...@gmail.com, Sep 17 2009 Back to list
Chrome Version       : 4.0.212 svn r26343
OS + version : Gentoo
CPU architecture (32-bit / 64-bit): both

In the same style as commits 21663, 22645 (and others), a GYP flag to build
with system libevent would be nice.

The attached patch follows the style of the previous commits, adding
"use_system_libevent" flag. It works fine here (system libevent: 1.4.12)
 
chromium-use_system_libevent.patch
6.9 KB View Download
Comment 1 by est...@chromium.org, Sep 18 2009
Status: Assigned
Comment 2 by agl@chromium.org, Sep 23 2009
The reason that we don't do this is to stop people from building with the system 
libevent. Unpatched, libevent will allocate huge amounts of memory for no good 
reason. I believe that someone at Fedora was/is trying to upstream the patch, but no 
released version of libevent will work very well.

Why do you want to build with the system libevent (i.e. are you packaging for some 
distro)? It makes us sad when users get a shitty experience because of system 
libraries, but if you're just going to patch the build system anyway and to hell with 
the bloat, then we might as well land the patch anyway.
Comment 3 by bcafa...@gmail.com, Sep 23 2009
Yes, I'm the Gentoo maintainer for the chromium ebuild in Gentoo. The README.chromium
file for libevent did not mention any incompatible change, so I wrote this patch.
Now I see the change in third_party/libevent history, thanks for the explanation!
I'll disable the patch for the time being

From:
http://sourceforge.net/tracker/index.php?func=detail&aid=2839240&group_id=50884&atid=461322

the fix will be in libevent-1.4.13 (also with the fix from r17449), so this version
can be used when released?
Comment 4 by agl@chromium.org, Sep 23 2009
Oh, great news about the patch landing upstream. Yes, all should be good once 1.4.13 
comes out. Let's keep this bug open then.

(I don't recall having seen the comments on that bug before. Maybe they don't get 
emailed out or maybe they hit my spam filter. Either way, it appears that the patch 
landed.)
Comment 5 by evan@chromium.org, Nov 5 2009
Fixed?
Comment 6 by agl@chromium.org, Nov 5 2009
No. libevent 1.4.13 isn't out yet.
Comment 7 by evan@chromium.org, Nov 19 2009
Status: Upstream
Tagging upstream to reflect this is out of our hands.
Comment 9 by agl@chromium.org, Nov 19 2009
Yay! In 12 months time we can make system libevent the default :)
Comment 10 by evan@chromium.org, Nov 20 2009
We can set the particular version as a hard build-time dep and at least allow system 
libevent in the meantime.
Comment 11 by evan@chromium.org, Nov 21 2009
In preparation for this, I have merged 1.4.13 into the Chrome tree.
We now have no functional differences from libevent 1.4.13 in our tree.
Status: Started
I'm going to land the patch.
Comment 13 by agl@chromium.org, Jan 7 2010
phajdan.jr: please CC me at least on the CL. (We still don't want to link against a 
system libevent < 1.4.13)
Status: Fixed
Landed (http://codereview.chromium.org/524061).
Blocking: chromium:28287
Project Member Comment 17 by bugdroid1@chromium.org, Oct 13 2012
Blocking: -chromium:28287
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Sign in to add a comment