| Allow compilation with system libevent | ||||||
| Reported by bcafa...@gmail.com, Sep 17 2009 | Back to list | |||||
Chrome Version : 4.0.212 svn r26343 OS + version : Gentoo CPU architecture (32-bit / 64-bit): both In the same style as commits 21663, 22645 (and others), a GYP flag to build with system libevent would be nice. The attached patch follows the style of the previous commits, adding "use_system_libevent" flag. It works fine here (system libevent: 1.4.12)
Comment 1
by
est...@chromium.org,
Sep 18 2009
,
Sep 23 2009
The reason that we don't do this is to stop people from building with the system libevent. Unpatched, libevent will allocate huge amounts of memory for no good reason. I believe that someone at Fedora was/is trying to upstream the patch, but no released version of libevent will work very well. Why do you want to build with the system libevent (i.e. are you packaging for some distro)? It makes us sad when users get a shitty experience because of system libraries, but if you're just going to patch the build system anyway and to hell with the bloat, then we might as well land the patch anyway.
,
Sep 23 2009
Yes, I'm the Gentoo maintainer for the chromium ebuild in Gentoo. The README.chromium file for libevent did not mention any incompatible change, so I wrote this patch. Now I see the change in third_party/libevent history, thanks for the explanation! I'll disable the patch for the time being From: http://sourceforge.net/tracker/index.php?func=detail&aid=2839240&group_id=50884&atid=461322 the fix will be in libevent-1.4.13 (also with the fix from r17449), so this version can be used when released?
,
Sep 23 2009
Oh, great news about the patch landing upstream. Yes, all should be good once 1.4.13 comes out. Let's keep this bug open then. (I don't recall having seen the comments on that bug before. Maybe they don't get emailed out or maybe they hit my spam filter. Either way, it appears that the patch landed.)
,
Nov 5 2009
Fixed?
,
Nov 5 2009
No. libevent 1.4.13 isn't out yet.
,
Nov 19 2009
Tagging upstream to reflect this is out of our hands.
,
Nov 19 2009
libevent 1.4.13 has just been released: http://www.provos.org/index.php?/archives/77-Libevent-1.4.13-stable-released.html
,
Nov 19 2009
Yay! In 12 months time we can make system libevent the default :)
,
Nov 20 2009
We can set the particular version as a hard build-time dep and at least allow system libevent in the meantime.
,
Nov 21 2009
In preparation for this, I have merged 1.4.13 into the Chrome tree. We now have no functional differences from libevent 1.4.13 in our tree.
,
Jan 7 2010
I'm going to land the patch.
,
Jan 7 2010
phajdan.jr: please CC me at least on the CL. (We still don't want to link against a system libevent < 1.4.13)
,
Jan 7 2010
,
Jan 8 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=35711
------------------------------------------------------------------------
r35711 | phajdan.jr@chromium.org | 2010-01-07 10:16:58 -0800 (Thu, 07 Jan 2010) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/AUTHORS?r1=35711&r2=35710
M http://src.chromium.org/viewvc/chrome/trunk/src/base/message_pump_libevent.cc?r1=35711&r2=35710
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_remote_listen_socket.cc?r1=35711&r2=35710
M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/listen_socket.cc?r1=35711&r2=35710
M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/telnet_server.cc?r1=35711&r2=35710
M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/tcp_client_socket_libevent.cc?r1=35711&r2=35710
M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libevent/libevent.gyp?r1=35711&r2=35710
Allow using system libevent instead of the bundled one.
Patch by Bernard Cafarelli <voyageur@gentoo.org>
TEST=none
BUG= 22140
Review URL: http://codereview.chromium.org/524061
------------------------------------------------------------------------
,
Jul 31 2012
,
Oct 13 2012
This issue has been closed for some time. No one will pay attention to new comments. If you are seeing this bug or have new data, please click New Issue to start a new bug. |
||||||
| ► Sign in to add a comment | ||||||