Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 21852 Implement WebGL
Starred by 74 users Project Member Reported by darin@chromium.org, Sep 15, 2009 Back to list
Status: Fixed
Owner: kbr@chromium.org
Closed: Dec 2010
Cc: hbridge@google.com, evan@chromium.org, vangelis@chromium.org, zmo@chromium.org
Components:
OS: All
Pri: 2
Type: Bug
M-9

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
Implement WebGL

 
Comment 1 by bugdro...@gmail.com, Sep 16, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=26202 

------------------------------------------------------------------------
r26202 | darin@chromium.org | 2009-09-15 00:05:23 -0700 (Tue, 15 Sep 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=26202&r2=26201
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=26202&r2=26201

Update WebKit to r48388

This commit introduces a failing webgl test.  I added a skip for
all webgl tests.

TBR=brettw
BUG= 21852 
TEST=none

Review URL: http://codereview.chromium.org/196117
------------------------------------------------------------------------

Comment 2 by darin@chromium.org, Sep 23, 2009
Labels: -Area-BrowserBackend Area-WebKit
Status: Available
Comment 3 by darin@chromium.org, Sep 28, 2009
Status: Assigned
Comment 4 by kbr@chromium.org, Sep 28, 2009
Status: Started
The initial WebGL implementation for Chrome has been committed:

https://bugs.webkit.org/show_bug.cgi?id=29664
http://codereview.chromium.org/219001

The current code is Windows-only, is disabled by default in the build, and requires 
the sandbox to be disabled. Ports to other platforms to follow shortly; running with 
the sandbox enabled is a longer-term goal.

See the above chromium.org CL for instructions on how to enable in the build.

Comment 5 by bugdro...@gmail.com, Sep 30, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27637 

------------------------------------------------------------------------
r27637 | kbr@google.com | 2009-09-30 11:35:49 -0700 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebSettings.h?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/WebSettingsImpl.cpp?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/WebSettingsImpl.h?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.h?r1=27637&r2=27636

Added command line argument --enable-webgl to facilitate turning on
ENABLE_3D_CANVAS in development builds. Currently this argument also
requires disabling the sandbox.

BUG=http://crbug.com/21852
TEST=none (runs preexisting WebGL layout tests; more coming)

Review URL: http://codereview.chromium.org/246042
------------------------------------------------------------------------

Comment 6 by kbr@chromium.org, Sep 30, 2009
http://codereview.chromium.org/246042 has been committed which will make it easier to 
set ENABLE_3D_CANVAS=1 in the Dev Channel. Ports to other platforms ongoing.

Comment 7 by bugdro...@gmail.com, Oct 2, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27902 

------------------------------------------------------------------------
r27902 | kbr@google.com | 2009-10-02 14:26:35 -0700 (Fri, 02 Oct 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/glew/README.chromium?r1=27902&r2=27901
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/glew/src/glew.c?r1=27902&r2=27901
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/GraphicsContext3D.cpp?r1=27902&r2=27901
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/webkit.gyp?r1=27902&r2=27901

Ported Chrome's WebGL implementation to Mac OS X. Removed code which
used the GPU to vertically flip the framebuffer. Updated GLEW to use
standard dlopen / dlsym rather than deprecated mach-o/dyld functions;
updated README.chromium.

BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)

Review URL: http://codereview.chromium.org/256037
------------------------------------------------------------------------

Comment 8 by bugdro...@gmail.com, Oct 6, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28062 

------------------------------------------------------------------------
r28062 | kbr@google.com | 2009-10-05 16:32:52 -0700 (Mon, 05 Oct 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/glew/README.chromium?r1=28062&r2=28061
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/glew/include/GL/glew.h?r1=28062&r2=28061
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/glew/src/glew.c?r1=28062&r2=28061
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/GraphicsContext3D.cpp?r1=28062&r2=28061
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/webkit.gyp?r1=28062&r2=28061

Ported Chrome's WebGL implementation to Linux. Required changes to
GLEW's bootstrapping sequence on both X11 and Windows platforms to
avoid linking against libGL.so.1 directly due to
http://crbug.com/16800 . Made GLEW's inclusion of glu.h optional.
Tested on Linux, Mac and Windows.

BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)

Review URL: http://codereview.chromium.org/258024
------------------------------------------------------------------------

Comment 9 by bugdro...@gmail.com, Oct 8, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28336 

------------------------------------------------------------------------
r28336 | kbr@google.com | 2009-10-07 15:53:20 -0700 (Wed, 07 Oct 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/features_override.gypi?r1=28336&r2=28335

Compile WebGL support in to Chrome's Dev Channel builds. Still
requires command line option --enable-webgl (and, currently,
--no-sandbox) to enable.

BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)

Review URL: http://codereview.chromium.org/270003
------------------------------------------------------------------------

Comment 10 by bugdro...@gmail.com, Oct 21, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29632 

------------------------------------------------------------------------
r29632 | kbr@google.com | 2009-10-21 03:48:37 -0700 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/features_override.gypi?r1=29632&r2=29631
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/GraphicsContext3D.cpp?r1=29632&r2=29631

Implemented getActiveAttrib, getActiveUniform and readPixels. Removed
unnecessary UTF-8 conversion when converting C strings to WebKit
Strings. Re-enabled WebGL in Dev Channel builds.

BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)

Review URL: http://codereview.chromium.org/308006
------------------------------------------------------------------------

Comment 11 by dpranke@chromium.org, Oct 27, 2009
Labels: LayoutTests
Comment 12 by kbr@chromium.org, Oct 29, 2009
Labels: 3D-WebGL
Comment 13 by oritm@chromium.org, Nov 24, 2009
Labels: 3d-Mstone-2
Labels: LTTF
Comment 15 by oritm@chromium.org, Dec 8, 2009
Labels: -3d-Mstone-2 3d-Mstone-3
Not a demo blocker. Moving to m3.
Comment 16 by f...@sofaraway.org, Dec 12, 2009
Is it supposed to work on Linux just yet?
It doesn't work with the ubuntu builds.
Tried with --enable-webgl --no-sandbox using trunk and the beta, no error, nada.
Just nothing rendered in the examples.

At build time, i use libglew1.5-dev to provide glew.h (since mid-Oct when it 
became necessary)
At runtime, i obviously have libglew1.5.
As for libGL.so.1, it could come from libgl1-mesa-glx or nvidia-glx-XXX for nvidia 
users.
In my case:
lrwxrwxrwx 1 root root     18 2009-10-27 23:14 /usr/lib/libGL.so.1 -> 
libGL.so.185.18.36
-rw-r--r-- 1 root root 622272 2009-10-26 10:50 /usr/lib/libGL.so.185.18.36
(so nvidia-glx-185)

is it http://crbug.com/16800?
Comment 17 by kbr@chromium.org, Dec 12, 2009
> Is it supposed to work on Linux just yet?
> It doesn't work with the ubuntu builds.

Should be working. Just tested 
http://build.chromium.org/buildbot/continuous/linux/LATEST/chrome-linux.zip (r34374) 
and it runs the samples linked from the Chromium blog post. This is on 64-bit Ubuntu 
8.04 with NVIDIA hardware and drivers. Could you test the behavior with this exact 
build? Please provide any output to the terminal.

yes, worked for me also. tested the cute puppy and other demos at
<http://www.khronos.org/webgl/wiki/Demo_Repository>
this is amd64 jaunty with nvidia.
Comment 19 by evan@chromium.org, Dec 12, 2009
It could be because Chrome's glew is forked.  See
http://neugierig.org/software/chromium/notes/2009/12/forking.html (search for "glew")
Comment 20 by kbr@chromium.org, Dec 12, 2009
Yes, it was necessary to modify GLEW to dynamically look up all OpenGL entry points, because per 
http://crbug.com/16800 we can not link against libGL.so. During build time we compile in the GLEW sources so 
we do not have an additional dynamic library dependency.

Labels: Internals-Graphics
Comment 22 by f...@sofaraway.org, Dec 19, 2009
I've dropped libglew1.5-dev from my build-depends list and now it's failing with
GraphicsContext3D: error opening libGL.so.1. Not very explicit.
I'm not getting the "GraphicsContext3D: tried:" line (missing "\n"?)

But as it requires --no-sandbox, there's no point in me spending on this for now. I 
don't want to encourage users to run chromium without the sandbox.
Comment 23 by kbr@chromium.org, Jan 13, 2010
Please see http://code.google.com/p/chromium/issues/detail?id=26055 , in particular 
comments 30 and 31. I believe the current Chromium continuous build should work.

Comment 24 by bugdro...@gmail.com, Jan 28, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37416 

------------------------------------------------------------------------
r37416 | dglazkov@chromium.org | 2010-01-28 10:47:28 -0800 (Thu, 28 Jan 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=37416&r2=37415
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/layout_test_controller.cc?r1=37416&r2=37415

Enable WebGL layout tests.

R=kbr
TEST=none
BUG= 21852 

Review URL: http://codereview.chromium.org/556061
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37418 

------------------------------------------------------------------------
r37418 | dglazkov@chromium.org | 2010-01-28 11:03:54 -0800 (Thu, 28 Jan 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=37418&r2=37417

Still skip WebGL tests on Linux. They crash.

TBR=kbr
TEST=none
BUG= 21852 

Review URL: http://codereview.chromium.org/553137
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37419 

------------------------------------------------------------------------
r37419 | dglazkov@chromium.org | 2010-01-28 11:09:33 -0800 (Thu, 28 Jan 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=37419&r2=37418

Skip Win too, because they crash on bots.

TBR=kbr
TEST=none
BUG= 21852 

Review URL: http://codereview.chromium.org/552218
------------------------------------------------------------------------

Comment 27 by bugdro...@gmail.com, Feb 11, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38767 

------------------------------------------------------------------------
r38767 | jorlow@chromium.org | 2010-02-11 05:43:54 -0800 (Thu, 11 Feb 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=38767&r2=38766

Add test expectations from last roll.

TBR=yurys
BUG= 21852 
TEST=none

Review URL: http://codereview.chromium.org/597041
------------------------------------------------------------------------

Comment 28 by bugdro...@gmail.com, Feb 16, 2010
Comment 29 by agl@chromium.org, Feb 16, 2010
Comment 30 by ambr...@gmail.com, Mar 21, 2010
Please add /usr/lib{,32,64}/libGL.so to library search paths on Linux. On Gentoo there 
is no /usr/lib*/libGL.so.1, because actual libs are in /usr/lib*/opengl/{xorg-
x11,nvidia,ati}/lib to allow having multiple OpenGL libs installed, and "eselect 
opengl" is used to select one. This program adds the real lib dir to LDPATH so the 
libs are in the linker cache (for programs linked directly) and sets up the 
/usr/lib*/libGL.so symlink for programs loading the library with dlopen().
Comment 31 by evan@chromium.org, Mar 22, 2010
ambrop7: can you open a separate bug about this libGL issue?  I want to ask some 
questions and I don't want to clutter this bug up with the answers.
Should this be marked as fixed since WebGL is now available on chrome beta?
Comment 33 by kbr@chromium.org, Dec 20, 2010
Labels: Area-Internals
I'm CC'ing our product manager. I think we should probably wait to close it until WebGL is available on the stable channel.

Comment 34 by hbridge@google.com, Dec 21, 2010
Labels: -3D-WebGL -3d-Mstone-3 feature-gpu-webl
Comment 35 by hbridge@google.com, Dec 21, 2010
Labels: -Size-Medium -Mstone-X -feature-gpu-webl Mstone-9 Feature-GPU-WebGL
Status: Fixed
I think we can mark it as fixed.  It'll be verified etc later.
Comment 36 by downch...@gmail.com, Sep 22, 2011
This has pretty well reverted into a bug, from the GPU blacklist:
http://www.google.com/support/forum/p/Chrome/thread?tid=4ed2cebe3379b1a2
Comment 37 by kbr@chromium.org, Sep 26, 2011
Cc: zmo@chromium.org
Project Member Comment 38 by bugdroid1@chromium.org, Oct 13, 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 39 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Area-WebKit -Mstone-9 -Feature-GPU-WebGL -Internals-Graphics -Area-Internals Cr-Content M-9 Cr-Internals-GPU-WebGL Cr-Internals-Graphics Cr-Internals
Project Member Comment 40 by bugdroid1@chromium.org, Mar 13, 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member Comment 41 by bugdroid1@chromium.org, Apr 6, 2013
Labels: -Cr-Content Cr-Blink
Project Member Comment 42 by bugdroid1@chromium.org, Apr 10, 2013
Labels: -Cr-Internals-GPU-WebGL Cr-Blink-WebGL
Sign in to add a comment