New issue
Advanced search Search tips

Issue 21281 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2009
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: ----
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

When you reload a development extension, you get a new ID

Project Member Reported by aa@chromium.org, Sep 8 2009

Issue description

What steps will reproduce the problem?
1. Load an extension via --load-extension or the "load extension" button in 
chrome://extensions/
2. Press reload in chrome://extensions/ for that extension.
3. Notice that the extension gets a new ID (...aa, ...ab, .etc).

What is the expected output? What do you see instead?

This messes up extensions that use persistent storage since they end up in 
a new origin each time they are reloaded.

--load-extensions should somehow get a consistent origin. Maybe we should 
hash the name or something? Or give them an origin like local-
path_to_extension?

 
Status: Available
I like the idea of hashing the path name. That way it will stay consistent across 
browser restarts, and work for disable/reenable too.

Comment 2 by aa@chromium.org, Oct 3 2009

 Issue 23736  has been merged into this issue.

Comment 3 by aa@chromium.org, Oct 3 2009

Status: Started
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28095 

------------------------------------------------------------------------
r28095 | aa@chromium.org | 2009-10-05 23:17:54 -0700 (Mon, 05 Oct 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertest.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertest.h?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_uitest.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater_unittest.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service_unittest.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.h?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_unittest.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/uitest/event_sink/manifest.json?r1=28095&r2=28094

Generate IDs for --load-extension by hashing the path instead
of incrementing a static counter.

BUG= 21281 
TEST=Load an unpacked extension from chrome://extensions/ that
does not have an ID in its manifest. The resulting ID should
be random-looking, not something like "aaaaaa".

Review URL: http://codereview.chromium.org/256049
------------------------------------------------------------------------

Comment 5 by aa@chromium.org, Oct 6 2009

Status: Fixed
Labels: Feature-Extensions
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Feature-Extensions Cr-Platform-Extensions

Sign in to add a comment