New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 20669 link

Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2009
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Implement extension packing on linux

Project Member Reported by aa@chromium.org, Aug 31 2009

Issue description

See the --pack-extension flag of chrome.exe on Windows.

The main work here is implementing base/crypto/signature_creator.* on linux.
 

Comment 1 by aa@chromium.org, Aug 31 2009

Note: I went back and looked at the windows implementation. Actually the majority of 
the work is implementing rsa_private_key_nss.cc.

NSS could probably be used directly instead of all the low-level leg work that is 
happening in the windows port. See signature_verifier_nss.cc for something close that 
uses platform APIs.

Comment 2 by aa@chromium.org, Sep 9 2009

Labels: Mstone-4 Channel-Beta
Status: Available

Comment 3 by aa@chromium.org, Sep 9 2009

 Issue 21239  has been merged into this issue.

Comment 4 by aa@chromium.org, Sep 9 2009

Labels: Size-Medium

Comment 8 by bugdro...@gmail.com, Sep 25 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27163 

------------------------------------------------------------------------
r27163 | wtc@chromium.org | 2009-09-24 18:30:39 -0700 (Thu, 24 Sep 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/crypto/signature_creator_nss.cc?r1=27163&r2=27162

Add a TODO comment to describe when we can remove the const_cast for
the NSS function SGN_Update.

R=rafaelw
BUG= 20669 
TEST=none
Review URL: http://codereview.chromium.org/218035
------------------------------------------------------------------------

this is fixed now, right?
Re comment #9, it's not quite done yet. It needs something approximately like 
http://codereview.chromium.org/246085 to respond to the command-line flag.

Also windows seems to have a dialog hooked into chrome://extensions for packing but
maybe that's not part of this bug.

When I apply the above patch and pack the hello world extension, the resulting crx 
seems to be broken:
(note the missing first character in the filenames)

[craig@csinspiron src(packext)]$ unzip -t ./myext.crx 
Archive:  ./myext.crx
warning [./myext.crx]:  306 extra bytes at beginning or within zipfile
  (attempting to process anyway)
    testing: anifest.json             OK
    testing: y_toolstrip.html         OK
No errors detected in compressed data of ./myext.crx.

For comparison, here is something that is "good".

[craig@csinspiron src(packext)]$ unzip -t ./chrome/test/data/extensions/good.crx
Archive:  ./chrome/test/data/extensions/good.crx
warning [./chrome/test/data/extensions/good.crx]:  306 extra bytes at beginning or 
within zipfile
  (attempting to process anyway)
    testing: manifest.json            OK
    testing: script1.js               OK
    testing: script2.js               OK
No errors detected in compressed data of ./chrome/test/data/extensions/good.crx.

Please note that I know absolutely nothing about extensions so consider the source of 
this information when reviewing the above :)
@10, I think your broken crx file is running into  bug 19103 .
mpcomplete: Thanks! ... it is much happier without the trailing slash when trying to 
do the packing.

Comment 13 by aa@chromium.org, Oct 5 2009

Labels: ReleaseBlock-Beta

Comment 14 by aa@chromium.org, Oct 5 2009

Labels: Pri-1

Comment 15 by aa@chromium.org, Oct 5 2009

Status: Started
Status: Fixed
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28325 

------------------------------------------------------------------------
r28325 | rafaelw@chromium.org | 2009-10-07 15:26:07 -0700 (Wed, 07 Oct 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_init.cc?r1=28325&r2=28324
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service_unittest.cc?r1=28325&r2=28324
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/pack_extension_job.h?r1=28325&r2=28324
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_url_request_context.cc?r1=28325&r2=28324
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=28325&r2=28324

Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support. Part 1.

original issue: http://codereview.chromium.org/207062

Attempting to land this patch earlier resulted in compile failures on linux valgrind and linux perf that I was unable to reproduce.

I am splitting this into two pieces. This piece adds extension packing support via --pack-extension for mac & linux.

BUG= 20668 , 20669 

Review URL: http://codereview.chromium.org/266007
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28365 

------------------------------------------------------------------------
r28365 | rafaelw@chromium.org | 2009-10-07 18:18:02 -0700 (Wed, 07 Oct 2009) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/crypto/rsa_private_key.h?r1=28365&r2=28364
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/crypto/rsa_private_key_nss.cc?r1=28365&r2=28364
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/crypto/signature_creator.h?r1=28365&r2=28364
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/crypto/signature_creator_nss.cc?r1=28365&r2=28364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_init.cc?r1=28365&r2=28364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service_unittest.cc?r1=28365&r2=28364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_ui.cc?r1=28365&r2=28364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_ui.h?r1=28365&r2=28364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/pack_extension_job.h?r1=28365&r2=28364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_url_request_context.cc?r1=28365&r2=28364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/extensions_ui.html?r1=28365&r2=28364
   D /trunk/src/chrome/browser/views/extensions/extension_pack_dialog.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=28365&r2=28364

Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support.

original issue: http://codereview.chromium.org/207062

The issue had to do with a symbol collison with the nss libraries (which are currently out-of-date) on the build bots.

HTML Pack Extension Dialog. This removes the views implementation of the ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI.

Additionally, support is added for packaging extensions via ---pack-extension on linux and mac

BUG= 20668 ,  20669 

TBR=aa,wtc

Review URL: http://codereview.chromium.org/265032
------------------------------------------------------------------------

Labels: Feature-Extensions
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-4 -Feature-Extensions M-4 Cr-Platform-Extensions
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment