Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 18323 Need more bits (64-bit Mac version)
Starred by 4318 users Reported by luc...@gmail.com, Aug 3 2009 Back to list
Status: Fixed
Owner:
Closed: Nov 2014
Cc:
Components:
NextAction: ----
OS: Mac
Pri: 2
Type: Feature


Sign in to add a comment
Chrome Version       : 197.0 (Developer Build 22258)
OS version               : 10.6 build 10A421a
Behavior in Safari 4.x: Works as expected

Snow Leopard will be released in less than 2 months. I believe we should start testing a 64bit 
version of Chrome so it can be ready when SL ships.
 
activity monitor.png
28.5 KB View Download
Comment 1 by jon@chromium.org, Aug 7 2009
Labels: SnowLeopard
Labeling items which appear related to Snow Leopard (Mac OS X 10.6) so we 
can find them more easily. 
Comment 2 by mark@chromium.org, Sep 3 2009
Labels: -Area-Misc -Type-Bug Area-BrowserBackend Type-Feature Size-Large
Status: Assigned
Summary: Need more bits (64-bit Mac version) (was: NULL)
Comment 3 by jon@chromium.org, Oct 2 2009
Labels: Mstone-5
This may not be a milestone 5 feature.  It all depends on the performance of 64 bit V8.
Comment 4 by phthor...@gmail.com, Oct 15 2009
I'd like 64 bit because my 32 bit MMX yuv conversion on Mac had to give up a register 
and is slower than Windows & Linux.  But in 64 bit, I could use RIP indexing, and/or 
use more registers.  Plus the 64 bit (x64) MMX scaler is 30.5% faster than the 32 bit.
We can do 64 bit on Leopard 10.5... I've built/run some tests apps okay.

Comment 5 by oritm@chromium.org, Dec 17 2009
Labels: -Area-BrowserBackend Area-Internals
Replacing labels:
   Area-BrowserBackend by Area-Internals

Comment 6 by mark@chromium.org, Jan 5 2010
Labels: -Pri-2 -SnowLeopard -Size-Large Pri-1 Internals-Core
Setting preliminary M5 priorities
Labels: PreScreenedMstone5
Comment 8 Deleted
Comment 9 Deleted
Comment 10 Deleted
Labels: wasm5kg Mstone-X
Comment 12 by mark@chromium.org, May 13 2010
Blockedon: 44127
Status: Started
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=47275 

------------------------------------------------------------------------
r47275 | mark@chromium.org | 2010-05-14 08:43:00 -0700 (Fri, 14 May 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_unittest.cc?r1=47275&r2=47274
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_unittest_mac.h?r1=47275&r2=47274
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_unittest_mac.mm?r1=47275&r2=47274

64-bit support for Mac OS X in base_unittests.

BUG= 44127 ,  18323 
TEST=64-bit base_unittests should all pass
Review URL: http://codereview.chromium.org/2126001
------------------------------------------------------------------------

Comment 14 by mark@chromium.org, May 14 2010
Blockedon: -44127 44127 v8:706
Comment 15 by mark@chromium.org, May 14 2010
Blockedon: -44127 v8:706 44127 v8:706
Comment 16 by mark@chromium.org, May 14 2010
Blockedon: 44205
Comment 17 by mark@chromium.org, May 14 2010
Blockedon: 44215
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=47308 

------------------------------------------------------------------------
r47308 | mark@chromium.org | 2010-05-14 13:57:50 -0700 (Fri, 14 May 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/skia/ext/skia_utils_mac.h?r1=47308&r2=47307

NSSize is equivalent to CGSize in the 64-bit Mac environment.

BUG= 44215 ,  18323 
TEST=none
Review URL: http://codereview.chromium.org/2134003
------------------------------------------------------------------------

Comment 19 by karen@chromium.org, May 19 2010
Labels: -wasm5kg -Mstone-X Mstone-6
Comment 20 by mark@chromium.org, Jun 14 2010
Labels: -Pri-1 -Mstone-6 Pri-2 Mstone-X
Bumping.
Yeah, Adobe has been released Flash plugin 64bit, we also Chrome can do so.

Comment 22 by mark@chromium.org, Sep 17 2010
The Flash plugin isn’t what was holding this up.
Comment 23 Deleted
Comment 24 Deleted
Comment 25 Deleted
Comment 26 Deleted
Comment 27 Deleted
Comment 28 Deleted
Comment 29 by mark@chromium.org, Dec 15 2010
Labels: -PreScreenedMstone5 Restrict-AddIssueComment-Commit
Project Member Comment 30 by bugdroid1@chromium.org, Mar 22 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=79069

------------------------------------------------------------------------
r79069 | mark@chromium.org | Tue Mar 22 16:28:59 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/basictypes.h?r1=79069&r2=79068&pathrev=79069

64-bit support for Mac OS X in base.

BUG= 44127 ,  18323 
TEST=64-bit base should all (mostly) build
Review URL: http://codereview.chromium.org/6708096
------------------------------------------------------------------------
Project Member Comment 31 by bugdroid1@chromium.org, Mar 22 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=79070

------------------------------------------------------------------------
r79070 | mark@chromium.org | Tue Mar 22 16:42:29 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/third_party/nspr/prcpucfg_mac.h?r1=79070&r2=79069&pathrev=79070

64-bit support for Mac OS X in base (NSPR).

This integrates file revisions 3.11, 3.12, 3.13, and 3.14 from the upstream
source, encompassing changes made in upstream bugs 404272,  417044 , and  370766 .

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/nsprpub/pr/include/md/_darwin.cfg&rev=HEAD&mark=3.14

BUG= 44127 ,  18323 
TEST=64-bit base should all (mostly) build
Review URL: http://codereview.chromium.org/6721003
------------------------------------------------------------------------
Project Member Comment 32 by bugdroid1@chromium.org, Mar 24 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=79251

------------------------------------------------------------------------
r79251 | mark@chromium.org | Wed Mar 23 21:32:52 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/third_party/nspr/prtypes.h?r1=79251&r2=79250&pathrev=79251

Sync prtypes.h (NSPR in base) with upstream file revision 3.43.

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/nsprpub/pr/include/prtypes.h&rev=HEAD&mark=3.43

This picks up a 64-bit Mac OS X fix from upstream bug 478687.

https://bugzilla.mozilla.org/show_bug.cgi?id=478687

BUG= 44127 ,  18323 
TEST=64-bit base should all (mostly) build
Review URL: http://codereview.chromium.org/6722011
------------------------------------------------------------------------
Project Member Comment 33 by bugdroid1@chromium.org, Mar 24 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=79252

------------------------------------------------------------------------
r79252 | mark@chromium.org | Wed Mar 23 21:33:00 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/basictypes.h?r1=79252&r2=79251&pathrev=79252

Use #if defined(__LP64__) in preference to #if __LP64__. This is a follow-up
to r79069.

BUG= 44127 ,  18323 
TEST=64-bit base should all (mostly) build
Review URL: http://codereview.chromium.org/6723016
------------------------------------------------------------------------
Project Member Comment 34 by bugdroid1@chromium.org, Mar 29 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=79733

------------------------------------------------------------------------
r79733 | mark@chromium.org | Tue Mar 29 13:34:30 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/nss/nss.gyp?r1=79733&r2=79732&pathrev=79733

Make NSS for Chromium build properly for Mac x86_64.

BUG= 18323 
TEST=My own 'ARCHS': ['x86_64'] build. Chromium now builds up through
     base_unittests for x86_64, and all base_unittests pass except for those
     tests also marked FAILS_ for x86.
Review URL: http://codereview.chromium.org/6749034
------------------------------------------------------------------------
Project Member Comment 35 by bugdroid1@chromium.org, Mar 29 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=79738

------------------------------------------------------------------------
r79738 | mark@chromium.org | Tue Mar 29 13:38:39 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=79738&r2=79737&pathrev=79738

Update NSS to r79733 to pick up:

Make NSS for Chromium build properly for Mac x86_64. 

BUG= 18323 
TEST=My own 'ARCHS': ['x86_64'] build. Chromium now builds up through 
     base_unittests for x86_64, and all base_unittests pass except for those 
     tests also marked FAILS_ for x86.
Review URL: http://codereview.chromium.org/6773020
------------------------------------------------------------------------
Labels: MacOSXLion
Comment 37 by mark@chromium.org, Jul 29 2011
Labels: -MacOSXLion
Comment 38 by mark@chromium.org, Mar 6 2012
Blockedon: 116795
Comment 39 by mark@chromium.org, Mar 15 2012
Cc: mmaer...@adobe.com
Labels: Restrict-AddIssueComment-OnlyPeopleCCd
Comment 40 by kareng@google.com, Mar 15 2012
Labels: -Restrict-AddIssueComment-OnlyPeopleCCd
I've marked issue 128122 as blocked on this issue.  For some reason, the bug-tracker has not reciprocated - this should also be marked as blocking 128122, so I'm noting this here instead.

Comment 43 by dhw@chromium.org, Oct 11 2012
Blocking: chromium:155268
Comment 44 by dhw@chromium.org, Oct 11 2012
Blocking: -chromium:155268
Comment 45 by dhw@chromium.org, Oct 11 2012
Blocking: chromium:115774
Issue 156359 has been merged into this issue.
Comment 47 by mark@chromium.org, Nov 6 2012
Blocking: chromium:159629
Issue 167846 has been merged into this issue.
Comment 49 by mark@chromium.org, Jan 16 2013
Blockedon: chromium:170422
Project Member Comment 50 by bugdroid1@chromium.org, Jan 24 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=178644

------------------------------------------------------------------------
r178644 | mark@chromium.org | 2013-01-24T21:00:23.635002Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?r1=178644&r2=178643&pathrev=178644

Allow target_arch to select the Mac 64-bit build.

BUG= 18323 
Review URL: https://codereview.chromium.org/12068002
------------------------------------------------------------------------
Comment 51 by mark@chromium.org, Feb 25 2013
Blockedon: chromium:178257
Cc: jamiewa...@chromium.org w...@chromium.org
Project Member Comment 53 by bugdroid1@chromium.org, Mar 5 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=186281

------------------------------------------------------------------------
r186281 | mark@chromium.org | 2013-03-05T23:20:57.843403Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll_bundle.gypi?r1=186281&r2=186280&pathrev=186281

Mac x86_64: package nacl_irt_x86_64.nexe.

BUG= 18323 
Review URL: https://codereview.chromium.org/12441004
------------------------------------------------------------------------
Project Member Comment 54 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-Internals -Internals-Core Cr-Internals Cr-Internals-Core
Comment 55 by laforge@google.com, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Comment 56 by a...@chromium.org, Mar 19 2013
Blockedon: chromium:222047
Blocking: chromium:222050
Comment 58 by mark@chromium.org, Mar 19 2013
Blockedon: chromium:222086
Comment 59 by a...@chromium.org, Mar 20 2013
Labels: mac64
Blockedon: chromium:272212
Blockedon: chromium:316916
Project Member Comment 62 by bugdroid1@chromium.org, Jan 3 2014
The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=45718

------------------------------------------------------------------------
r45718 | mmentovai@google.com | 2014-01-03T23:25:23.869711Z

------------------------------------------------------------------------
Project Member Comment 63 by bugdroid1@chromium.org, Jan 3 2014
The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=45719

------------------------------------------------------------------------
r45719 | mmentovai@google.com | 2014-01-03T23:35:12.525120Z

------------------------------------------------------------------------
Project Member Comment 64 by bugdroid1@chromium.org, Jan 3 2014
------------------------------------------------------------------------
r242964 | mark@chromium.org | 2014-01-03T23:37:25.166215Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/mac/tweak_info_plist.py?r1=242964&r2=242963&pathrev=242964
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mac/keystone_install.sh?r1=242964&r2=242963&pathrev=242964
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/mac/keystone_glue.mm?r1=242964&r2=242963&pathrev=242964

Expand the Keystone tag to contain the system's CPU's bitness and whether a
full installer is desired.

Formerly, the tag identified only the channel that Chrome was on. The tag is
being enhanced to detect the CPU's bitness (adding "-32bit" for 32-bit-only,
non-64-bit-capable CPUs) and whether a full (as opposed to binary diff patch)
update is requested (adding "-full").

CPU bitness detection ought to be a feature of Keystone, but Keystone uses the
NXGetLocalArchInfo to determine the CPU type, and winds up always reporting
"i486". The "-32bit" tag suffix will be present whenever the
"hw.cpu64bit_capable" sysctl name is not found or has value 0. This enables
proper detection of users who are capable of running 64-bit Chrome on the
server side.

When a binary diff patch update application fails in dirpatcher, typically the
result of modifications made to existing installations, the "-full" tag suffix
will be set. On a subsequent update attempt, the server can detect this value
and provide the client with a full updater package, which does not depend on
the existing installation. The "-full" tag suffix is cleared on successful
update installation.

BUG= 18323 ,54047, 225352 ,303280, 316916 
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/102963007
------------------------------------------------------------------------
Project Member Comment 65 by bugdroid1@chromium.org, Jan 6 2014
------------------------------------------------------------------------
r243088 | mark@chromium.org | 2014-01-06T14:36:43.031619Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mac/keystone_install.sh?r1=243088&r2=243087&pathrev=243088

Make the update installer fail when attempting to install a 64-bit-only update
on a 32-bit-only system.

The server infrastructure should not deliver 64-bit-only updates to
32-bit-only systems, but this depends on the new -32bit tag suffix support
already being on the system prior to the attempted delivery of a 64-bit-only
update. The update installer will now sanity-check this, and if the system
will not be capable of running the updated version, it will exit before
attempting to install it. Additionally, it will set the -32bit tag suffix so
that during a subsequent update check, the server should deliver the proper
32-bit-only update (likely the final 32-bit version), or no update at all.

This also serves as a failsafe against breaking users on 32-bit-only systems
if the server-side -32bit tag suffix detection isn't working properly.

BUG= 18323 ,303280
R=thakis@chromium.org, thakis

Review URL: https://codereview.chromium.org/124813002
------------------------------------------------------------------------
Project Member Comment 66 by bugdroid1@chromium.org, Jan 6 2014
Labels: merge-merged-1750
------------------------------------------------------------------------
r243102 | mark@chromium.org | 2014-01-06T16:59:03.446041Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1750/src/chrome/installer/mac/keystone_install.sh?r1=243102&r2=243101&pathrev=243102
   M http://src.chromium.org/viewvc/chrome/branches/1750/src/chrome/browser/mac/keystone_glue.mm?r1=243102&r2=243101&pathrev=243102
   M http://src.chromium.org/viewvc/chrome/branches/1750/src/build/mac/tweak_info_plist.py?r1=243102&r2=243101&pathrev=243102

Merge trunk r242964 and r243035 to the 33.0.1750 branch.

r242964:
> Expand the Keystone tag to contain the system's CPU's bitness and whether a
> full installer is desired.
>
> Formerly, the tag identified only the channel that Chrome was on. The tag is
> being enhanced to detect the CPU's bitness (adding "-32bit" for 32-bit-only,
> non-64-bit-capable CPUs) and whether a full (as opposed to binary diff patch)
> update is requested (adding "-full").
>
> CPU bitness detection ought to be a feature of Keystone, but Keystone uses the
> NXGetLocalArchInfo to determine the CPU type, and winds up always reporting
> "i486". The "-32bit" tag suffix will be present whenever the
> "hw.cpu64bit_capable" sysctl name is not found or has value 0. This enables
> proper detection of users who are capable of running 64-bit Chrome on the
> server side.
>
> When a binary diff patch update application fails in dirpatcher, typically the
> result of modifications made to existing installations, the "-full" tag suffix
> will be set. On a subsequent update attempt, the server can detect this value
> and provide the client with a full updater package, which does not depend on
> the existing installation. The "-full" tag suffix is cleared on successful
> update installation.
>
> BUG= 18323 ,54047, 225352 ,303280, 316916 
> R=thakis@chromium.org
>
> Review URL: https://codereview.chromium.org/102963007

r243035:
> Switch exit status from 77 (try again later) back to 12/13 (errors).
>
> When driving an update from KeystoneRegistration, Chrome sees 77 as success.
> This causes the about page to say that an update was successfully installed
> and offer the option to relaunch. When the user clicks Relaunch, Chrome quits
> and the same old version restarts and starts trying to apply an update again.
> This seems kind of glitchy.
>
> I'm switching back to the failure codes, because those are properly reported
> in the UI. In the future, I can make keystone_glue.mm check for the
> .want_full_installer file when update installation fails and silently retry
> installation once, for a seamless "error 12"-free experience.
>
> BUG=54047,303280
> TBR=thakis
>
> Review URL: https://codereview.chromium.org/121673003

Review URL: https://codereview.chromium.org/122713003
------------------------------------------------------------------------
Project Member Comment 67 by bugdroid1@chromium.org, Jan 6 2014
The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=45762

------------------------------------------------------------------------
r45762 | mmentovai@google.com | 2014-01-06T17:03:33.627806Z

------------------------------------------------------------------------
Comment 68 by a...@chromium.org, Feb 11 2014
Blockedon: chromium:337859
Issue 337859 exposes misaligned memory accesses on 64. Seems like this broke after the canary we did.
Cc: pinkerton@chromium.org
Blockedon: chromium:353047
Blockedon: chromium:393594
Comment 72 by vrk@chromium.org, Jul 24 2014
Blockedon: chromium:396957
Comment 73 by mark@chromium.org, Nov 18 2014
Status: Fixed
This was released to the stable channel today in version 39.0.2171.65. Thanks for your patience, everyone.
Project Member Comment 74 by bugdroid1@chromium.org, Nov 20 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/602b4bf2748b43b9cb697b039a35131b9e0c913c

commit 602b4bf2748b43b9cb697b039a35131b9e0c913c
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Nov 20 18:37:00 2014

Switch the Mac build from 32-bit to 64-bit.

As of M39, Chrome is a 64-bit only binary. This changes the default build
configuration to 64-bit globally. After this CL, the 32-bit Mac build is no
longer supported.

BUG= 405542 , 18323 
R=mark@chromium.org

Review URL: https://codereview.chromium.org/730173002

Cr-Commit-Position: refs/heads/master@{#305043}

[modify] http://crrev.com/602b4bf2748b43b9cb697b039a35131b9e0c913c/DEPS
[modify] http://crrev.com/602b4bf2748b43b9cb697b039a35131b9e0c913c/build/common.gypi

Project Member Comment 75 by bugdroid1@chromium.org, Aug 26 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15082cfc975b356fc9c5e4f1e5a5b758b80a30aa

commit 15082cfc975b356fc9c5e4f1e5a5b758b80a30aa
Author: mseaborn <mseaborn@chromium.org>
Date: Wed Aug 26 22:39:08 2015

NaCl: Re-enable ASLR for nacl-loader processes on Mac OS X

When Mac Chrome was 32-bit, we needed to disable ASLR for NaCl because
otherwise address space would get fragmented and we wouldn't be able
to allocate enough contiguous address space (issue 90221).

This is no longer necessary now that Mac Chrome is 64-bit (issue
18323).

BUG=90221
BUG= 18323 
TEST=browser_tests

Review URL: https://codereview.chromium.org/1312273002

Cr-Commit-Position: refs/heads/master@{#345704}

[modify] http://crrev.com/15082cfc975b356fc9c5e4f1e5a5b758b80a30aa/chrome/app/chrome_main_delegate.cc
[modify] http://crrev.com/15082cfc975b356fc9c5e4f1e5a5b758b80a30aa/components/nacl/browser/nacl_process_host.cc

Sign in to add a comment