New issue
Advanced search Search tips

Issue 18271 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2009
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Bypass proxy list should only be applied when using manual proxy settings.

Project Member Reported by eroman@chromium.org, Aug 2 2009

Issue description

In the Internet Explorer proxy settings:
  (1) check autodetect
  (2) specify a manual proxy (for any protocol)
  (3) set a some proxy bypass list

Assuming the autodetect succeeds and we are using the wpad PAC script:

  * IE will not apply the proxy bypass rules
  * Chromium WILL apply the proxy bypass rules

Chromium should be behaving the same as IE and only applying the proxy bypass 
to the manual proxy rules.
 
Status: Started
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22430 

------------------------------------------------------------------------
r22430 | ericroman@google.com | 2009-08-04 15:43:12 -0700 (Tue, 04 Aug 2009) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/net.gyp?r1=22430&r2=22429
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/init_proxy_resolver.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/init_proxy_resolver.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/init_proxy_resolver_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_resolver.h?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_resolver_mac.h?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_resolver_perftest.cc?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_resolver_v8.cc?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_resolver_v8.h?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_resolver_v8_unittest.cc?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_resolver_winhttp.cc?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_resolver_winhttp.h?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_script_fetcher.cc?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_script_fetcher.h?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_script_fetcher_unittest.cc?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_service.cc?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_service.h?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_service_unittest.cc?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/single_threaded_proxy_resolver.cc?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/single_threaded_proxy_resolver.h?r1=22430&r2=22429
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/single_threaded_proxy_resolver_unittest.cc?r1=22430&r2=22429

Better match IE's proxy settings.

 * When BOTH autodetect and custom PAC script are given, try both.
 * Use successful PAC parsing as the heuristic for determining when a script   is valid (rather than first-request). 
 * Only apply the proxy bypass list when using non-PAC.

The high level explanation on how this works:

http://sites.google.com/a/chromium.org/dev/developers/design-documents/proxy-settings-fallback

BUG=  http://crbug.com/18271 ,  http://crbug.com/9985 
TEST=unit tests.
Review URL: http://codereview.chromium.org/160510
------------------------------------------------------------------------

Status: Fixed
Labels: -Area-BrowserBackend Area-Internals
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals Cr-Internals

Sign in to add a comment