New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 181172 link

Starred by 10 users

Issue metadata

Status: Verified
Owner:
Not on Chrome anymore
Closed: Mar 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: "Text" on Page action infobar is not getting displayed for cookies settings.

Project Member Reported by ashej...@chromium.org, Mar 8 2013

Issue description

Chrome Version:- 27.0.1432.1    
OS:- ALL
Also observed on "ChromeOS Daisy version:-27.0.1431.2"

What steps will reproduce the problem?
1.Install and launch above chrome version.
2.Navigate to "chrome://settings" -->Content Settings -->Cookies.
3.Under cookies Select "Block sites from setting any data" option & "Block third-party cookies and site data" option & click on done.
4.Navigate to "www.google.com" & click on Cookies page action info bar &
select  "Always allow www.google.co.in to set cookies" option & click on Done button.
5.Info bar will be displayed with Reload button, click on the same & allow the page to refresh.
6.Click on Cookies "Page action info bar" again & Observe.

What is the expected result?
"Text" on the Cookies "Page action info bar" should be displayed.

What happens instead?
"Text" on the Cookies "Page action info bar" is not getting displayed.

Regression issue as working fine in latest stable version. "25.0.1364.152".Below is the bisect info for the same.

Manual bisect:
Last known Good build:-26.0.1409.0.
First known Bad build:-26.0.1410.0.

Bisect from tool:-
You are probably looking for a change made after 181648 (known good), but no later than 181651 (first known bad).
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/tru
nk/src&range=181648%3A181651.

Suspecting- 181651?

Attach below is the video which will give better insight.

***PS:This issue is "NOT AURA" Specific,also happening on recent Dev builds*** 

Thanks

 
Action_infobar_cookies.swf
2.1 MB Download
Cc: bauerb@chromium.org
+bauerb since crrev.com/181651 is possibly related.
Labels: -Mstone-27 -ReleaseBlock-Beta Mstone-26 ReleaseBlock-Stable
Owner: bauerb@chromium.org
Status: Assigned
Labels: -OS-Chrome
Cc: -bauerb@chromium.org
Hm, yeah, that might have been me. The old strings were kind of weird though anyway (they said "continue blocking cookies" even though cookies were allowed).
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-UI -Feature-Settings -Mstone-26 Cr-UI-Settings Type-Bug-Regression Cr-UI M-26
bauerb: do you have a patch under review?
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 14 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=188160

------------------------------------------------------------------------
r188160 | bauerb@chromium.org | 2013-03-14T19:53:19.439220Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc?r1=188160&r2=188159&pathrev=188160
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/content_settings/content_setting_bubble_model.cc?r1=188160&r2=188159&pathrev=188160

Show strings in content settings bubble when access to cookies is allowed.

BUG= 181172 


Review URL: https://chromiumcodereview.appspot.com/12479005
------------------------------------------------------------------------

Comment 8 by mbollu@chromium.org, Mar 14 2013

Reproducible on Chrome 27.0.1432.0 for Mac 10.8.2. See attachment.

Not reproducible on Chrome 27.0.1438.8/Chrome OSA 3833.0.0 - Daisy(in fresh or existing account). See attachment.
Screen Shot 2013-03-14 at 12.45.51 PM.png
558 KB View Download
 Issue 196512  has been merged into this issue.
Status: Fixed
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 18 2013

Labels: Merge-TBD
Is there a merge required here?
Labels: -Merge-TBD Merge-Requested
Yesplz.
Status: Verified
Tested this issue with Latest Canary#27.0.1443.2 on Win7, Mac OS X 10.8.2 & Ubuntu 12.04 - Working as intended.

Thank you!
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 18 2013

Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=188727

------------------------------------------------------------------------
r188727 | bauerb@chromium.org | 2013-03-18T14:08:48.658248Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc?r1=188727&r2=188726&pathrev=188727
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/content_settings/content_setting_bubble_model.cc?r1=188727&r2=188726&pathrev=188727

Merge 188160
> Show strings in content settings bubble when access to cookies is allowed.
> 
> BUG= 181172 
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12479005

TBR=bauerb@chromium.org
Review URL: https://codereview.chromium.org/12438014
------------------------------------------------------------------------
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 18 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=188756

------------------------------------------------------------------------
r188756 | dharani@google.com | 2013-03-18T17:11:26.885006Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc?r1=188756&r2=188755&pathrev=188756
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/content_settings/content_setting_bubble_model.cc?r1=188756&r2=188755&pathrev=188756

Revert 188727 "Merge 188160" due to compilation error in the unittest.

> Merge 188160
> > Show strings in content settings bubble when access to cookies is allowed.
> > 
> > BUG= 181172 
> > 
> > 
> > Review URL: https://chromiumcodereview.appspot.com/12479005
> 
> TBR=bauerb@chromium.org
> Review URL: https://codereview.chromium.org/12438014

TBR=bauerb@chromium.org
Review URL: https://codereview.chromium.org/12438018
------------------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 18 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=188783

------------------------------------------------------------------------
r188783 | bauerb@chromium.org | 2013-03-18T18:52:58.987558Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc?r1=188783&r2=188782&pathrev=188783
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/content_settings/content_setting_bubble_model.cc?r1=188783&r2=188782&pathrev=188783

Merge 188160: Show strings in content settings bubble when access to cookies is allowed. 

Unit test compile failure hopefully fixed.

> Show strings in content settings bubble when access to cookies is allowed.
> 
> BUG= 181172 
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12479005

TBR=bauerb@chromium.org
Review URL: https://codereview.chromium.org/12620027
------------------------------------------------------------------------
Verified this issue with Latest Beta#26.0.1410.40 on Win7, Mac OS X 10.8.2 & Ubuntu 12.04 - Working as intended.

Thank you!

Sign in to add a comment