New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit 17 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 180589: chrome.release categorizes some bits incorrectly

Reported by robertshield@chromium.org, Mar 6 2013 Project Member

Issue description

The Win8 code and assets are currently only under GOOGLE_CHROME, they should be under GENERAL to build a Chromium win8 installer.

pdf.dll should probably be only under GOOGLE_CHROME, I don't reckon that Chromium builds get that.
 

Comment 1 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-Internals -Internals-Install Cr-Internals-Install Cr-Internals

Comment 2 by bugdroid1@chromium.org, Apr 5 2013

Project Member
Labels: -Cr-Internals-Install Cr-Internals-Installer

Comment 3 by cpu@chromium.org, Jun 6 2015

Cc: -cpu@chromium.org

Comment 4 by grt@chromium.org, Jul 21 2016

Labels: OS-Windows

Comment 5 by grt@chromium.org, Aug 22 2016

Cc: robertshield@chromium.org
Labels: -Pri-3 M-54 Pri-2
Owner: scottmg@chromium.org
Status: Assigned (was: Started)
Would you believe that the GOOGLE_CHROME section is used for Chromium builds as well? Oh dear. Scott: do you have time to fix this along with the logos?

Comment 6 by benhenry@google.com, Aug 23

Components: -Internals

Comment 7 by scottmg@chromium.org, Dec 12

Status: WontFix (was: Assigned)

Comment 8 by grt@chromium.org, Dec 12

Hilarious that your just closed this out -- Ganesh has a CL to fix this in-flight!

Comment 9 by scottmg@chromium.org, Dec 12

Cc: scottmg@chromium.org
Owner: gan...@chromium.org
Status: Assigned (was: WontFix)
Oh, sorry! I sorta skimmed and saw Win8 and figured we must have done this at some point.

Ganesh, do you want to mark fixed a 100000-range crbug? :)

Comment 11 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e9abebcf8d4f1f0c87fec177f273a1a6845e34d

commit 4e9abebcf8d4f1f0c87fec177f273a1a6845e34d
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Dec 14 17:10:47 2018

[Media Engagement] Fix preload bundling on Windows

Fix MEIPreload bundling on Windows to include it with
the Chromium installer.

BUG=180589

Change-Id: I530a859236f4f31f1f155b077366815de4badc7f
Reviewed-on: https://chromium-review.googlesource.com/c/1376100
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616717}
[modify] https://crrev.com/4e9abebcf8d4f1f0c87fec177f273a1a6845e34d/chrome/installer/mini_installer/chrome.release

Sign in to add a comment