New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 180183 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome Sign-In page is seen when opening an Incognito Session

Reported by smokana@chromium.org, Mar 5 2013

Issue description

Version: 27.0.1430.0
OS: Linux

What steps will reproduce the problem?
1. Launch Chrome and Rt. Click on Chrome icon 
2. Rt Click on Chrome Icon in the Launcher Bar and select "New Incognito Window"
3. It launches Incognito session but Chrome Sign-In option is seen. 

This is not the case if we Launch Incognito Session from Wrench or Keyboard Shortcut. 

 
Version was 27.0.1429.0
This is a regression issue and below is the Manual Bisect Info:

Good Build: 26.0.1394.0
Bad Build: 26.0.1395.0

Unable to provide narrow bisect as this option is not available in Chromium Builds.
Labels: Action-FeedbackNeeded
Steps not clear , please provide the exact behavior with the screenshot.

Comment 4 by kareng@google.com, Mar 6 2013

Labels: Action-BisectNeeded
adding bisect needed back too since the range is way too wide :(
Labels: -Mstone-27 -ReleaseBlock-Beta -Action-FeedbackNeeded -Action-BisectNeeded Mstone-26 ReleaseBlock-Stable
Owner: rogerta@chromium.org
Status: Assigned
It looks like this issue is caused by the new web-based sign-in.

Tested on Ubuntu Precise. Only see the New Incognito Window from the launcher context menu on installed Chrome so unable to do bisect-builds bisect. Screenshot attached. Manual bisect: 

26.0.1395.0 (Official Build 179031) bad - web sign-in
26.0.1394.0 (Official Build 178768) good - Chrome sign-in
Bisect range: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=178768:179031&mode=html

Assigning to Roger to see if it is web sign-in. Not sure if requires ReleaseBlock, leaving on for M26 stable for now.
Incognito_27.0.1430.0.png
50.1 KB View Download
Cc: tmc...@chromium.org tim@chromium.org
Labels: Feature-SignIn
Cc: atwilson@chromium.org
Summary: Chrome Sign-In page is seen when opening an Incognito Session (was: Chrome Sign-In option is seen in Incognito Session)
Thanks. Drew might be able to see where the behavior changed.

Comment 9 Deleted

Yeah, I can't repro this with a local build nor can I repro with my installed chrome on linux so I can't easily debug it. I'll try making a real chrome (not chromium) build, but I may not get to this until Monday.
I built a real chrome build, and still the launcher doesn't have a "new incognito window" menu item -- not sure why/how that launcher context menu is created.

Comment 12 by gab@chromium.org, Mar 7 2013

FWIW it's very likely that the issue is that some code attaches the web-signin-tab (given a set of conditions is satisfied) when the browser is launched (i.e., that's why it doesn't repro from keyboard shortcut on wrench menu).

I'm seeing the same thing on Windows when using (right-click taskbar shortcut -> Open New Incognito Window) with no current window opened.

Also note that even if Chrome is already running this will happen anyways; probably because the taskbar action launches another chrome process which decides on the set of tabs to open before realizes another chrome process is running and rendez-vous with it (i.e. tells the other process to open it's windows/tabs for it and goes away).

Speculation, but since I stumbled upon this bug I thought I'd try to point you towards what I think is happening.

Cheers!
Gab
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-UI -Mstone-26 -Feature-Incognito -Feature-SignIn Type-Bug-Regression Cr-UI M-26 Cr-Services-SignIn Cr-UI-Browser-Incognito
Patch under review - https://codereview.chromium.org/12623012/
Status: Started
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 12 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=187700

------------------------------------------------------------------------
r187700 | jwd@chromium.org | 2013-03-12T23:40:06.435931Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc?r1=187700&r2=187699&pathrev=187700

Adding a check to not show sync promo for incognito profiles. 

This prevents the sync promo from being shown when chrome is launched into incognito. There may be an underlying reason why this was happening that isn't being addressed by this change. 


BUG= 180183 


Review URL: https://chromiumcodereview.appspot.com/12623012
------------------------------------------------------------------------
Status: Fixed
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 13 2013

Labels: Merge-TBD
Is there a merge required here?
Labels: -Merge-TBD Merge-Requested
Status: Verified
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=187935

------------------------------------------------------------------------
r187935 | jwd@chromium.org | 2013-03-13T20:35:19.919147Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc?r1=187935&r2=187934&pathrev=187935

Merge 187700 "Adding a check to not show sync promo for incognit..."

> Adding a check to not show sync promo for incognito profiles. 
> 
> This prevents the sync promo from being shown when chrome is launched into incognito. There may be an underlying reason why this was happening that isn't being addressed by this change. 
> 
> 
> BUG= 180183 
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12623012

TBR=jwd@chromium.org
Review URL: https://codereview.chromium.org/12697009
------------------------------------------------------------------------

Sign in to add a comment