New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 18 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment
link

Issue 179717: Some accessibility tests fail on Win build

Reported by jsc...@chromium.org, Mar 3 2013 Project Member

Issue description

There's an FYI bot here:
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20x64%20Clobber

We're knocking out the last few remaining test failures for the Win64 build, before we can enable the full test suites on the main waterfall this week. It turns out that all of the accessibility tests have always been failing. I can probably just broadly disable accessibility for the time being, but this definitely blocks the stable Win64 release.
 

Comment 1 by jsc...@chromium.org, Mar 3 2013

Blocking: chromium:8606

Comment 2 by dmazz...@chromium.org, Mar 4 2013

I'm trying to repro. Any tips for gyp settings that will get me a working build? I synced to trunk and tried just adding target_arch=x64 and built out/Release_x64 and I'm getting a linker error with olepro32.lib.

Comment 3 by jsc...@chromium.org, Mar 4 2013

It sounds like you're using Scott's free toolchain? If so, there are some x64 dependencies that haven't been ironed out. However, just setting target_arch=x64 should work with the normal MSVS toolchain.

Comment 4 by dmazz...@chromium.org, Mar 4 2013

Scott's? I'm using ninja with the MSVS compiler provided by the Windows 7.1 SDK.

Comment 5 by jsc...@chromium.org, Mar 4 2013

Yeah, @scottmg wrapped that up into an automated install that also grabs any missing dependencies. I assumed that's what you were using given the error. Unfortunately, there are some details that haven't been ironed out for supporting x64 with that toolchain, so you actually do need a normal MSVS 2010 or 2012 install.

Comment 6 by bugdroid1@chromium.org, Mar 4 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=185968

------------------------------------------------------------------------
r185968 | scottmg@chromium.org | 2013-03-04T20:58:36.946706Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?r1=185968&r2=185967&pathrev=185968

fix linking against olepro32.lib on win x64

R=jschuh@chromium.org
BUG= 179717 

Review URL: https://codereview.chromium.org/12377089
------------------------------------------------------------------------

Comment 7 by jsc...@chromium.org, Mar 4 2013

Summary: Some accessibility tests fail on Win64 build (was: All accessibility tests fail on Win64 build)

Comment 8 by dmazz...@chromium.org, Mar 4 2013

Cc: aboxhall@chromium.org
OK, we just tested an x64 build and accessibility is working fine. Also, some of the accessibility tests are passing, just one whole set are failing.

So, let's assume this is probably just a problem in the test, and if necessary the failing tests can be disabled in 64-bit mode for now.

Comment 9 by jsc...@chromium.org, Mar 5 2013

Okay, here's the failing test list:

AccessibilityWinBrowserTest.TestBusyAccessibilityTree
AccessibilityWinBrowserTest.TestNotificationCheckedStateChanged
AccessibilityWinBrowserTest.TestNotificationChildrenChanged
AccessibilityWinBrowserTest.TestNotificationChildrenChanged2
AccessibilityWinBrowserTest.TestNotificationFocusChanged
AccessibilityWinBrowserTest.TestNotificationValueChanged
AccessibilityWinBrowserTest.ContainsRendererAccessibilityTree
AccessibilityWinBrowserTest.SupportsISimpleDOM
AccessibilityWinBrowserTest.TestRoleGroup
CrossPlatformAccessibilityBrowserTest.TableSpan
DumpAccessibilityTreeTest.AccessibilityAriaLevel
DumpAccessibilityTreeTest.AccessibilityIframeCoordinates

I'm uploading a CL to disable them on Win64 builds for now.

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-Internals -Feature-Accessibility -Mstone-27 Cr-UI-Accessibility Cr-Internals M-27

Comment 12 by xhw...@chromium.org, Apr 8 2013

Summary: Some accessibility tests fail on Win build (was: Some accessibility tests fail on Win64 build)
AccessibilityWinBrowserTest are pretty flaky on all Windows, not just Win64:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWin&testType=content_browsertests&tests=AccessibilityWinBrowserTest.*

Comment 13 by kareng@google.com, Apr 15 2013

Labels: -M-27 MovedFrom-27 M-28
Moving all non essential bugs to the next Milestone

Comment 14 by bugdroid1@chromium.org, May 8 2013

Project Member
Labels: -M-28 MovedFrom-28
This issue has already been moved once and is lower than Priority 1,therefore removing mstone.

Comment 15 by dmazz...@chromium.org, Nov 4 2013

Status: Available

Comment 16 by stan...@gmail.com, Jan 31 2014

Any progress here?

Comment 17 by wfh@chromium.org, Feb 12 2014

Labels: Cr-Tests-Disabled Proj-Win64

Comment 18 by jsc...@chromium.org, Apr 14 2014

Blocking: -chromium:8606

Comment 19 by bugdroid1@chromium.org, Jun 16 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8b4a4425ae9298f74d13045f0f68de09ccad597

commit d8b4a4425ae9298f74d13045f0f68de09ccad597
Author: dmazzoni@chromium.org <dmazzoni@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Jun 16 16:09:03 2014

Fix accessibility in Windows x64 build.

The only fix needed was to cast the LPARAM to a DWORD when
handling WM_GETOBJECT in two places.

Also fixes and re-enables a bunch of Windows accessibility tests,
and deletes a couple of old disabled tests that aren't worth fixing.

BUG= 179717 , 383240 

Review URL: https://codereview.chromium.org/329863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277457 0039d316-1c4b-4281-b951-d872f2087c98

Comment 20 by bugdroid1@chromium.org, Jun 16 2014

Project Member

Comment 21 by dmazz...@chromium.org, Jun 16 2014

Status: Fixed

Comment 22 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment