New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 179697 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Multiple tabs gets open when, Ctrl<Click> any "Recently closed" tab in NTP.

Project Member Reported by ashej...@chromium.org, Mar 3 2013

Issue description

Chrome Version       :Version 27.0.1427.3 canary
OS : Windows7, SP1, 64 bit.

What steps will reproduce the problem?
1.Install and launch above chrome version.
2.Navigate to "https://www.google.com" & close this tab.
3.Open NTP page and Click on "Recently closed" link, Pop up will be displayed with "Google" link in it.
4.Ctrl<Click> Google link & Observe.

What is the expected result?
Single Tab should be displayed with "Recently close" website in it, ie in this case Google.com.

What happens instead?
Two tabs gets displayed with Google.com website.

Note:- Regression issue as used to work in previous stable M24 version "24.0.1312.57".

Manual bisect:-
Last working build:-25.0.1324.0.
Broken from build:-25.0.1325.0.

Bisect from tool:-
http://trac.webkit.org/log/trunk/?rev=134347&stop_rev=134202&verbose=on&limit=10000
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=167331%3A167377

Attach is the video below, which will give you better idea.

Suspecting- 167360,167362 , Looping both developers of the revisions, Please excuse if I am wrong for any of the revision :) 
Thanks
 
Recently_close_app.swf
3.3 MB Download

Comment 1 by rossi...@gmail.com, Mar 3 2013

Confirmed on Chrome Version 27.0.1425.2 dev-m, Win7 64-bit
Labels: OS-Chrome
This issue is reproducible on "ChromeOS-Daisy" below are the details.

Google chrome:-25.0.1364.152(185281).
Platform:-3428.196.0 (Stable-channel daisy).
Webkit:-537.22 (@144108)
Javascript: V8 3.15.11.16. 
Hence adding OS-Chrome label.
Thanks 
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-UI -Feature-NewTabPage -Mstone-27 Cr-UI-Browser-NewTabPage Type-Bug-Regression Cr-UI M-27
Owner: jeffreyc@chromium.org
Status: Assigned
Jeff, can you find somebody to look into this. This seems to be general Chrome issue dating back to 26

Comment 6 by dbeam@chromium.org, Mar 14 2013

Owner: dbeam@chromium.org
Status: Started
https://codereview.chromium.org/12754009

Comment 7 by dbeam@chromium.org, Mar 14 2013

This is probably a merge-worthy change when it lands.

Comment 8 by dbeam@chromium.org, Mar 14 2013

Cc: tanyarad@chromium.org kerz@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 15 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=188297

------------------------------------------------------------------------
r188297 | dbeam@chromium.org | 2013-03-15T08:18:09.048500Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/ntp4/recently_closed.js?r1=188297&r2=188296&pathrev=188297

Fix recently closed multiple tabs regression.

R=estade@chromium.org
BUG= 179697 
TEST=ctrl + click a recently closed item.


Review URL: https://chromiumcodereview.appspot.com/12754009
------------------------------------------------------------------------

Comment 10 by dbeam@chromium.org, Mar 15 2013

Labels: -M-27 M-26 Merge-Requested
 Issue 207107  has been merged into this issue.

Comment 12 by dbeam@chromium.org, Mar 19 2013

ping: tanyarad@
Labels: TE-Verified-27.0.1445.1
Tested the above issue on latest canary # 27.0.1445.1 & dev version 27.0.1444.3. and the functionality is working as intended.
Thanks
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 19 2013

Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=189058

------------------------------------------------------------------------
r189058 | dbeam@chromium.org | 2013-03-19T18:20:21.856415Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/resources/ntp4/recently_closed.js?r1=189058&r2=189057&pathrev=189058

Merge 188297 "Fix recently closed multiple tabs regression."

> Fix recently closed multiple tabs regression.
> 
> R=estade@chromium.org
> BUG= 179697 
> TEST=ctrl + click a recently closed item.
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12754009

TBR=dbeam@chromium.org
Review URL: https://codereview.chromium.org/12720013
------------------------------------------------------------------------

Comment 16 by dbeam@chromium.org, Mar 19 2013

Status: Verified

Sign in to add a comment