New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 178397 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Some avatar icons are shown mirrored in tab strip

Project Member Reported by toyoshim@chromium.org, Feb 26 2013

Issue description

Version: 25.0.1364.99
OS: Mac OS X

What steps will reproduce the problem?
1. Use multiple profiles
2. Select a musical note icon for avatar icon
3. Select the user and open a window

What is the expected output? What do you see instead?
I expect that the icon is shown at the window title. Actually it's shown but it is symmetry.

I attached two pictures. As you see here, both of icons are shown correctly in settings. But the musical note icon is shown symmetry in window title.

This problem seemingly happens only in Mac Book Pro retina models. I reproduce this problem in both of 13 inch and 15 inch models.
 
icon2.tiff
21.6 KB Download
icon1.tiff
33.8 KB Download

Comment 1 by thakis@chromium.org, Feb 26 2013

Cc: sail@chromium.org
Labels: -Feature-HighDPI
Summary: Some avatar icons are shown mirrored in tab strip (was: Some avatar icons are shown symmetrically in window title)
We have _mac images for all the profile images that are supposed to be mirrored. I guess the asset for the note is wrong?

(toyoshim: please attach pngs instead of tiffs, as browsers can preview them on crbug)
Sorry for tiff images.

You looks right.
I found that chrome/app/theme/default_100_percent/common/profile_avatar_note_mac.png is NOT mirrored.
Is there any regular way to make mirrored image? I can prepare a patch for this, but if someone is responsible for this, I'll wait the person fix this.

Comment 3 by sail@chromium.org, Feb 26 2013

Owner: toyoshim@chromium.org
Status: Assigned
Hi toyoshim, I just used ImageMagick to flip the original version.
I don't think we want to do that anymore. Instead, ping one of the UX guys. They'll flip it for you.

Thanks,
Sailesh
Status: Started
Hum... I'm a little confused.

profile_avatar_*_mac.png files are mirrored because these icons appear at right end on mac, and left end on win.
But, profile_avatar_note_mac.png icon is a special. It has polarity. So Chrome uses the same image on both platform in default_100_percent directory.

But, in default_200_percent directory, profile_avatar_note_mac.png is also mirrored. This 200% image is used only in retina model. So the image which should be fixed looks the one in default_200_percent.

Anyway, I made a CL for that. I'll request a review.

Comment 5 by sail@chromium.org, Feb 27 2013

Ahh, makes sense. Could you send a copy to the UX guys so that they update their source too? Maybe sgabriel@
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 28 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=185089

------------------------------------------------------------------------
r185089 | toyoshim@chromium.org | 2013-02-28T01:13:09.268088Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/profile_avatar_note_mac.png?r1=185089&r2=185088&pathrev=185089

Note avatar icon is shown mirrored in tab strip on Mac/Retina

Avatar icons for Mac is mirrored because they appear at the other end.
But note icon is special because it has polarity. It should not be mirrored.

In 100% images, Chrome already use the same image for the both platform.
But, in 200% images, the icon is mistakenly mirrored.

BUG= 178397 
TEST=manual

Review URL: https://codereview.chromium.org/12313149
------------------------------------------------------------------------
Status: Fixed
#5
thank you for advice.
I did!

By the way, this change is easy to merge.
I'm planning to request merge to branches.
Labels: Mstone-26 Merge-Requested
Status: Started
I confirmed that this problem is fixed in Canary.
I request to merge this to m26 beta.
Labels: -Merge-Requested Merge-Approved
merge approved for m26
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 1 2013

Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=185444

------------------------------------------------------------------------
r185444 | toyoshim@chromium.org | 2013-03-01T03:41:20.907528Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/app/theme/default_200_percent/profile_avatar_note_mac.png?r1=185444&r2=185443&pathrev=185444

Merge 185089
> Note avatar icon is shown mirrored in tab strip on Mac/Retina
> 
> Avatar icons for Mac is mirrored because they appear at the other end.
> But note icon is special because it has polarity. It should not be mirrored.
> 
> In 100% images, Chrome already use the same image for the both platform.
> But, in 200% images, the icon is mistakenly mirrored.
> 
> BUG= 178397 
> TEST=manual
> 
> Review URL: https://codereview.chromium.org/12313149

TBR=toyoshim@chromium.org
------------------------------------------------------------------------
Status: Fixed
It looks not critical, so I think merging to beta is enough for now.
I'll close this as Fixed.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-Profiles -Mstone-26 Cr-UI Cr-UI-Browser-Profiles M-26

Sign in to add a comment