Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 17 users
Status: Fixed
Owner:
Closed: Apr 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 8606



Sign in to add a comment
ppapi_tests test_struct_sizes.cc fails to compile on Win64 build
Project Member Reported by jsc...@chromium.org, Feb 22 2013 Back to list
This is the last thing Blocking the Win64 "All" build. So, I'd really like to get it fixed, otherwise I have to disable NaCl for now in the Win64 build (because I need to get the "All" target working on the CQ ASAP now that we have bots on the main waterfall).

Here's the output:

[6/599] CC obj\ppapi\tests\ppapi_tests.test_struct_sizes.obj
FAILED: ninja -t msvc -o obj\ppapi\tests\ppapi_tests.test_struct_sizes.obj -e environment.x64 -- cl.exe /nologo /showIncludes /FC @obj\ppapi\tests\ppapi_tests.test_struct_sizes.obj.rsp /c ..\..\ppapi\tests\test_struct_sizes.c /Foobj\ppapi\tests\ppapi_tests.test_struct_sizes.obj /Fdobj\ppapi\ppapi_tests.pdb
d:\src\chrome\src\ppapi\tests\arch_dependent_sizes_64.h(14) : error C2118: negative subscript
d:\src\chrome\src\ppapi\tests\arch_dependent_sizes_64.h(15) : error C2118: negative subscript
[6/599] CXX obj\chrome_frame\crash_reporting\crash_report.crash_report.obj

So, it looks like this target is picking up the wrong architecture, and thus failing the compile asserts, but I don't see how.

 
By default, msvc _x64_ sizeof(long int) == 4, so the size check fails in arch_dependent_sizes_64.h.  On linux x64, sizeof(long int) == 8.

Khronos (gl.h) and ppapi/c/ppb_opengles2.h define GLintptr in terms of long int:
  typedef signed   long  int     khronos_intptr_t;
  typedef long int GLintptr;

http://www.khronos.org/registry/egl/api/KHR/khrplatform.h

Comment 2 by jsc...@chromium.org, Feb 23 2013
Blocking: chromium:8606
Project Member Comment 3 by bugdroid1@chromium.org, Feb 26 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=184296

------------------------------------------------------------------------
r184296 | jschuh@chromium.org | 2013-02-23T06:17:14.304007Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/tests/arch_dependent_sizes_64.h?r1=184296&r2=184295&pathrev=184296

Disable GL sizes PPAPI tests

The wrong size is defined for Win64. It needs a real fix, but first I need to unblock the builder.

BUG= 177779 

Review URL: https://chromiumcodereview.appspot.com/12310080
------------------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-Internals -Feature-Plugins-Pepper -Feature-NaCl Cr-Platform-NaCl Cr-Internals Cr-Content-Plugins-Pepper
Comment 5 by jsc...@chromium.org, Mar 20 2013
Labels: -Pri-0 Pri-2
In case it's not obvious, the test is valid, and this probably means OpenGL won't work right in NaCl on Win64 until it's fixed.

(Makes sense to disable though to unblock other Win64 work.)
Comment 7 by jsc...@chromium.org, Mar 20 2013
Yup. That's why the bug is still open. :)
Project Member Comment 8 by bugdroid1@chromium.org, Apr 5 2013
Labels: Cr-Blink
Project Member Comment 9 by bugdroid1@chromium.org, Apr 6 2013
Labels: Cr-Internals-Plugins
Project Member Comment 10 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content-Plugins-Pepper Cr-Internals-Plugins-Pepper
Comment 11 by stan...@gmail.com, Mar 21 2014
Any progress here?
fyi, recent updates that may allow the test to be re-enabled:
  https://codereview.chromium.org/115143004
  https://code.google.com/p/chromium/issues/detail?id=326382

Thanks Nicholas. Working on the CL to re-enable.
Project Member Comment 14 by bugdroid1@chromium.org, Mar 25 2014
------------------------------------------------------------------
r259114 | bbudge@chromium.org | 2014-03-25T02:46:20.013046Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/tests/arch_dependent_sizes_64.h?r1=259114&r2=259113&pathrev=259114

Re-enable disabled size asserts in ppapi_tests test_struct_sizes.cc.
Khronos headers have been updated.

BUG= 177779 

Review URL: https://codereview.chromium.org/205263005
-----------------------------------------------------------------
Status: Fixed
Sign in to add a comment