New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 177734 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
User never visited
Closed: Mar 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome , Mac
Pri: 0
Type: Bug



Sign in to add a comment

Extension badges displaying with wrong background color

Reported by ja...@queso.com, Feb 22 2013

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.12 Safari/537.31

Steps to reproduce the problem:
1. Install Chrome 26.0.1410.12 dev on OS X
2. Install any extension (e.g., ForecastFox, Checker Plus for Gmail, etc.) which uses badges to display extra data overlaying its toolbar icon

What is the expected behavior?
The badges should display with the configured background color.

What went wrong?
The badges are displaying with only the bottom-most line having the configured background color; the rest of the badge has a white-to-gray gradient background.

WebStore page: 

Did this work before? Yes I don't know which version worked; I recall it working a month ago, give or take.

Chrome version: 26.0.1410.12  Channel: dev
OS Version: OS X 10.8.2
 
Screen Shot 2013-02-22 at 2.12.23 PM.png
39.5 KB View Download
Cc: mpcomplete@chromium.org
Labels: Area-UI
cc-ing mpcomplete - this looks like a generic extension issue, can you take a look at it?
Cc: pludwig@chromium.org kalman@chromium.org
Owner: jyasskin@chromium.org
Status: Assigned
Jeffrey, can you take a look at this? We saw this last week, and it seems to be a problem with high-dpi on Mac only.
Cc: erikkay@chromium.org
Labels: -Pri-2 Pri-0 Mstone-26
Just noticed that this is in the M26 beta.  This will need to be fixed and merged as a critical change.  26 goes to stable on April 2nd.

Comment 4 by yoz@chromium.org, Mar 5 2013

Cc: jyasskin@chromium.org
Owner: yoz@chromium.org

Comment 5 by yoz@chromium.org, Mar 5 2013

Labels: OS-Chrome
Also exists on high DPI ChromeOS 26.0.1410.15.

Comment 6 by yoz@chromium.org, Mar 5 2013

Experimenting with a chromeos=1 build and --force-device-scale-factor, the badge starts displaying incorrectly when the scale factor is greater than 1.5.

Comment 7 by yoz@chromium.org, Mar 6 2013

Cc: varunjain@chromium.org
git-bisect shows that this broke at r181032. This change added 200% (2x) images for browser action buttons, so I think it's the case that it exposed an existing bug (that this would have been broken on high DPI devices).

Comment 8 by yoz@chromium.org, Mar 6 2013

Cc: -varunjain@chromium.org yoz@chromium.org
Owner: varunjain@chromium.org
The default_200_percent browser_action_badge images are buggy! They do not contain the proper mostly-transparent alpha channel.
Owner: sgabr...@chromium.org
Hi Sebastien... can you provide the right images for browser_action_badge_{center|left|right}. If you see the current 1x and 2x images you will see that the 2x image has the wrong alpha.

Comment 10 Deleted

I modified the 2x assets.
I didn't have the source so I redid them visually.
Let me know if it works. They are attached.
browser_action_badge.zip
2.1 KB Download

Comment 12 by yoz@chromium.org, Mar 6 2013

Thanks, I'll try them out.

Comment 13 by yoz@chromium.org, Mar 6 2013

There is still an issue with the 2x browser action images: the shadow drops too low below the bottom of the image on the left and right images. (The center image looks fine.)
browser-action-bottom-off.png
1.7 KB View Download

Comment 14 by yoz@chromium.org, Mar 6 2013

I'm noticing that the 1x images are 4x11 (left and right) or 3x11 (center). The images you attached are all 8x24. Can you fix them so they're 22 pixels high?
Sorry for the wrong sized, modified assets attached.


browser_action_badge_2.zip
2.7 KB Download

Comment 16 by yoz@chromium.org, Mar 6 2013

Thanks, those look good.
(You can see an unrelated bug, which I filed as  bug 180725  in my screenshot.)
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 7 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=186551

------------------------------------------------------------------------
r186551 | yoz@chromium.org | 2013-03-07T00:40:30.844467Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/common/browser_action_badge_left.png?r1=186551&r2=186550&pathrev=186551
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/common/browser_action_badge_right.png?r1=186551&r2=186550&pathrev=186551
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/common/browser_action_badge_center.png?r1=186551&r2=186550&pathrev=186551

New 2x browser action badge icons: fix transparency.

BUG= 177734 
TEST=See bug; with a high DPI display, install an extension with browser action badge. See background color painted correctly.

Review URL: https://codereview.chromium.org/12548009
------------------------------------------------------------------------

Comment 18 by yoz@chromium.org, Mar 7 2013

Labels: Merge-Requested
Owner: yoz@chromium.org
Cc: pavanv@chromium.org
Pavan: please get this bug verified in 27.0.1432.0 build. thanks!
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 8 2013

Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=187013

------------------------------------------------------------------------
r187013 | yoz@chromium.org | 2013-03-08T19:30:32.633002Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/ui/resources/default_200_percent/common/browser_action_badge_right.png?r1=187013&r2=187012&pathrev=187013
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/ui/resources/default_200_percent/common/browser_action_badge_center.png?r1=187013&r2=187012&pathrev=187013
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/ui/resources/default_200_percent/common/browser_action_badge_left.png?r1=187013&r2=187012&pathrev=187013

Merge 186551
> New 2x browser action badge icons: fix transparency.
> 
> BUG= 177734 
> TEST=See bug; with a high DPI display, install an extension with browser action badge. See background color painted correctly.
> 
> Review URL: https://codereview.chromium.org/12548009

TBR=yoz@chromium.org
------------------------------------------------------------------------

Comment 22 by yoz@chromium.org, Mar 8 2013

Status: Fixed
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Feature-Extensions -Area-UI -Mstone-26 Cr-Platform-Extensions Cr-UI M-26
Status: Assigned
I'm still seeing this on my Pixel with the 26 beta released today (3/13):
Version 26.0.1410.30 beta
Labels: ReleaseBlock-Stable
Status: Fixed
This is actually fixed but 1410.30 didn't have yoz@ changes. The next beta should have the fix for Chrome OS.

Comment 27 by yoz@chromium.org, Mar 14 2013

Yes, looks like 26.0.1410.30 was cut at r186868 which was slightly before the merge to M26 at r187013.
Labels: VerifyIn-27
Labels: -VerifyIn-27
Status: Verified
Google Chrome	26.0.1410.57 (Official Build 191765) beta
Platform	3701.81.0 (Official Build) beta-channel daisy
WebKit	537.31 (@147364)

Sign in to add a comment