Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 177047 Uncheck "Add Desktop shortcuts" is not honored in case of System-level chrome installation.
Starred by 3 users Project Member Reported by pbomm...@chromium.org, Feb 19 2013 Back to list
Status: Verified
Owner: asvitk...@chromium.org
Closed: Feb 2013
Cc: mgaba@chromium.org, ligim...@chromium.org, sail@chromium.org, asvitk...@chromium.org
Components:
OS: Windows
Pri: 1
Type: Bug


Sign in to add a comment
Version: 26.0.1410.10,26.0.1410.5
OS: win7,win8

What steps will reproduce the problem?
1. Install and Launch Chrome 
2. navigate to "Hotdog menu--> Settings --> users --> Add new user 
3. Create User box pop's up with List of Avatars.
4. Uncheck "Add desktop shortcut"
5. click Create

What is the expected output?
When "Add desktop shortcut" is unchecked,There should be any Desktop shortcut created for that profile.

What do you see instead?
Desktop shortcut is getting created for the user.
Not sure it's an regression,Since it's there on previous dev channel will check on older builds and will update the bug accordingly once I have the result.



 
Forgot to mention it was an System-level chrome installation.
Just to clarify, it's being created for the user that was created? Not for "First user"?
Yes for the new User, It creates an Chrome shortcut with name of the profile but Avatar is missing. 
Attached the screenshot.
profileshortcuts.png
30.3 KB View Download
Owner: asvitk...@chromium.org
Status: Assigned
That is definitely wrong. Will take a look.
Status: Started
Able to reproduce, investigating.
Fix sent out for review: https://codereview.chromium.org/12300036/
Patch is in the cq.
Actually, committed directly now.
Project Member Comment 9 by bugdroid1@chromium.org, Feb 20 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183348

------------------------------------------------------------------------
r183348 | asvitkine@chromium.org | 2013-02-20T01:03:03.981827Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc?r1=183348&r2=183347&pathrev=183348
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_shortcut_manager_win.cc?r1=183348&r2=183347&pathrev=183348

Fix spurious profile shortcuts created with a system-level install.

This issue was caused by RenameChromeDesktopShortcutForProfile()
having logic to copy a system-level shortcut to make a user-level
shortcut in the case where a non-profile Chrome shortcut would
need to become a profile shortcut (i.e. the first user's profile
shortcut when creating a second user).

This path was being triggered by the initial change of the profile
avatar when the profile was created. The fix is to not to try
updating profile shortcuts on name/avatar changes when we know the
profile never had a shortcut created (by virtue of the shortcut
name never getting stored).

BUG= 177047 
TEST=On a system-level install, create a new profile with the "create
shortcut" checkbox unchecked. A shortcut should not be created. Change
the profile's name or icon. The shortcut should still not appear.
Review URL: https://codereview.chromium.org/12300036
------------------------------------------------------------------------
Labels: -Action-BisectNeeded Merge-Requested
Fix is very safe.
Labels: -Merge-Requested Merge-Approved
Status: Fixed
Merged to 1410.
Project Member Comment 13 by bugdroid1@chromium.org, Feb 20 2013
Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183600

------------------------------------------------------------------------
r183600 | asvitkine@chromium.org | 2013-02-20T20:12:29.410349Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc?r1=183600&r2=183599&pathrev=183600
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/profiles/profile_shortcut_manager_win.cc?r1=183600&r2=183599&pathrev=183600

Merge 183348
> Fix spurious profile shortcuts created with a system-level install.
> 
> This issue was caused by RenameChromeDesktopShortcutForProfile()
> having logic to copy a system-level shortcut to make a user-level
> shortcut in the case where a non-profile Chrome shortcut would
> need to become a profile shortcut (i.e. the first user's profile
> shortcut when creating a second user).
> 
> This path was being triggered by the initial change of the profile
> avatar when the profile was created. The fix is to not to try
> updating profile shortcuts on name/avatar changes when we know the
> profile never had a shortcut created (by virtue of the shortcut
> name never getting stored).
> 
> BUG= 177047 
> TEST=On a system-level install, create a new profile with the "create
> shortcut" checkbox unchecked. A shortcut should not be created. Change
> the profile's name or icon. The shortcut should still not appear.
> Review URL: https://codereview.chromium.org/12300036

TBR=asvitkine@chromium.org
Review URL: https://codereview.chromium.org/12315010
------------------------------------------------------------------------
Status: Verified
Verified this on Win8/7 and Xp using latest chrome M26(26.0.1410.12), Profiles shortcut's are not getting created when "Add Desktop shortcut" is unchecked. 
Project Member Comment 15 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Feature-Profiles -Mstone-26 Cr-UI Cr-UI-Browser-Profiles M-26
Sign in to add a comment