Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 176457 Translate: enable bad language detection feedback even though the page uses secure scheme
Starred by 1 user Project Member Reported by toyoshim@chromium.org, Feb 15 2013 Back to list
Status: Fixed
Owner: toyoshim@chromium.org
Closed: Feb 2013
Components:
OS: All
Pri: 2
Type: Bug


Sign in to add a comment
The feedback item IDC_TRANSLATE_REPORT_BAD_LANGUAGE_DETECTION is disabled against secure pages.
This was because Chrome used non secure URL for reporting, but now Chrome uses secure one. So, we can safely enable reports also for secure pages.
 
Project Member Comment 1 by bugdroid1@chromium.org, Feb 15 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182737

------------------------------------------------------------------------
r182737 | toyoshim@chromium.org | 2013-02-15T16:46:06.680276Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/options_menu_model.cc?r1=182737&r2=182736&pathrev=182737

Translate: enable bad language detection reports for secure pages

Now, Chrome uses a secure URL for reporting feedbacks. We don't have to
restrict feedbacks against secure pages any more.

BUG= 176457 


Review URL: https://chromiumcodereview.appspot.com/12261053
------------------------------------------------------------------------
Labels: -Mstone-27 Mstone-26 Merge-Requested
Labels: -Merge-Requested Merge-Approved
Project Member Comment 4 by bugdroid1@chromium.org, Feb 18 2013
Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=183052

------------------------------------------------------------------------
r183052 | toyoshim@chromium.org | 2013-02-18T02:43:32.269842Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/translate/options_menu_model.cc?r1=183052&r2=183051&pathrev=183052

Merge 182737
> Translate: enable bad language detection reports for secure pages
> 
> Now, Chrome uses a secure URL for reporting feedbacks. We don't have to
> restrict feedbacks against secure pages any more.
> 
> BUG= 176457 
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12261053

TBR=toyoshim@chromium.org
Review URL: https://codereview.chromium.org/12295007
------------------------------------------------------------------------
Status: Fixed
Done.
The report for secure pages will be available at the next m26 and later.
Project Member Comment 6 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Mstone-26 -Feature-Translate Cr-UI M-26 Cr-UI-Browser-Translate
Sign in to add a comment