Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 175858 [Linux] The panel does not accept keyboard input when it is minimized and expanded
Starred by 1 user Project Member Reported by jianli@chromium.org, Feb 12, 2013 Back to list
Status: Verified
Owner: jianli@chromium.org
Closed: Feb 2013
Cc: levin@chromium.org, dim...@chromium.org, markdavidscott@google.com, mbollu@chromium.org, nklee@chromium.org
Components:
OS: Linux
Pri: 2
Type: Bug


Sign in to add a comment
Version: 25.0
OS: Linux

What steps will reproduce the problem?
1. Launch a docked panel
2. Make sure the panel is focused and then click the minimize button to collapse the panel
3. Expand the panel by clicking on the titlebar or the restore button

What is the expected output? What do you see instead?
Expect that the panel should be painted as active and could receive keyboard input. Instead, the panel is inactive. No matter how you click on it again, it does not become active and does not accept the keyboard input.


 
Comment 1 by jianli@chromium.org, Feb 12, 2013
Status: Started
Comment 2 by dim...@chromium.org, Feb 13, 2013
Labels: Mstone-26
Since the fix is simple and very isolated, we should ask for M26 port as well, to reduce frustration of Linux users.
Project Member Comment 3 by bugdroid1@chromium.org, Feb 13, 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182121

------------------------------------------------------------------------
r182121 | jianli@chromium.org | 2013-02-13T04:44:02.621790Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/panels/panel_gtk.cc?r1=182121&r2=182120&pathrev=182121
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/panels/panel_titlebar_gtk.cc?r1=182121&r2=182120&pathrev=182121

Fix bug 175858: [Linux] The panel does not accept keyboard input when it is minimized and expanded

BUG= 175858 
TEST=Manual test by following the repro steps in the bug


Review URL: https://chromiumcodereview.appspot.com/12223114
------------------------------------------------------------------------
Comment 4 by jianli@chromium.org, Feb 14, 2013
Status: Fixed
Comment 5 by jianli@chromium.org, Feb 14, 2013
Labels: Merge-Requested
The fix is simple and not risky. Could we please merge it into M26?
Comment 6 by dharani@chromium.org, Feb 15, 2013
Labels: -Merge-Requested Merge-Approved
Comment 7 by mbollu@chromium.org, Feb 15, 2013
Cc: mbollu@chromium.org
Labels: Action-FeedbackNeeded
Is this the dock panel we talking about. Please confirm.
Screenshot from 2013-02-15 13:59:12.png
55.7 KB View Download
Comment 8 by jianli@chromium.org, Feb 15, 2013
No.

Please use the attached test extension to launch the docked panel.
simple_panel.zip
25.4 KB Download
Comment 9 by mbollu@chromium.org, Feb 15, 2013
Labels: -Action-FeedbackNeeded
Verified and not reproducible on latest Chrome unstable build for Linux Ubuntu 12.04.
Project Member Comment 10 by bugdroid1@chromium.org, Feb 15, 2013
Labels: -Merge-Approved merge-merged-1410
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182851

------------------------------------------------------------------------
r182851 | jianli@chromium.org | 2013-02-15T22:48:15.376734Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/gtk/panels/panel_gtk.cc?r1=182851&r2=182850&pathrev=182851
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/gtk/panels/panel_titlebar_gtk.cc?r1=182851&r2=182850&pathrev=182851

Merge 182121
> Fix bug 175858: [Linux] The panel does not accept keyboard input when it is minimized and expanded
> 
> BUG= 175858 
> TEST=Manual test by following the repro steps in the bug
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12223114

TBR=jianli@chromium.org
Review URL: https://codereview.chromium.org/12287015
------------------------------------------------------------------------
Labels: TE-Verified-26.0.1410.10
Status: Verified
Works fine using 26.0.1410.10.
Project Member Comment 12 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Area-UI -Feature-Panels -Mstone-26 Cr-UI M-26 Cr-UI-Browser-Panels
Sign in to add a comment